aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPaul Eggert2019-06-27 12:31:27 -0700
committerPaul Eggert2019-06-27 12:35:09 -0700
commit06d2eb33e1d189eee8d89cb5159f779e1600c4f2 (patch)
tree9b3e12a395e5dcf578f7604605e1c547ed6fe237 /src
parentf59a3f3d61c7da8a22ddb13185ae2271865ae155 (diff)
downloademacs-06d2eb33e1d189eee8d89cb5159f779e1600c4f2.tar.gz
emacs-06d2eb33e1d189eee8d89cb5159f779e1600c4f2.zip
Omit a few minor unnecessary range checks
Based on Pip Cet’s review (Bug#36370#19). * src/fileio.c (Fdo_auto_save): * src/image.c (lookup_image): * src/textprop.c (Fnext_single_char_property_change): Prefer XFIXNUM to XFIXNAT for clarity and consistency with neighboring code, and to avoid unnecessary range checks. * src/image.c (lookup_image): Omit unnecessary range checks.
Diffstat (limited to 'src')
-rw-r--r--src/fileio.c2
-rw-r--r--src/image.c12
-rw-r--r--src/textprop.c4
3 files changed, 9 insertions, 9 deletions
diff --git a/src/fileio.c b/src/fileio.c
index 61e10dac47f..ed1d2aedf37 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -5852,7 +5852,7 @@ A non-nil CURRENT-ONLY argument means save only current buffer. */)
5852 spare the user annoying messages. */ 5852 spare the user annoying messages. */
5853 && XFIXNUM (BVAR (b, save_length)) > 5000 5853 && XFIXNUM (BVAR (b, save_length)) > 5000
5854 && (growth_factor * (BUF_Z (b) - BUF_BEG (b)) 5854 && (growth_factor * (BUF_Z (b) - BUF_BEG (b))
5855 < (growth_factor - 1) * XFIXNAT (BVAR (b, save_length))) 5855 < (growth_factor - 1) * XFIXNUM (BVAR (b, save_length)))
5856 /* These messages are frequent and annoying for `*mail*'. */ 5856 /* These messages are frequent and annoying for `*mail*'. */
5857 && !NILP (BVAR (b, filename)) 5857 && !NILP (BVAR (b, filename))
5858 && NILP (no_message)) 5858 && NILP (no_message))
diff --git a/src/image.c b/src/image.c
index bbf25b4d58f..f3d6508f460 100644
--- a/src/image.c
+++ b/src/image.c
@@ -2385,18 +2385,18 @@ lookup_image (struct frame *f, Lisp_Object spec)
2385#endif 2385#endif
2386 2386
2387 ascent = image_spec_value (spec, QCascent, NULL); 2387 ascent = image_spec_value (spec, QCascent, NULL);
2388 if (RANGED_FIXNUMP (0, ascent, INT_MAX)) 2388 if (FIXNUMP (ascent))
2389 img->ascent = XFIXNAT (ascent); 2389 img->ascent = XFIXNUM (ascent);
2390 else if (EQ (ascent, Qcenter)) 2390 else if (EQ (ascent, Qcenter))
2391 img->ascent = CENTERED_IMAGE_ASCENT; 2391 img->ascent = CENTERED_IMAGE_ASCENT;
2392 2392
2393 margin = image_spec_value (spec, QCmargin, NULL); 2393 margin = image_spec_value (spec, QCmargin, NULL);
2394 if (RANGED_FIXNUMP (0, margin, INT_MAX)) 2394 if (FIXNUMP (margin))
2395 img->vmargin = img->hmargin = XFIXNAT (margin); 2395 img->vmargin = img->hmargin = XFIXNUM (margin);
2396 else if (CONSP (margin)) 2396 else if (CONSP (margin))
2397 { 2397 {
2398 img->hmargin = XFIXNAT (XCAR (margin)); 2398 img->hmargin = XFIXNUM (XCAR (margin));
2399 img->vmargin = XFIXNAT (XCDR (margin)); 2399 img->vmargin = XFIXNUM (XCDR (margin));
2400 } 2400 }
2401 2401
2402 relief = image_spec_value (spec, QCrelief, NULL); 2402 relief = image_spec_value (spec, QCrelief, NULL);
diff --git a/src/textprop.c b/src/textprop.c
index 3026ec7e992..9023f4efa06 100644
--- a/src/textprop.c
+++ b/src/textprop.c
@@ -799,10 +799,10 @@ last valid position in OBJECT. */)
799 else 799 else
800 CHECK_FIXNUM_COERCE_MARKER (limit); 800 CHECK_FIXNUM_COERCE_MARKER (limit);
801 801
802 if (XFIXNAT (position) >= XFIXNUM (limit)) 802 if (XFIXNUM (position) >= XFIXNUM (limit))
803 { 803 {
804 position = limit; 804 position = limit;
805 if (XFIXNAT (position) > ZV) 805 if (XFIXNUM (position) > ZV)
806 XSETFASTINT (position, ZV); 806 XSETFASTINT (position, ZV);
807 } 807 }
808 else 808 else