Merged from emacs@sv.gnu.org

Patches applied:

 * emacs@sv.gnu.org/emacs--devo--0--patch-128
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-129
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-130
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-131
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-132
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-133
   Update from CVS

 * emacs@sv.gnu.org/emacs--devo--0--patch-134
   Merge from gnus--rel--5.10

 * emacs@sv.gnu.org/emacs--devo--0--patch-135
   Update from CVS

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-43
   Munge arch explicit ids in etc/images to match Emacs

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-44
   Update from CVS

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-45
   Update from CVS

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-46
   Update from CVS

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-47
   Update from CVS

 * emacs@sv.gnu.org/gnus--rel--5.10--patch-48
   Update from CVS

git-archimport-id: lorentey@elte.hu--2004/emacs--multi-tty--0--patch-524

6 files changed, 179 insertions, 41 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index 79db6d09d0b..11fe6f910e4 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,39 @@
+2006-03-02  Kim F. Storm  <storm@cua.dk>
+
+        * frame.h (struct frame): New member n_tool_bar_rows.
+
+        * xdisp.c: Minimize the unpleasent visual impact of the requirement
+        that non-toolkit tool-bars must occupy an integral number of screen
+        lines, by distributing the rows evenly over the tool-bar screen area.
+        (Vtool_bar_border): New variable.
+        (syms_of_xdisp): DEFVAR_LISP it.
+        (display_tool_bar_line): Add HEIGHT arg for desired row height.  Make
+        tool-bar row the desired height.  Use default face for border below
+        tool-bar.
+        (tool_bar_lines_needed): Add N_ROWS arg.  Use it to return number of
+        actual tool-bar rows.
+        (redisplay_tool_bar): Calculate f->n_tool_bar_rows initially.
+        Adjust the height of the tool-bar rows to fill tool-bar screen area.
+        (redisplay_tool_bar): Calculate f->n_tool_bar_rows when tool-bar area
+        is resized.
+
+2006-03-01  Luc Teirlinck  <teirllm@auburn.edu>
+
+        * search.c (Fregexp_quote): Do not precede a literal `]' with two
+        backslashes to try to make clear that it has a literal meaning; it
+        does not do that.  (It could close a character alternative
+        containing a backslash.)
+
+2006-02-28  Chong Yidong  <cyd@stupidchicken.com>
+
+        * xselect.c (x_catch_errors_unwind): New function.
+        (x_reply_selection_request): Put x_uncatch_errors in an unwind.
+        (Fx_get_atom_name): Call x_uncatch_errors earlier.
+
+        * window.c (Qscroll_up, Qscroll_down): New syms.
+        (window_scroll_pixel_based): Make preserve_y static to avoid
+        getting point stuck when scrolling 1 line.
+
 2006-02-26  Chong Yidong  <cyd@stupidchicken.com>
 
         * xterm.h, xterm.c (x_uncatch_errors): Delete unneccessary
diff --git a/src/frame.h b/src/frame.h
index ae80c03f9ca..aa4a00d6dfa 100644
--- a/src/frame.h
+++ b/src/frame.h
@@ -205,6 +205,7 @@ struct frame
   /* Margin at the top of the frame.  Used to display the tool-bar.  */
   int tool_bar_lines;
 
+  int n_tool_bar_rows;
   int n_tool_bar_items;
 
   /* A buffer for decode_mode_line. */
diff --git a/src/search.c b/src/search.c
index 04b58c78d3f..b92812597d5 100644
--- a/src/search.c
+++ b/src/search.c
@@ -3066,7 +3066,7 @@ DEFUN ("regexp-quote", Fregexp_quote, Sregexp_quote, 1, 1, 0,
 
   for (; in != end; in++)
     {
-      if (*in == '[' || *in == ']'
+      if (*in == '['
           || *in == '*' || *in == '.' || *in == '\\'
           || *in == '?' || *in == '+'
           || *in == '^' || *in == '$')
diff --git a/src/window.c b/src/window.c
index 29701a1ac62..36050ac649e 100644
--- a/src/window.c
+++ b/src/window.c
@@ -52,6 +52,7 @@ Boston, MA 02110-1301, USA.  */
 
 
 Lisp_Object Qwindowp, Qwindow_live_p, Qwindow_configuration_p;
+Lisp_Object Qscroll_up, Qscroll_down;
 Lisp_Object Qwindow_size_fixed;
 extern Lisp_Object Qleft_margin, Qright_margin;
 
@@ -4723,9 +4724,9 @@ window_scroll_pixel_based (window, n, whole, noerror)
   struct text_pos start;
   Lisp_Object tem;
   int this_scroll_margin;
-  int preserve_y;
   /* True if we fiddled the window vscroll field without really scrolling.   */
   int vscrolled = 0;
+  static int preserve_y = -1;
 
   SET_TEXT_POS_FROM_MARKER (start, w->start);
 
@@ -4789,9 +4790,18 @@ window_scroll_pixel_based (window, n, whole, noerror)
      point in the same window line as it is now, so get that line.  */
   if (!NILP (Vscroll_preserve_screen_position))
     {
-      start_display (&it, w, start);
-      move_it_to (&it, PT, -1, -1, -1, MOVE_TO_POS);
-      preserve_y = it.current_y;
+      /* We preserve the goal pixel coordinate across consecutive
+         calls to scroll-up or scroll-down.  This avoids the
+         possibility of point becoming "stuck" on a tall line when
+         scrolling by one line.  */
+      if (preserve_y < 0
+          || (current_kboard->Vlast_command != Qscroll_up
+              && current_kboard->Vlast_command != Qscroll_down))
+        {
+          start_display (&it, w, start);
+          move_it_to (&it, PT, -1, -1, -1, MOVE_TO_POS);
+          preserve_y = it.current_y;
+        }
     }
   else
     preserve_y = -1;
@@ -4928,10 +4938,9 @@ window_scroll_pixel_based (window, n, whole, noerror)
         {
           /* If we have a header line, take account of it.
              This is necessary because we set it.current_y to 0, above.  */
-          if (WINDOW_WANTS_HEADER_LINE_P (w))
-            preserve_y -= CURRENT_HEADER_LINE_HEIGHT (w);
-
-          move_it_to (&it, -1, -1, preserve_y, -1, MOVE_TO_Y);
+          move_it_to (&it, -1, -1,
+                      preserve_y - (WINDOW_WANTS_HEADER_LINE_P (w) ? 1 : 0 ),
+                      -1, MOVE_TO_Y);
           SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
         }
       else
@@ -4985,15 +4994,9 @@ window_scroll_pixel_based (window, n, whole, noerror)
         {
           SET_TEXT_POS_FROM_MARKER (start, w->start);
           start_display (&it, w, start);
-#if 0  /* It's wrong to subtract this here
-          because we called start_display again
-          and did not alter it.current_y this time.  */
-
-          /* If we have a header line, take account of it.  */
-          if (WINDOW_WANTS_HEADER_LINE_P (w))
-            preserve_y -= CURRENT_HEADER_LINE_HEIGHT (w);
-#endif
-
+          /* It would be wrong to subtract CURRENT_HEADER_LINE_HEIGHT
+             here because we called start_display again and did not
+             alter it.current_y this time.  */
           move_it_to (&it, -1, -1, preserve_y, -1, MOVE_TO_Y);
           SET_PT_BOTH (IT_CHARPOS (it), IT_BYTEPOS (it));
         }
@@ -6990,6 +6993,12 @@ init_window ()
 void
 syms_of_window ()
 {
+  Qscroll_up = intern ("scroll-up");
+  staticpro (&Qscroll_up);
+
+  Qscroll_down = intern ("scroll-down");
+  staticpro (&Qscroll_down);
+
   Qwindow_size_fixed = intern ("window-size-fixed");
   staticpro (&Qwindow_size_fixed);
   Fset (Qwindow_size_fixed, Qnil);
diff --git a/src/xdisp.c b/src/xdisp.c
index 1361607010a..41c8546aac9 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -269,6 +269,12 @@ int auto_raise_tool_bar_buttons_p;
 
 int make_cursor_line_fully_visible_p;
 
+/* Margin below tool bar in pixels.  0 or nil means no margin.
+   If value is `internal-border-width' or `border-width',
+   the corresponding frame parameter is used.  */
+
+Lisp_Object Vtool_bar_border;
+
 /* Margin around tool bar buttons in pixels.  */
 
 Lisp_Object Vtool_bar_button_margin;
@@ -839,7 +845,7 @@ static void store_mode_line_noprop_char P_ ((char));
 static int store_mode_line_noprop P_ ((const unsigned char *, int, int));
 static void x_consider_frame_title P_ ((Lisp_Object));
 static void handle_stop P_ ((struct it *));
-static int tool_bar_lines_needed P_ ((struct frame *));
+static int tool_bar_lines_needed P_ ((struct frame *, int *));
 static int single_display_spec_intangible_p P_ ((Lisp_Object));
 static void ensure_echo_area_buffers P_ ((void));
 static Lisp_Object unwind_with_echo_area_buffer P_ ((Lisp_Object));
@@ -950,7 +956,7 @@ static int in_ellipses_for_invisible_text_p P_ ((struct display_pos *,
 static void update_tool_bar P_ ((struct frame *, int));
 static void build_desired_tool_bar_string P_ ((struct frame *f));
 static int redisplay_tool_bar P_ ((struct frame *));
-static void display_tool_bar_line P_ ((struct it *));
+static void display_tool_bar_line P_ ((struct it *, int));
 static void notice_overwritten_cursor P_ ((struct window *,
                                            enum glyph_row_area,
                                            int, int, int, int));
@@ -9429,11 +9435,17 @@ build_desired_tool_bar_string (f)
 }
 
 
-/* Display one line of the tool-bar of frame IT->f.  */
+/* Display one line of the tool-bar of frame IT->f.
+
+   HEIGHT specifies the desired height of the tool-bar line.
+   If the actual height of the glyph row is less than HEIGHT, the
+   row's height is increased to HEIGHT, and the icons are centered
+   vertically in the new height.  */
 
 static void
-display_tool_bar_line (it)
+display_tool_bar_line (it, height)
      struct it *it;
+     int height;
 {
   struct glyph_row *row = it->glyph_row;
   int max_x = it->last_visible_x;
@@ -9489,11 +9501,22 @@ display_tool_bar_line (it)
  out:;
 
   row->displays_text_p = row->used[TEXT_AREA] != 0;
+  /* Use default face for the border below the tool bar.  */
+  if (!row->displays_text_p)
+    it->face_id = DEFAULT_FACE_ID;
   extend_face_to_end_of_line (it);
   last = row->glyphs[TEXT_AREA] + row->used[TEXT_AREA] - 1;
   last->right_box_line_p = 1;
   if (last == row->glyphs[TEXT_AREA])
     last->left_box_line_p = 1;
+
+  /* Make line the desired height and center it vertically.  */
+  if ((height -= it->max_ascent + it->max_descent) > 0)
+    {
+      it->max_ascent += height / 2;
+      it->max_descent += (height + 1) / 2;
+    }
+
   compute_line_metrics (it);
 
   /* If line is empty, make it occupy the rest of the tool-bar.  */
@@ -9517,11 +9540,13 @@ display_tool_bar_line (it)
 
 
 /* Value is the number of screen lines needed to make all tool-bar
-   items of frame F visible.  */
+   items of frame F visible.  The number of actual rows needed is
+   returned in *N_ROWS if non-NULL.  */
 
 static int
-tool_bar_lines_needed (f)
+tool_bar_lines_needed (f, n_rows)
      struct frame *f;
+     int *n_rows;
 {
   struct window *w = XWINDOW (f->tool_bar_window);
   struct it it;
@@ -9537,9 +9562,12 @@ tool_bar_lines_needed (f)
     {
       it.glyph_row = w->desired_matrix->rows;
       clear_glyph_row (it.glyph_row);
-      display_tool_bar_line (&it);
+      display_tool_bar_line (&it, 0);
     }
 
+  if (n_rows)
+    *n_rows = it.vpos;
+
   return (it.current_y + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
 }
 
@@ -9568,7 +9596,7 @@ DEFUN ("tool-bar-lines-needed", Ftool_bar_lines_needed, Stool_bar_lines_needed,
       if (f->n_tool_bar_items)
         {
           build_desired_tool_bar_string (f);
-          nlines = tool_bar_lines_needed (f);
+          nlines = tool_bar_lines_needed (f, NULL);
         }
     }
 
@@ -9613,9 +9641,50 @@ redisplay_tool_bar (f)
   build_desired_tool_bar_string (f);
   reseat_to_string (&it, NULL, f->desired_tool_bar_string, 0, 0, 0, -1);
 
+  if (f->n_tool_bar_rows == 0)
+    {
+      (void)tool_bar_lines_needed (f, &f->n_tool_bar_rows);
+      if (f->n_tool_bar_rows == 0)
+        f->n_tool_bar_rows = -1;
+    }
+
   /* Display as many lines as needed to display all tool-bar items.  */
-  while (it.current_y < it.last_visible_y)
-    display_tool_bar_line (&it);
+
+  if (f->n_tool_bar_rows > 0)
+    {
+      int border, rows, height, extra;
+
+      if (INTEGERP (Vtool_bar_border))
+        border = XINT (Vtool_bar_border);
+      else if (EQ (Vtool_bar_border, Qinternal_border_width))
+        border = FRAME_INTERNAL_BORDER_WIDTH (f);
+      else if (EQ (Vtool_bar_border, Qborder_width))
+        border = f->border_width;
+      else
+        border = 0;
+      if (border < 0)
+        border = 0;
+
+      rows = f->n_tool_bar_rows;
+      height = (it.last_visible_y - border) / rows;
+      extra = it.last_visible_y - border - height * rows;
+
+      while (it.current_y < it.last_visible_y)
+        {
+          int h = 0;
+          if (extra > 0 && rows-- > 0)
+            {
+              h = (extra + rows - 1) / rows;
+              extra -= h;
+            }
+          display_tool_bar_line (&it, height + h);
+        }
+    }
+  else
+    {
+      while (it.current_y < it.last_visible_y)
+        display_tool_bar_line (&it, 0);
+    }
 
   /* It doesn't make much sense to try scrolling in the tool-bar
      window, so don't do it.  */
@@ -9648,7 +9717,7 @@ redisplay_tool_bar (f)
       /* Resize windows as needed by changing the `tool-bar-lines'
          frame parameter.  */
       if (change_height_p
-          && (nlines = tool_bar_lines_needed (f),
+          && (nlines = tool_bar_lines_needed (f, &f->n_tool_bar_rows),
               nlines != WINDOW_TOTAL_LINES (w)))
         {
           extern Lisp_Object Qtool_bar_lines;
@@ -23661,6 +23730,14 @@ otherwise.  */);
     doc: /* *Non-nil means to scroll (recenter) cursor line if it is not fully visible.  */);
   make_cursor_line_fully_visible_p = 1;
 
+  DEFVAR_LISP ("tool-bar-border", &Vtool_bar_border,
+    doc: /* *Border below tool-bar in pixels.
+If an integer, use it as the height of the border.
+If it is one of `internal-border-width' or `border-width', use the
+value of the corresponding frame parameter.
+Otherwise, no border is added below the tool-bar.  */);
+  Vtool_bar_border = Qinternal_border_width;
+
   DEFVAR_LISP ("tool-bar-button-margin", &Vtool_bar_button_margin,
     doc: /* *Margin around tool-bar buttons in pixels.
 If an integer, use that for both horizontal and vertical margins.
diff --git a/src/xselect.c b/src/xselect.c
index 8c82a4b85d3..6776e732734 100644
--- a/src/xselect.c
+++ b/src/xselect.c
@@ -55,6 +55,7 @@ static void x_decline_selection_request P_ ((struct input_event *));
 static Lisp_Object x_selection_request_lisp_error P_ ((Lisp_Object));
 static Lisp_Object queue_selection_requests_unwind P_ ((Lisp_Object));
 static Lisp_Object some_frame_on_display P_ ((struct x_display_info *));
+static Lisp_Object x_catch_errors_unwind P_ ((Lisp_Object));
 static void x_reply_selection_request P_ ((struct input_event *, int,
                                            unsigned char *, int, Atom));
 static int waiting_for_other_props_on_window P_ ((Display *, Window));
@@ -618,6 +619,15 @@ x_selection_request_lisp_error (ignore)
     x_decline_selection_request (x_selection_current_request);
   return Qnil;
 }
+
+static Lisp_Object
+x_catch_errors_unwind (dummy)
+     Lisp_Object dummy;
+{
+  BLOCK_INPUT;
+  x_uncatch_errors ();
+  UNBLOCK_INPUT;
+}
 
 
 /* This stuff is so that INCR selections are reentrant (that is, so we can
@@ -711,8 +721,11 @@ x_reply_selection_request (event, format, data, size, type)
   if (reply.property == None)
     reply.property = reply.target;
 
-  /* #### XChangeProperty can generate BadAlloc, and we must handle it! */
   BLOCK_INPUT;
+  /* The protected block contains wait_for_property_change, which can
+     run random lisp code (process handlers) or signal.  Therefore, we
+     put the x_uncatch_errors call in an unwind.  */
+  record_unwind_protect (x_catch_errors_unwind, Qnil);
   x_catch_errors (display);
 
 #ifdef TRACE_SELECTION
@@ -866,9 +879,8 @@ x_reply_selection_request (event, format, data, size, type)
      UNBLOCK to enter the event loop and get possible errors delivered,
      and then BLOCK again because x_uncatch_errors requires it.  */
   BLOCK_INPUT;
-
+  /* This calls x_uncatch_errors.  */
   unbind_to (count, Qnil);
-  x_uncatch_errors ();
   UNBLOCK_INPUT;
 }
 
@@ -1378,7 +1390,7 @@ x_get_foreign_selection (selection_symbol, target_type, time_stamp)
   Atom selection_atom;
   Atom type_atom;
   int secs, usecs;
-  int count;
+  int count = SPECPDL_INDEX ();
   Lisp_Object frame;
 
   if (! FRAME_X_P (sf))
@@ -1409,6 +1421,10 @@ x_get_foreign_selection (selection_symbol, target_type, time_stamp)
 
   BLOCK_INPUT;
 
+  /* The protected block contains wait_reading_process_output, which
+     can run random lisp code (process handlers) or signal.
+     Therefore, we put the x_uncatch_errors call in an unwind.  */
+  record_unwind_protect (x_catch_errors_unwind, Qnil);
   x_catch_errors (display);
 
   TRACE2 ("Get selection %s, type %s",
@@ -1426,8 +1442,6 @@ x_get_foreign_selection (selection_symbol, target_type, time_stamp)
 
   frame = some_frame_on_display (dpyinfo);
 
-  count = SPECPDL_INDEX ();
-
   /* If the display no longer has frames, we can't expect
      to get many more selection requests from it, so don't
      bother trying to queue them.  */
@@ -1449,9 +1463,10 @@ x_get_foreign_selection (selection_symbol, target_type, time_stamp)
   TRACE1 ("  Got event = %d", !NILP (XCAR (reading_selection_reply)));
 
   BLOCK_INPUT;
+  if (x_had_errors_p (display))
+    error ("Cannot get selection");
+  /* This calls x_uncatch_errors.  */
   unbind_to (count, Qnil);
-  x_check_errors (display, "Cannot get selection: %s");
-  x_uncatch_errors ();
   UNBLOCK_INPUT;
 
   if (NILP (XCAR (reading_selection_reply)))
@@ -2687,6 +2702,7 @@ If the value is 0 or the atom is not known, return the empty string.  */)
   Lisp_Object ret = Qnil;
   Display *dpy = FRAME_X_DISPLAY (f);
   Atom atom;
+  int had_errors;
 
   if (INTEGERP (value))
     atom = (Atom) XUINT (value);
@@ -2699,14 +2715,13 @@ If the value is 0 or the atom is not known, return the empty string.  */)
 
   BLOCK_INPUT;
   x_catch_errors (dpy);
-
   name = atom ? XGetAtomName (dpy, atom) : "";
+  had_errors = x_had_errors_p (dpy);
+  x_uncatch_errors ();
 
-  if (! x_had_errors_p (dpy))
+  if (!had_errors)
     ret = make_string (name, strlen (name));
 
-  x_uncatch_errors ();
-
   if (atom && name) XFree (name);
   if (NILP (ret)) ret = make_string ("", 0);