diff options
| author | Paul Eggert | 2025-01-26 22:15:49 -0800 |
|---|---|---|
| committer | Paul Eggert | 2025-01-26 23:05:53 -0800 |
| commit | c0d83876f18cb21abae299d3b4a2a2bd7f117252 (patch) | |
| tree | 78a24ab552c3318b3d5b9ca63e8dfc73ba4aad50 /src | |
| parent | 06fd3f4e98d683b6595899861e47e931724e7020 (diff) | |
| download | emacs-c0d83876f18cb21abae299d3b4a2a2bd7f117252.tar.gz emacs-c0d83876f18cb21abae299d3b4a2a2bd7f117252.zip | |
Avoid undefined behavior with botched pgtk menu
* src/pgtkmenu.c (pgtk_menu_show): Do not dereference save_wv if
null. Problem found by gcc 20250110 (Red Hat 14.2.1-7)
-Wanalyzer-null-dereference.
Diffstat (limited to 'src')
| -rw-r--r-- | src/pgtkmenu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pgtkmenu.c b/src/pgtkmenu.c index 54e1c3739cf..e7a862b0c18 100644 --- a/src/pgtkmenu.c +++ b/src/pgtkmenu.c | |||
| @@ -725,7 +725,7 @@ pgtk_menu_show (struct frame *f, int x, int y, int menuflags, | |||
| 725 | STRINGP (help) ? help : Qnil); | 725 | STRINGP (help) ? help : Qnil); |
| 726 | if (prev_wv) | 726 | if (prev_wv) |
| 727 | prev_wv->next = wv; | 727 | prev_wv->next = wv; |
| 728 | else | 728 | else if (save_wv) |
| 729 | save_wv->contents = wv; | 729 | save_wv->contents = wv; |
| 730 | if (!NILP (descrip)) | 730 | if (!NILP (descrip)) |
| 731 | wv->key = SSDATA (descrip); | 731 | wv->key = SSDATA (descrip); |