aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPo Lu2021-11-09 05:06:24 +0100
committerLars Ingebrigtsen2021-11-09 05:06:24 +0100
commit35f9e0f46975c35ffec494a46dedf03304ca9da1 (patch)
tree8c82531ac44d969058d146d911e3c8ebd4d21839 /src
parentb5efdccefbf29ba1415a72a42cddb3352ec8e1d3 (diff)
downloademacs-35f9e0f46975c35ffec494a46dedf03304ca9da1.tar.gz
emacs-35f9e0f46975c35ffec494a46dedf03304ca9da1.zip
Fix flicker when setting hscroll of xwidget
* src/xterm.c (x_scroll_run): Use original height of xwidget instead of window height and set cairo surface size (bug#51697).
Diffstat (limited to 'src')
-rw-r--r--src/xterm.c24
1 files changed, 14 insertions, 10 deletions
diff --git a/src/xterm.c b/src/xterm.c
index 1fb3d8d7c09..172abe919dd 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -4408,7 +4408,7 @@ x_scroll_run (struct window *w, struct run *run)
4408 Window child = children[i]; 4408 Window child = children[i];
4409 struct xwidget_view *view = xwidget_view_from_window (child); 4409 struct xwidget_view *view = xwidget_view_from_window (child);
4410 4410
4411 if (view) 4411 if (view && !view->hidden)
4412 { 4412 {
4413 int window_y = view->y + view->clip_top; 4413 int window_y = view->y + view->clip_top;
4414 int window_height = view->clip_bottom - view->clip_top; 4414 int window_height = view->clip_bottom - view->clip_top;
@@ -4445,16 +4445,14 @@ x_scroll_run (struct window *w, struct run *run)
4445 view->y = y; 4445 view->y = y;
4446 4446
4447 clip_top = 0; 4447 clip_top = 0;
4448 clip_bottom = window_height; 4448 clip_bottom = XXWIDGET (view->model)->height;
4449 4449
4450 if (y < text_area_y) 4450 if (y < text_area_y)
4451 clip_top = text_area_y - y; 4451 clip_top = text_area_y - y;
4452 4452
4453 if ((y + clip_top + window_height) 4453 if ((y + clip_bottom) > (text_area_y + text_area_height))
4454 > (text_area_y + text_area_height))
4455 { 4454 {
4456 clip_bottom -= (y + clip_top + window_height) 4455 clip_bottom -= (y + clip_bottom) - (text_area_y + text_area_height);
4457 - (text_area_y + text_area_height);
4458 } 4456 }
4459 4457
4460 view->clip_top = clip_top; 4458 view->clip_top = clip_top;
@@ -4468,10 +4466,16 @@ x_scroll_run (struct window *w, struct run *run)
4468 XUnmapWindow (dpy, child); 4466 XUnmapWindow (dpy, child);
4469 } 4467 }
4470 else 4468 else
4471 XMoveResizeWindow (dpy, child, view->x + view->clip_left, 4469 {
4472 view->y + view->clip_top, 4470 XMoveResizeWindow (dpy, child, view->x + view->clip_left,
4473 view->clip_right - view->clip_left, 4471 view->y + view->clip_top,
4474 view->clip_bottom - view->clip_top); 4472 view->clip_right - view->clip_left,
4473 view->clip_bottom - view->clip_top);
4474 cairo_xlib_surface_set_size (view->cr_surface,
4475 view->clip_right - view->clip_left,
4476 view->clip_bottom - view->clip_top);
4477 }
4478 xwidget_expose (view);
4475 XFlush (dpy); 4479 XFlush (dpy);
4476 } 4480 }
4477 } 4481 }