Prefer static to extern where either will do

* src/charset.c (charset_table_size):
* src/pdumper.c (dump_private):
* src/sysdep.c (init_sigsegv):
* src/window.c (old_selected_window):
Now static.
* src/charset.c (charset_table_size):
Now int, since the value always fits in int.
* src/gtkutil.c (xg_gtk_initialized): Now present only if
HAVE_XWIDGETS, to make it clearer that this is an xwidgets
hack.  All uses changed.
* src/lread.c (ndefsubr): Remove; unused.
* src/pdumper.h: Use usual GNU indenting style for functions,
since my static-vs-extern checking hack relies on it.
(dump_public): Always declare; simpler and doesn’t hurt.
(pdumper_handle_page_fault): Remove unused decl.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/window.c b/src/window.c
index c0d745995a8..1b474a663a4 100644
--- a/src/window.c
+++ b/src/window.c
@@ -81,7 +81,7 @@ Lisp_Object selected_window;
 /* The value of selected_window at the last time window change
    functions were run.  This is always the same as
    FRAME_OLD_SELECTED_WINDOW (old_selected_frame).  */
-Lisp_Object old_selected_window;
+static Lisp_Object old_selected_window;
 
 /* A list of all windows for use by next_window and Fwindow_list.
    Functions creating or deleting windows should invalidate this cache