diff options
| author | Paul Eggert | 2011-05-12 13:23:33 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-05-12 13:23:33 -0700 |
| commit | 08dc5ae68e9c699410256ca9052bd09f336ac87f (patch) | |
| tree | 6572186aea70cb9f3f736743271c4d0b500650b6 /src/term.c | |
| parent | 86db42d22397effbb6e9edc5ae11d806847f0d3e (diff) | |
| download | emacs-08dc5ae68e9c699410256ca9052bd09f336ac87f.tar.gz emacs-08dc5ae68e9c699410256ca9052bd09f336ac87f.zip | |
Be more systematic about user-interface timestamps.
Before, the code sometimes used 'Time', sometimes 'unsigned long',
and sometimes 'EMACS_UINT', to represent these timestamps. This
change causes it to use 'Time' uniformly, as that's what X uses.
This makes the code easier to follow, and makes it easier to catch
integer overflow bugs such as Bug#8664.
* frame.c (Fmouse_position, Fmouse_pixel_position):
Use Time, not unsigned long, for user-interface timestamps.
* keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
(button_down_time, make_lispy_position, make_lispy_movement): Likewise.
* keyboard.h (last_event_timestamp): Likewise.
* menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
* menu.h (xmenu_show): Likewise.
* term.c (term_mouse_position): Likewise.
* termhooks.h (struct input_event.timestamp): Likewise.
(struct terminal.mouse_position_hook): Likewise.
* xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
* xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
* systime.h (Time): New decl. Pull it in from <X11/X.h> if
HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
what it was before.
* menu.h, termhooks.h: Include "systime.h", for Time.
Diffstat (limited to 'src/term.c')
| -rw-r--r-- | src/term.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/term.c b/src/term.c index c68228cc51a..34320a1ad6d 100644 --- a/src/term.c +++ b/src/term.c | |||
| @@ -2698,7 +2698,7 @@ term_mouse_movement (FRAME_PTR frame, Gpm_Event *event) | |||
| 2698 | static void | 2698 | static void |
| 2699 | term_mouse_position (FRAME_PTR *fp, int insist, Lisp_Object *bar_window, | 2699 | term_mouse_position (FRAME_PTR *fp, int insist, Lisp_Object *bar_window, |
| 2700 | enum scroll_bar_part *part, Lisp_Object *x, | 2700 | enum scroll_bar_part *part, Lisp_Object *x, |
| 2701 | Lisp_Object *y, unsigned long *timeptr) | 2701 | Lisp_Object *y, Time *timeptr) |
| 2702 | { | 2702 | { |
| 2703 | struct timeval now; | 2703 | struct timeval now; |
| 2704 | 2704 | ||