diff options
| author | Paul Eggert | 2012-09-30 23:36:54 -0700 |
|---|---|---|
| committer | Paul Eggert | 2012-09-30 23:36:54 -0700 |
| commit | b0ab8123df78b7149d1f55b2ef0d3095c3f10628 (patch) | |
| tree | 14d324cb46348dbf9a4568c7050d2776259c5358 /src/process.c | |
| parent | 05584c31090df82f831f2998939fd423f036e86d (diff) | |
| download | emacs-b0ab8123df78b7149d1f55b2ef0d3095c3f10628.tar.gz emacs-b0ab8123df78b7149d1f55b2ef0d3095c3f10628.zip | |
Prefer plain 'static' to 'static inline'.
With static functions, modern compilers inline pretty well by
themselves; advice from programmers often hurts as much as it helps.
On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
this change shrinks the text size of the Emacs executable by 1.1%
without affecting CPU significantly in my benchmark.
* alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
(live_float_p, live_misc_p, live_vector_p, live_buffer_p)
(mark_maybe_object, mark_maybe_pointer, bounded_number):
* buffer.c (bset_abbrev_mode, bset_abbrev_table)
(bset_auto_fill_function, bset_auto_save_file_format)
(bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
(bset_bidi_display_reordering, bset_buffer_file_coding_system)
(bset_cache_long_line_scans, bset_case_fold_search)
(bset_ctl_arrow, bset_cursor_in_non_selected_windows)
(bset_cursor_type, bset_display_table, bset_extra_line_spacing)
(bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
(bset_fringe_indicator_alist, bset_fringes_outside_margins)
(bset_header_line_format, bset_indicate_buffer_boundaries)
(bset_indicate_empty_lines, bset_invisibility_spec)
(bset_left_fringe_width, bset_major_mode, bset_mark)
(bset_minor_modes, bset_mode_line_format, bset_mode_name)
(bset_name, bset_overwrite_mode, bset_pt_marker)
(bset_right_fringe_width, bset_save_length)
(bset_scroll_bar_width, bset_scroll_down_aggressively)
(bset_scroll_up_aggressively, bset_selective_display)
(bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
(bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
(set_buffer_overlays_after):
* category.c (bset_category_table):
* charset.c (read_hex):
* coding.c (produce_composition, produce_charset)
(handle_composition_annotation, handle_charset_annotation)
(char_encodable_p):
* dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
(assign_row, set_frame_matrix_frame, make_current)
(add_row_entry):
* eval.c (set_specpdl_symbol, set_specpdl_old_value):
* fns.c (maybe_resize_hash_table):
* frame.c (fset_buffer_predicate, fset_minibuffer_window):
* gmalloc.c (register_heapinfo):
* image.c (lookup_image_type):
* intervals.c (set_interval_object, set_interval_left)
(set_interval_right, copy_interval_parent, rotate_right)
(rotate_left, balance_possible_root_interval):
* keyboard.c (kset_echo_string, kset_kbd_queue)
(kset_keyboard_translate_table, kset_last_prefix_arg)
(kset_last_repeatable_command, kset_local_function_key_map)
(kset_overriding_terminal_local_map, kset_real_last_command)
(kset_system_key_syms, clear_event, set_prop):
* lread.c (digit_to_number):
* marker.c (attach_marker, live_buffer, set_marker_internal):
* nsterm.m (ns_compute_glyph_string_overhangs):
* process.c (pset_buffer, pset_command)
(pset_decode_coding_system, pset_decoding_buf)
(pset_encode_coding_system, pset_encoding_buf, pset_filter)
(pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
(pset_status, pset_tty_name, pset_type, pset_write_queue):
* syntax.c (bset_syntax_table, dec_bytepos):
* terminal.c (tset_param_alist):
* textprop.c (interval_has_some_properties)
(interval_has_some_properties_list):
* window.c (wset_combination_limit, wset_dedicated)
(wset_display_table, wset_hchild, wset_left_fringe_width)
(wset_left_margin_cols, wset_new_normal, wset_new_total)
(wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
(wset_right_fringe_width, wset_right_margin_cols)
(wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
(wset_vertical_scroll_bar_type, wset_window_parameters):
* xdisp.c (wset_base_line_number, wset_base_line_pos)
(wset_column_number_displayed, wset_region_showing)
(window_box_edges, run_window_scroll_functions)
(append_glyph_string_lists, prepend_glyph_string_lists)
(append_glyph_string, set_glyph_string_background_width)
(append_glyph, append_composite_glyph)
(take_vertical_position_into_account):
* xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
(face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
(lface_hash, lface_same_font_attributes_p, lookup_face):
* xml.c (libxml2_loaded_p):
* xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
(x_set_glyph_string_clipping, x_clear_glyph_string_rect):
Now 'static', not 'static inline'.
Fixes: debbugs:12541
Diffstat (limited to 'src/process.c')
| -rw-r--r-- | src/process.c | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/src/process.c b/src/process.c index ab215766c07..dfc89809fa5 100644 --- a/src/process.c +++ b/src/process.c | |||
| @@ -335,82 +335,82 @@ static struct sockaddr_and_len { | |||
| 335 | static int pty_max_bytes; | 335 | static int pty_max_bytes; |
| 336 | 336 | ||
| 337 | /* These setters are used only in this file, so they can be private. */ | 337 | /* These setters are used only in this file, so they can be private. */ |
| 338 | static inline void | 338 | static void |
| 339 | pset_buffer (struct Lisp_Process *p, Lisp_Object val) | 339 | pset_buffer (struct Lisp_Process *p, Lisp_Object val) |
| 340 | { | 340 | { |
| 341 | p->buffer = val; | 341 | p->buffer = val; |
| 342 | } | 342 | } |
| 343 | static inline void | 343 | static void |
| 344 | pset_command (struct Lisp_Process *p, Lisp_Object val) | 344 | pset_command (struct Lisp_Process *p, Lisp_Object val) |
| 345 | { | 345 | { |
| 346 | p->command = val; | 346 | p->command = val; |
| 347 | } | 347 | } |
| 348 | static inline void | 348 | static void |
| 349 | pset_decode_coding_system (struct Lisp_Process *p, Lisp_Object val) | 349 | pset_decode_coding_system (struct Lisp_Process *p, Lisp_Object val) |
| 350 | { | 350 | { |
| 351 | p->decode_coding_system = val; | 351 | p->decode_coding_system = val; |
| 352 | } | 352 | } |
| 353 | static inline void | 353 | static void |
| 354 | pset_decoding_buf (struct Lisp_Process *p, Lisp_Object val) | 354 | pset_decoding_buf (struct Lisp_Process *p, Lisp_Object val) |
| 355 | { | 355 | { |
| 356 | p->decoding_buf = val; | 356 | p->decoding_buf = val; |
| 357 | } | 357 | } |
| 358 | static inline void | 358 | static void |
| 359 | pset_encode_coding_system (struct Lisp_Process *p, Lisp_Object val) | 359 | pset_encode_coding_system (struct Lisp_Process *p, Lisp_Object val) |
| 360 | { | 360 | { |
| 361 | p->encode_coding_system = val; | 361 | p->encode_coding_system = val; |
| 362 | } | 362 | } |
| 363 | static inline void | 363 | static void |
| 364 | pset_encoding_buf (struct Lisp_Process *p, Lisp_Object val) | 364 | pset_encoding_buf (struct Lisp_Process *p, Lisp_Object val) |
| 365 | { | 365 | { |
| 366 | p->encoding_buf = val; | 366 | p->encoding_buf = val; |
| 367 | } | 367 | } |
| 368 | static inline void | 368 | static void |
| 369 | pset_filter (struct Lisp_Process *p, Lisp_Object val) | 369 | pset_filter (struct Lisp_Process *p, Lisp_Object val) |
| 370 | { | 370 | { |
| 371 | p->filter = val; | 371 | p->filter = val; |
| 372 | } | 372 | } |
| 373 | static inline void | 373 | static void |
| 374 | pset_log (struct Lisp_Process *p, Lisp_Object val) | 374 | pset_log (struct Lisp_Process *p, Lisp_Object val) |
| 375 | { | 375 | { |
| 376 | p->log = val; | 376 | p->log = val; |
| 377 | } | 377 | } |
| 378 | static inline void | 378 | static void |
| 379 | pset_mark (struct Lisp_Process *p, Lisp_Object val) | 379 | pset_mark (struct Lisp_Process *p, Lisp_Object val) |
| 380 | { | 380 | { |
| 381 | p->mark = val; | 381 | p->mark = val; |
| 382 | } | 382 | } |
| 383 | static inline void | 383 | static void |
| 384 | pset_name (struct Lisp_Process *p, Lisp_Object val) | 384 | pset_name (struct Lisp_Process *p, Lisp_Object val) |
| 385 | { | 385 | { |
| 386 | p->name = val; | 386 | p->name = val; |
| 387 | } | 387 | } |
| 388 | static inline void | 388 | static void |
| 389 | pset_plist (struct Lisp_Process *p, Lisp_Object val) | 389 | pset_plist (struct Lisp_Process *p, Lisp_Object val) |
| 390 | { | 390 | { |
| 391 | p->plist = val; | 391 | p->plist = val; |
| 392 | } | 392 | } |
| 393 | static inline void | 393 | static void |
| 394 | pset_sentinel (struct Lisp_Process *p, Lisp_Object val) | 394 | pset_sentinel (struct Lisp_Process *p, Lisp_Object val) |
| 395 | { | 395 | { |
| 396 | p->sentinel = val; | 396 | p->sentinel = val; |
| 397 | } | 397 | } |
| 398 | static inline void | 398 | static void |
| 399 | pset_status (struct Lisp_Process *p, Lisp_Object val) | 399 | pset_status (struct Lisp_Process *p, Lisp_Object val) |
| 400 | { | 400 | { |
| 401 | p->status = val; | 401 | p->status = val; |
| 402 | } | 402 | } |
| 403 | static inline void | 403 | static void |
| 404 | pset_tty_name (struct Lisp_Process *p, Lisp_Object val) | 404 | pset_tty_name (struct Lisp_Process *p, Lisp_Object val) |
| 405 | { | 405 | { |
| 406 | p->tty_name = val; | 406 | p->tty_name = val; |
| 407 | } | 407 | } |
| 408 | static inline void | 408 | static void |
| 409 | pset_type (struct Lisp_Process *p, Lisp_Object val) | 409 | pset_type (struct Lisp_Process *p, Lisp_Object val) |
| 410 | { | 410 | { |
| 411 | p->type = val; | 411 | p->type = val; |
| 412 | } | 412 | } |
| 413 | static inline void | 413 | static void |
| 414 | pset_write_queue (struct Lisp_Process *p, Lisp_Object val) | 414 | pset_write_queue (struct Lisp_Process *p, Lisp_Object val) |
| 415 | { | 415 | { |
| 416 | p->write_queue = val; | 416 | p->write_queue = val; |