diff options
| author | Paul Eggert | 2018-10-10 23:17:18 -0700 |
|---|---|---|
| committer | Paul Eggert | 2018-10-10 23:19:42 -0700 |
| commit | 5bd8cfc14d4b0c78c07e65a583f42a10c4cbc06d (patch) | |
| tree | c51b2a470f62679f5e5c3f6f55d90aa0082d0133 /src/process.c | |
| parent | fd3a48fcd8bb212ec12b9b10a79de0ae605ee93b (diff) | |
| download | emacs-5bd8cfc14d4b0c78c07e65a583f42a10c4cbc06d.tar.gz emacs-5bd8cfc14d4b0c78c07e65a583f42a10c4cbc06d.zip | |
Fix mishandling of symbols that look like numbers
* src/bignum.c (make_neg_biguint): New function.
* src/lread.c (read1): Do not mishandle an unquoted symbol
with name equal to something like "1\0x", i.e., a string
of numeric form followed by a NUL byte.
Formerly these symbols were misread as numbers.
(string_to_number): Change last argument from an integer flag
to a pointer to the length. This lets the caller figure out
how much of the prefix was used. All callers changed.
Add a fast path if the integer (sans sign) fits in uintmax_t.
Update comments and simplify now that bignums are present.
* src/print.c (print_object): Fix quoting of symbols that look
like numbers, by relying on string_to_number for the tricky
cases rather than trying to redo its logic, incorrectly. For
example, (read (prin1-to-string '\1e+NaN)) formerly returned
"1e+NaN", which was wrong: a backslash is needed in the output
to prevent it from being read as a NaN. Escape NO_BREAK_SPACE
too, since lread.c treats it like SPACE.
* test/src/print-tests.el (print-read-roundtrip):
Add tests illustrating the abovementioned bugs.
Diffstat (limited to 'src/process.c')
| -rw-r--r-- | src/process.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/process.c b/src/process.c index a9638dfc2df..6cda4f27acc 100644 --- a/src/process.c +++ b/src/process.c | |||
| @@ -6852,7 +6852,12 @@ SIGCODE may be an integer, or a symbol whose name is a signal name. */) | |||
| 6852 | { | 6852 | { |
| 6853 | Lisp_Object tem = Fget_process (process); | 6853 | Lisp_Object tem = Fget_process (process); |
| 6854 | if (NILP (tem)) | 6854 | if (NILP (tem)) |
| 6855 | tem = string_to_number (SSDATA (process), 10, 0); | 6855 | { |
| 6856 | ptrdiff_t len; | ||
| 6857 | tem = string_to_number (SSDATA (process), 10, &len); | ||
| 6858 | if (NILP (tem) || len != SBYTES (process)) | ||
| 6859 | return Qnil; | ||
| 6860 | } | ||
| 6856 | process = tem; | 6861 | process = tem; |
| 6857 | } | 6862 | } |
| 6858 | else if (!NUMBERP (process)) | 6863 | else if (!NUMBERP (process)) |