Handle errno and exit status a bit more carefully.

* lib/ignore-value.h: Remove this gnulib-imported file.
* lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
* admin/merge-gnulib (GNULIB_MODULES): Remove ignore-value.
* src/callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
number into an exit status.  Instead, use EXIT_CANCELED.
(child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
* src/callproc.c (relocate_fd):
* src/emacs.c (close_output_streams, main):
* src/process.c (create_process):
* src/sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
Use emacs_perror for simplicity.
* src/callproc.c (relocate_fd, main):
* src/sysdep.c (sys_subshell):
Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
(shut_down_emacs): Use emacs_write, not write.
* src/emacs.c, src/sysdep.c: Don't include <ignore-value.h>.
* src/fileio.c (Fcopy_file, e_write):
* src/nsterm.m (ns_select):
* src/process.c (send_process):
* src/sound.c (vox_write):
Use emacs_write_sig, not emacs_write.
* src/lisp.h (emacs_write_sig, emacs_perror): New decls.
* src/process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
New constants.
* src/sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
of write.
(emacs_full_write): New function.
(emacs_write): Rewrite to use it.
(emacswrite_sig, emacs_perror): New functions.
* src/xrdb.c (fatal): Don't invoke perror, since errno might be garbage.

1 files changed, 4 insertions, 6 deletions

diff --git a/src/process.c b/src/process.c
index 1c210649024..36ca1cf6784 100644
--- a/src/process.c
+++ b/src/process.c
@@ -1752,7 +1752,7 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir)
           tcgetattr (xforkin, &t);
           t.c_lflag = LDISC1;
           if (tcsetattr (xforkin, TCSANOW, &t) < 0)
-            emacs_write (1, "create_process/tcsetattr LDISC1 failed\n", 39);
+            emacs_perror ("create_process/tcsetattr LDISC1");
         }
 #else
 #if defined (NTTYDISC) && defined (TIOCSETD)
@@ -1799,10 +1799,8 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir)
 
           if (xforkin < 0)
             {
-              emacs_write (1, "Couldn't open the pty terminal ", 31);
-              emacs_write (1, pty_name, strlen (pty_name));
-              emacs_write (1, "\n", 1);
-              _exit (1);
+              emacs_perror (pty_name);
+              _exit (EXIT_CANCELED);
             }
 
         }
@@ -5503,7 +5501,7 @@ send_process (Lisp_Object proc, const char *buf, ptrdiff_t len,
                 written = emacs_gnutls_write (p, cur_buf, cur_len);
               else
 #endif
-                written = emacs_write (outfd, cur_buf, cur_len);
+                written = emacs_write_sig (outfd, cur_buf, cur_len);
               rv = (written ? 0 : -1);
 #ifdef ADAPTIVE_READ_BUFFERING
               if (p->read_output_delay > 0