diff options
| author | Paul Eggert | 2020-08-15 10:48:36 -0700 |
|---|---|---|
| committer | Paul Eggert | 2020-08-15 11:19:51 -0700 |
| commit | d0145537fa511a44e2a4af01da3947e92f0b8331 (patch) | |
| tree | 0b098e725155c3b40031e0ecb8c65bbb25a6e402 /src/nsselect.m | |
| parent | 4cba236749aafade7bd88cf2a10be48f44983faa (diff) | |
| download | emacs-d0145537fa511a44e2a4af01da3947e92f0b8331.tar.gz emacs-d0145537fa511a44e2a4af01da3947e92f0b8331.zip | |
Fix GC bugs related to uninitialized vectors
Avoid problems if GC occurs while initializing a vector.
Problem with Fdelete reported by Pip Cet in:
https://lists.gnu.org/r/emacs-devel/2020-08/msg00313.html
I looked for similar problems elsewhere and found quite a few.
* src/coding.c (make_subsidiaries):
* src/composite.c (syms_of_composite):
* src/font.c (build_style_table, Ffont_get_glyphs):
* src/nsselect.m (clean_local_selection_data):
* src/nsxwidget.m (js_to_lisp):
* src/syntax.c (init_syntax_once):
* src/window.c (Fcurrent_window_configuration):
* src/xselect.c (selection_data_to_lisp_data)
(clean_local_selection_data):
Use make_nil_vector instead of make_uninit_vector.
* src/fns.c (Fdelete):
* src/xwidget.c (webkit_js_to_lisp):
Use allocate_nil_vector instead of allocate_vector.
* src/search.c (Fnewline_cache_check):
Use make_vector instead of make_uninit_vector.
Diffstat (limited to 'src/nsselect.m')
| -rw-r--r-- | src/nsselect.m | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nsselect.m b/src/nsselect.m index 38ac66e9c7b..7b1937f5d99 100644 --- a/src/nsselect.m +++ b/src/nsselect.m | |||
| @@ -114,7 +114,7 @@ clean_local_selection_data (Lisp_Object obj) | |||
| 114 | 114 | ||
| 115 | if (size == 1) | 115 | if (size == 1) |
| 116 | return clean_local_selection_data (AREF (obj, 0)); | 116 | return clean_local_selection_data (AREF (obj, 0)); |
| 117 | copy = make_uninit_vector (size); | 117 | copy = make_nil_vector (size); |
| 118 | for (i = 0; i < size; i++) | 118 | for (i = 0; i < size; i++) |
| 119 | ASET (copy, i, clean_local_selection_data (AREF (obj, i))); | 119 | ASET (copy, i, clean_local_selection_data (AREF (obj, i))); |
| 120 | return copy; | 120 | return copy; |