Prefer static to extern where either will do

* src/charset.c (charset_table_size):
* src/pdumper.c (dump_private):
* src/sysdep.c (init_sigsegv):
* src/window.c (old_selected_window):
Now static.
* src/charset.c (charset_table_size):
Now int, since the value always fits in int.
* src/gtkutil.c (xg_gtk_initialized): Now present only if
HAVE_XWIDGETS, to make it clearer that this is an xwidgets
hack.  All uses changed.
* src/lread.c (ndefsubr): Remove; unused.
* src/pdumper.h: Use usual GNU indenting style for functions,
since my static-vs-extern checking hack relies on it.
(dump_public): Always declare; simpler and doesn’t hurt.
(pdumper_handle_page_fault): Remove unused decl.

1 files changed, 0 insertions, 3 deletions

diff --git a/src/lread.c b/src/lread.c
index dde9ccef549..ff9b75475b8 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -4402,8 +4402,6 @@ init_obarray_once (void)
 }
 
 
-int ndefsubr;
-
 void
 defsubr (union Aligned_Lisp_Subr *aname)
 {
@@ -4413,7 +4411,6 @@ defsubr (union Aligned_Lisp_Subr *aname)
   XSETPVECTYPE (sname, PVEC_SUBR);
   XSETSUBR (tem, sname);
   set_symbol_function (sym, tem);
-  ++ndefsubr;
 }
 
 #ifdef NOTDEF /* Use fset in subr.el now!  */