More xmalloc and related cleanup.

* alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
* callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
* doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
* font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
* gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
* nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
* regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
* sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
* xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
* xterm.c:
Omit needless casts involving void * pointers and allocation.
Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
as the former is more robust if P's type is changed.
Prefer xzalloc to xmalloc + memset 0.
Simplify malloc-or-realloc to realloc.
Don't worry about xmalloc returning a null pointer.
Prefer xstrdup to xmalloc + strcpy.
* editfns.c (Fmessage_box): Grow message_text by at least 80 when
growing it.
* keyboard.c (apply_modifiers_uncached): Prefer local array to
alloca of a constant.

1 files changed, 5 insertions, 9 deletions

diff --git a/src/lread.c b/src/lread.c
index 670831081e8..19783d3102b 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -1479,7 +1479,7 @@ openp (Lisp_Object path, Lisp_Object str, Lisp_Object suffixes, Lisp_Object *sto
          this path element/specified file name and any possible suffix.  */
       want_length = max_suffix_len + SBYTES (filename);
       if (fn_size <= want_length)
-        fn = (char *) alloca (fn_size = 100 + want_length);
+        fn = alloca (fn_size = 100 + want_length);
 
       /* Loop over suffixes.  */
       for (tail = NILP (suffixes) ? Fcons (empty_unibyte_string, Qnil) : suffixes;
@@ -2630,8 +2630,7 @@ read1 (register Lisp_Object readcharfun, int *pch, int first_in_list)
                 }
               if (nskip > saved_doc_string_size)
                 {
-                  saved_doc_string = (char *) xrealloc (saved_doc_string,
-                                                        nskip + extra);
+                  saved_doc_string = xrealloc (saved_doc_string, nskip + extra);
                   saved_doc_string_size = nskip + extra;
                 }
 
@@ -2894,8 +2893,7 @@ read1 (register Lisp_Object readcharfun, int *pch, int first_in_list)
                 ptrdiff_t offset = p - read_buffer;
                 if (min (PTRDIFF_MAX, SIZE_MAX) / 2 < read_buffer_size)
                   memory_full (SIZE_MAX);
-                read_buffer = (char *) xrealloc (read_buffer,
-                                                 read_buffer_size * 2);
+                read_buffer = xrealloc (read_buffer, read_buffer_size * 2);
                 read_buffer_size *= 2;
                 p = read_buffer + offset;
                 end = read_buffer + read_buffer_size;
@@ -3029,8 +3027,7 @@ read1 (register Lisp_Object readcharfun, int *pch, int first_in_list)
                   ptrdiff_t offset = p - read_buffer;
                   if (min (PTRDIFF_MAX, SIZE_MAX) / 2 < read_buffer_size)
                     memory_full (SIZE_MAX);
-                  read_buffer = (char *) xrealloc (read_buffer,
-                                                   read_buffer_size * 2);
+                  read_buffer = xrealloc (read_buffer, read_buffer_size * 2);
                   read_buffer_size *= 2;
                   p = read_buffer + offset;
                   end = read_buffer + read_buffer_size;
@@ -3060,8 +3057,7 @@ read1 (register Lisp_Object readcharfun, int *pch, int first_in_list)
               ptrdiff_t offset = p - read_buffer;
               if (min (PTRDIFF_MAX, SIZE_MAX) / 2 < read_buffer_size)
                 memory_full (SIZE_MAX);
-              read_buffer = (char *) xrealloc (read_buffer,
-                                               read_buffer_size * 2);
+              read_buffer = xrealloc (read_buffer, read_buffer_size * 2);
               read_buffer_size *= 2;
               p = read_buffer + offset;
               end = read_buffer + read_buffer_size;