Avoid crashes when casifying noncontiguous regions

This is a followon fix for Bug#37477.
* lisp/simple.el (region-extract-function):
Use setq here, since the var is now defined in C code.
* src/casefiddle.c (casify_pnc_region): New function.
(Fupcase_region, Fdowncase_region, Fcapitalize_region)
(Fupcase_initials_region): Use it.
(Fupcase_initials_region): Add region-noncontiguous-p flag
for consistency with the others.  All uses changed.
(syms_of_casefiddle): Define Qbounds, Vregion_extract_function.
* src/insdel.c (prepare_to_modify_buffer_1):
* src/keyboard.c (command_loop_1):
Use Vregion_extraction_function.
* src/insdel.c (syms_of_insdel): No need to define
Qregion_extract_function.
* test/src/casefiddle-tests.el (casefiddle-oldfunc): New var.
(casefiddle-loopfunc, casefiddle-badfunc): New functions.
(casefiddle-invalid-region-extract-function): New test.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/keyboard.c b/src/keyboard.c
index 1b9a603ca17..a16d13cc7b8 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -1535,7 +1535,7 @@ command_loop_1 (void)
                                   Vselection_inhibit_update_commands)))
                 {
                   Lisp_Object txt
-                    = call1 (Fsymbol_value (Qregion_extract_function), Qnil);
+                    = call1 (Vregion_extract_function, Qnil);
                   if (XFIXNUM (Flength (txt)) > 0)
                     /* Don't set empty selections.  */
                     call2 (Qgui_set_selection, QPRIMARY, txt);