Fix a few crashes and leaks when cloning C strings.

* alloc.c, lisp.h (dupstring): New function.
* gtkutil.c (xg_get_font):
* term.c (tty_default_color_capabilities):
* xsettings.c (store_monospaced_changed)
(store_font_name_changed, parse_settings)
(read_and_apply_settings, init_gsettings, init_gconf): Use it.
This avoids some unlikely crashes due to accessing freed storage,
and avoids some minor memory leaks in the more-typical case.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/gtkutil.c b/src/gtkutil.c
index 6e039c7a141..cebff68614f 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -2106,8 +2106,7 @@ xg_get_font (struct frame *f, const char *default_name)
           font = Ffont_spec (8, args);
 
           pango_font_description_free (desc);
-          xfree (x_last_font_name);
-          x_last_font_name = xstrdup (name);
+          dupstring (&x_last_font_name, name);
         }
 
 #else /* Use old font selector, which just returns the font name.  */