Simple wrapper for make_unibyte_string, adjust font_open_by_name.

* src/lisp.h (build_unibyte_string): New function.
* src/dosfns.c, src/fileio.c, src/fns.c, src/ftfont.c, src/process.c:
* src/sysdep.c, src/w32fns.c, src/xfns.c: Use it.
* src/font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
of type Lisp_Object to avoid redundant calls to make_unibyte_string.
Adjust users accordingly.
* src/font.h (font_open_by_name): Adjust prototype.
* admin/coccinelle/unibyte_string.cocci: Semantic patch to convert from
make_unibyte_string to build_unibyte_string where appropriate.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/frame.c b/src/frame.c
index 9668ea4d831..bf2b180f2d3 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -3167,16 +3167,14 @@ x_set_font (struct frame *f, Lisp_Object arg, Lisp_Object oldval)
       fontset = fs_query_fontset (arg, 0);
       if (fontset < 0)
         {
-          font_object = font_open_by_name (f, SSDATA (arg), SBYTES (arg));
+          font_object = font_open_by_name (f, arg);
           if (NILP (font_object))
             error ("Font `%s' is not defined", SSDATA (arg));
           arg = AREF (font_object, FONT_NAME_INDEX);
         }
       else if (fontset > 0)
         {
-          Lisp_Object ascii_font = fontset_ascii (fontset);
-
-          font_object = font_open_by_name (f, SSDATA (ascii_font), SBYTES (ascii_font));
+          font_object = font_open_by_name (f, fontset_ascii (fontset));
           if (NILP (font_object))
             error ("Font `%s' is not defined", SDATA (arg));
           arg = AREF (font_object, FONT_NAME_INDEX);