Merge: Fix more problems found by GCC 4.5.2's static checks.

1 files changed, 32 insertions, 29 deletions

diff --git a/src/eval.c b/src/eval.c
index d0effc755a2..f68274e6e8c 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -158,7 +158,7 @@ restore_stack_limits (Lisp_Object data)
 
 /* Call the Lisp debugger, giving it argument ARG.  */
 
-Lisp_Object
+static Lisp_Object
 call_debugger (Lisp_Object arg)
 {
   int debug_while_redisplaying;
@@ -214,7 +214,7 @@ call_debugger (Lisp_Object arg)
   return unbind_to (count, val);
 }
 
-void
+static void
 do_debug_on_call (Lisp_Object code)
 {
   debug_on_next_call = 0;
@@ -764,11 +764,11 @@ usage: (defvar SYMBOL &optional INITVALUE DOCSTRING)  */)
       if (SYMBOL_CONSTANT_P (sym))
         {
           /* For upward compatibility, allow (defvar :foo (quote :foo)).  */
-          Lisp_Object tem = Fcar (tail);
-          if (! (CONSP (tem)
-                 && EQ (XCAR (tem), Qquote)
-                 && CONSP (XCDR (tem))
-                 && EQ (XCAR (XCDR (tem)), sym)))
+          Lisp_Object tem1 = Fcar (tail);
+          if (! (CONSP (tem1)
+                 && EQ (XCAR (tem1), Qquote)
+                 && CONSP (XCDR (tem1))
+                 && EQ (XCAR (XCDR (tem1)), sym)))
             error ("Constant symbol `%s' specified in defvar",
                    SDATA (SYMBOL_NAME (sym)));
         }
@@ -801,10 +801,11 @@ usage: (defvar SYMBOL &optional INITVALUE DOCSTRING)  */)
       LOADHIST_ATTACH (sym);
     }
   else
-    /* Simple (defvar <var>) should not count as a definition at all.
-       It could get in the way of other definitions, and unloading this
-       package could try to make the variable unbound.  */
-    ;
+    {
+      /* Simple (defvar <var>) should not count as a definition at all.
+         It could get in the way of other definitions, and unloading this
+         package could try to make the variable unbound.  */
+    }
 
   return sym;
 }
@@ -855,7 +856,8 @@ user_variable_p_eh (Lisp_Object ignore)
 static Lisp_Object
 lisp_indirect_variable (Lisp_Object sym)
 {
-  XSETSYMBOL (sym, indirect_variable (XSYMBOL (sym)));
+  struct Lisp_Symbol *s = indirect_variable (XSYMBOL (sym));
+  XSETSYMBOL (sym, s);
   return sym;
 }
 
@@ -1637,7 +1639,7 @@ See also the function `condition-case'.  */)
       if (!NILP (clause))
         break;
     }
-          
+
   if (/* Don't run the debugger for a memory-full error.
          (There is no room in memory to do that!) */
       !NILP (error_symbol)
@@ -1654,13 +1656,13 @@ See also the function `condition-case'.  */)
          can continue code which has signaled a quit.  */
       if (debugger_called && EQ (real_error_symbol, Qquit))
         return Qnil;
-    }      
+    }
 
   if (!NILP (clause))
     {
       Lisp_Object unwind_data
         = (NILP (error_symbol) ? data : Fcons (error_symbol, data));
-      
+
       h->chosen_clause = clause;
       unwind_to_catch (h->tag, unwind_data);
     }
@@ -1672,7 +1674,7 @@ See also the function `condition-case'.  */)
 
   if (! NILP (error_symbol))
     data = Fcons (error_symbol, data);
-      
+
   string = Ferror_message_string (data);
   fatal ("%s", SDATA (string), 0);
 }
@@ -2537,8 +2539,8 @@ run_hook_with_args (int nargs, Lisp_Object *args, enum run_hooks_condition cond)
     }
   else
     {
-      Lisp_Object globals = Qnil;
-      GCPRO3 (sym, val, globals);
+      Lisp_Object global_vals = Qnil;
+      GCPRO3 (sym, val, global_vals);
 
       for (;
            CONSP (val) && ((cond == to_completion)
@@ -2550,23 +2552,25 @@ run_hook_with_args (int nargs, Lisp_Object *args, enum run_hooks_condition cond)
             {
               /* t indicates this hook has a local binding;
                  it means to run the global binding too.  */
-              globals = Fdefault_value (sym);
-              if (NILP (globals)) continue;
+              global_vals = Fdefault_value (sym);
+              if (NILP (global_vals)) continue;
 
-              if (!CONSP (globals) || EQ (XCAR (globals), Qlambda))
+              if (!CONSP (global_vals) || EQ (XCAR (global_vals), Qlambda))
                 {
-                  args[0] = globals;
+                  args[0] = global_vals;
                   ret = Ffuncall (nargs, args);
                 }
               else
                 {
                   for (;
-                       CONSP (globals) && ((cond == to_completion)
-                                           || (cond == until_success ? NILP (ret)
-                                               : !NILP (ret)));
-                       globals = XCDR (globals))
+                       (CONSP (global_vals)
+                        && (cond == to_completion
+                            || (cond == until_success
+                                ? NILP (ret)
+                                : !NILP (ret))));
+                       global_vals = XCDR (global_vals))
                     {
-                      args[0] = XCAR (globals);
+                      args[0] = XCAR (global_vals);
                       /* In a global value, t should not occur.  If it does, we
                          must ignore it to avoid an endless loop.  */
                       if (!EQ (args[0], Qt))
@@ -3057,7 +3061,7 @@ DEFUN ("fetch-bytecode", Ffetch_bytecode, Sfetch_bytecode,
   return object;
 }
 
-void
+static void
 grow_specpdl (void)
 {
   register int count = SPECPDL_INDEX ();
@@ -3589,4 +3593,3 @@ The value the function returns is not used.  */);
   defsubr (&Sbacktrace);
   defsubr (&Sbacktrace_frame);
 }
-