aboutsummaryrefslogtreecommitdiffstats
path: root/src/eval.c
diff options
context:
space:
mode:
authorPaul Eggert2024-08-16 16:29:51 -0700
committerPaul Eggert2024-08-16 21:16:35 -0700
commit2169a9387a5ac22b969d37ece4ec1aaa0fd830d9 (patch)
tree52eb6078bf4cbc03bb9142a77216b989deddd474 /src/eval.c
parent909d1d02db1c11e1309316cba2a392e1456e6053 (diff)
downloademacs-2169a9387a5ac22b969d37ece4ec1aaa0fd830d9.tar.gz
emacs-2169a9387a5ac22b969d37ece4ec1aaa0fd830d9.zip
Don’t ignore -Wclobbered in bytecode.c
This fix is prompted by Emacs bug#71744. The working hypothesis is that there are some bugs in Emacs, and some in GCC’s diagnostics, and that this patch fixes the Emacs bugs and works around the GCC diagnostic bugs. The hypothesis is that GCC diagnostic bugs occur when GCC coalesces variables or temporaries and some variables are clobbered by setjmp and some vars/temps are not. Part of this hypothesis involves GCC diagnosing the wrong variables. Instead of ignoring the diagnostics, which the hypothesis suggests indicate either problems in Emacs or in GCC, fix the Emacs bugs and pacify the GCC false positives, with comments about the GCC bugs. GCC’s true positives are helpful enough in squashing obscure bugs like Emacs bug#71744, that it’s worth going to some effort to pacify -Wclobbered instead of ignoring it. * src/bytecode.c: Do not ignore -Wclobbered. (exec_byte_code): Fix violations of the C standard, where setjmp clobbered quitcounter and bc. If GCC_LINT && __GNUC__ && !__clang__, work around GCC -Wclobbered warnings for bytestr_data and vectorp.
Diffstat (limited to 'src/eval.c')
0 files changed, 0 insertions, 0 deletions