Adjust match data before calling after-change-funs

It's important to adjust the match data in between calling
before-change-functions and after-change-functions, so that buffer
change hooks will always see match-data consistent with buffer content.
(Bug #23917)

* src/insdel.c (replace_range): Add new parameter ADJUST_MATCH_DATA, if
true call update_search_regs.  Update all callers (except
Freplace_match) to pass 0 for the new parameter.
* src/search.c (update_search_regs): New function, extracted from
Freplace_match.
(Freplace_match): Remove match data adjustment code, pass 1 for
ADJUST_MATCH_DATA to replace_range instead.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/editfns.c b/src/editfns.c
index 412745d551d..32c8bec6db2 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -3192,7 +3192,7 @@ Both characters must have the same length of multi-byte form.  */)
               /* replace_range is less efficient, because it moves the gap,
                  but it handles combining correctly.  */
               replace_range (pos, pos + 1, string,
-                             0, 0, 1);
+                             0, 0, 1, 0);
               pos_byte_next = CHAR_TO_BYTE (pos);
               if (pos_byte_next > pos_byte)
                 /* Before combining happened.  We should not increment
@@ -3405,7 +3405,7 @@ It returns the number of characters changed.  */)
                   /* This is less efficient, because it moves the gap,
                      but it should handle multibyte characters correctly.  */
                   string = make_multibyte_string ((char *) str, 1, str_len);
-                  replace_range (pos, pos + 1, string, 1, 0, 1);
+                  replace_range (pos, pos + 1, string, 1, 0, 1, 0);
                   len = str_len;
                 }
               else
@@ -3446,7 +3446,7 @@ It returns the number of characters changed.  */)
                 {
                   string = Fmake_string (make_number (1), val);
                 }
-              replace_range (pos, pos + len, string, 1, 0, 1);
+              replace_range (pos, pos + len, string, 1, 0, 1, 0);
               pos_byte += SBYTES (string);
               pos += SCHARS (string);
               cnt += SCHARS (string);