Fix problems with logxor etc. and fixnums

These operations incorrectly treated negative fixnums as
bignums greater than most-positive-fixnum.
* src/alloc.c (mpz_set_intmax_slow): Avoid undefined
behavior if signed unary negation overflows, while
we’re in the neighborhood.
(mpz_set_uintmax_slow): Remove.  All uses removed.
* src/data.c (arith_driver): Treat fixnums as signed, not
unsigned, even for logical operations.
* src/lisp.h (mpz_set_uintmax): Remove.  All uses removed.
* test/src/data-tests.el (data-tests-logand)
(data-tests-logior, data-tests-logxor): New tests.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/data.c b/src/data.c
index 66f508c8f43..5a355d9787c 100644
--- a/src/data.c
+++ b/src/data.c
@@ -3006,7 +3006,7 @@ arith_driver (enum arithop code, ptrdiff_t nargs, Lisp_Object *args)
             {
               mpz_t tem;
               mpz_init (tem);
-              mpz_set_uintmax (tem, XUFIXNUM (val));
+              mpz_set_intmax (tem, XFIXNUM (val));
               mpz_and (accum, accum, tem);
               mpz_clear (tem);
             }
@@ -3018,7 +3018,7 @@ arith_driver (enum arithop code, ptrdiff_t nargs, Lisp_Object *args)
             {
               mpz_t tem;
               mpz_init (tem);
-              mpz_set_uintmax (tem, XUFIXNUM (val));
+              mpz_set_intmax (tem, XFIXNUM (val));
               mpz_ior (accum, accum, tem);
               mpz_clear (tem);
             }
@@ -3030,7 +3030,7 @@ arith_driver (enum arithop code, ptrdiff_t nargs, Lisp_Object *args)
             {
               mpz_t tem;
               mpz_init (tem);
-              mpz_set_uintmax (tem, XUFIXNUM (val));
+              mpz_set_intmax (tem, XFIXNUM (val));
               mpz_xor (accum, accum, tem);
               mpz_clear (tem);
             }