diff options
| author | Paul Eggert | 2011-06-08 10:54:58 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-06-08 10:54:58 -0700 |
| commit | b643996157ced5daf45752d37ac5bee3a4f4389f (patch) | |
| tree | 80bc6f192110e7fdfcb8ceec286d60728dd6de58 /src/alloc.c | |
| parent | 86f61a158aea8dead5a0836a919a0ce501d3bcf7 (diff) | |
| download | emacs-b643996157ced5daf45752d37ac5bee3a4f4389f.tar.gz emacs-b643996157ced5daf45752d37ac5bee3a4f4389f.zip | |
* alloc.c (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
when a (possibly-narrower) signed value would do just as well.
We prefer using signed arithmetic, to avoid comparison confusion.
Diffstat (limited to 'src/alloc.c')
| -rw-r--r-- | src/alloc.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/alloc.c b/src/alloc.c index 2dbaef9b00b..1307ad60234 100644 --- a/src/alloc.c +++ b/src/alloc.c | |||
| @@ -5265,8 +5265,8 @@ static size_t mark_object_loop_halt; | |||
| 5265 | static void | 5265 | static void |
| 5266 | mark_vectorlike (struct Lisp_Vector *ptr) | 5266 | mark_vectorlike (struct Lisp_Vector *ptr) |
| 5267 | { | 5267 | { |
| 5268 | register EMACS_UINT size = ptr->header.size; | 5268 | EMACS_INT size = ptr->header.size; |
| 5269 | register EMACS_UINT i; | 5269 | EMACS_INT i; |
| 5270 | 5270 | ||
| 5271 | eassert (!VECTOR_MARKED_P (ptr)); | 5271 | eassert (!VECTOR_MARKED_P (ptr)); |
| 5272 | VECTOR_MARK (ptr); /* Else mark it */ | 5272 | VECTOR_MARK (ptr); /* Else mark it */ |
| @@ -5288,8 +5288,8 @@ mark_vectorlike (struct Lisp_Vector *ptr) | |||
| 5288 | static void | 5288 | static void |
| 5289 | mark_char_table (struct Lisp_Vector *ptr) | 5289 | mark_char_table (struct Lisp_Vector *ptr) |
| 5290 | { | 5290 | { |
| 5291 | register EMACS_UINT size = ptr->header.size & PSEUDOVECTOR_SIZE_MASK; | 5291 | int size = ptr->header.size & PSEUDOVECTOR_SIZE_MASK; |
| 5292 | register EMACS_UINT i; | 5292 | int i; |
| 5293 | 5293 | ||
| 5294 | eassert (!VECTOR_MARKED_P (ptr)); | 5294 | eassert (!VECTOR_MARKED_P (ptr)); |
| 5295 | VECTOR_MARK (ptr); | 5295 | VECTOR_MARK (ptr); |
| @@ -5417,12 +5417,11 @@ mark_object (Lisp_Object arg) | |||
| 5417 | recursion there. */ | 5417 | recursion there. */ |
| 5418 | { | 5418 | { |
| 5419 | register struct Lisp_Vector *ptr = XVECTOR (obj); | 5419 | register struct Lisp_Vector *ptr = XVECTOR (obj); |
| 5420 | register EMACS_UINT size = ptr->header.size; | 5420 | int size = ptr->header.size & PSEUDOVECTOR_SIZE_MASK; |
| 5421 | register EMACS_UINT i; | 5421 | int i; |
| 5422 | 5422 | ||
| 5423 | CHECK_LIVE (live_vector_p); | 5423 | CHECK_LIVE (live_vector_p); |
| 5424 | VECTOR_MARK (ptr); /* Else mark it */ | 5424 | VECTOR_MARK (ptr); /* Else mark it */ |
| 5425 | size &= PSEUDOVECTOR_SIZE_MASK; | ||
| 5426 | for (i = 0; i < size; i++) /* and then mark its elements */ | 5425 | for (i = 0; i < size; i++) /* and then mark its elements */ |
| 5427 | { | 5426 | { |
| 5428 | if (i != COMPILED_CONSTANTS) | 5427 | if (i != COMPILED_CONSTANTS) |