diff options
| author | Paul Eggert | 2013-09-21 23:22:05 -0700 |
|---|---|---|
| committer | Paul Eggert | 2013-09-21 23:22:05 -0700 |
| commit | c6cfd9101e70010bcd4ba6831b0d42ebc84728fe (patch) | |
| tree | f0ef00d745ba5260d9b369ec1946bdd43e47de53 /src/ChangeLog | |
| parent | 3a4be55b4d956799201169bb4ba49c0e948eec32 (diff) | |
| download | emacs-c6cfd9101e70010bcd4ba6831b0d42ebc84728fe.tar.gz emacs-c6cfd9101e70010bcd4ba6831b0d42ebc84728fe.zip | |
Fix syntax.h bug introduced by recent INLINE change.
syntax.h defined an extern inline function SYNTAX_ENTRY that was
conditionally compiled one way in some modules, and a different
way in others. This doesn't work with extern inline functions,
which must have the same definition in all modules, because the
defining code might be shared across modules, depending on the
implementation. Symptoms reported by Martin Rudalics in:
http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html
* regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove.
(SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros,
overriding the corresponding functions in syntax.h.
* syntax.h (syntax_property_entry, syntax_property_with_flags)
(syntax_property): New inline functions.
(SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX):
Rewrite in terms of these new functions.
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 37e04f03c85..084ae983b6f 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,21 @@ | |||
| 1 | 2013-09-22 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | Fix syntax.h bug introduced by recent INLINE change. | ||
| 4 | syntax.h defined an extern inline function SYNTAX_ENTRY that was | ||
| 5 | conditionally compiled one way in some modules, and a different | ||
| 6 | way in others. This doesn't work with extern inline functions, | ||
| 7 | which must have the same definition in all modules, because the | ||
| 8 | defining code might be shared across modules, depending on the | ||
| 9 | implementation. Symptoms reported by Martin Rudalics in: | ||
| 10 | http://lists.gnu.org/archive/html/emacs-devel/2013-09/msg00414.html | ||
| 11 | * regex.c, syntax.c (SYNTAX_ENTRY_VIA_PROPERTY): Remove. | ||
| 12 | (SYNTAX, SYNTAX_ENTRY, SYNTAX_WITH_FLAGS): New macros, | ||
| 13 | overriding the corresponding functions in syntax.h. | ||
| 14 | * syntax.h (syntax_property_entry, syntax_property_with_flags) | ||
| 15 | (syntax_property): New inline functions. | ||
| 16 | (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX): | ||
| 17 | Rewrite in terms of these new functions. | ||
| 18 | |||
| 1 | 2013-09-21 Eli Zaretskii <eliz@gnu.org> | 19 | 2013-09-21 Eli Zaretskii <eliz@gnu.org> |
| 2 | 20 | ||
| 3 | * dired.c (directory_files_internal): Use multibyte_chars_in_text, | 21 | * dired.c (directory_files_internal): Use multibyte_chars_in_text, |