diff options
| author | Paul Eggert | 2011-07-16 20:00:19 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-07-16 20:00:19 -0700 |
| commit | b13995dbbdab5254bc77ad5ed7318db9797be321 (patch) | |
| tree | a2c8aefa66dfa3d78ce0c87b09769ac54827e916 /src/ChangeLog | |
| parent | 8d576a545d08182fae5c7d705a53da2a84e0d85a (diff) | |
| download | emacs-b13995dbbdab5254bc77ad5ed7318db9797be321.tar.gz emacs-b13995dbbdab5254bc77ad5ed7318db9797be321.zip | |
* keyboard.c: Overflow, signedness and related fixes.
(make_lispy_movement): Use same integer type in forward decl
that is used in the definition.
(read_key_sequence, keyremap_step):
Change bufsize argument back to int, undoing my 2011-03-30 change.
We prefer signed types, and int is wide enough here.
(parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
length, not size_t. Use ptrdiff_t for index, not int.
(keyremap_step, read_key_sequence): Redo bufsize check to avoid
possibility of integer overflow.
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 1dcf39498f3..32a117ed767 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,18 @@ | |||
| 1 | 2011-07-17 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-07-17 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * keyboard.c: Overflow, signedness and related fixes. | ||
| 4 | (make_lispy_movement): Use same integer type in forward decl | ||
| 5 | that is used in the definition. | ||
| 6 | (read_key_sequence, keyremap_step): | ||
| 7 | Change bufsize argument back to int, undoing my 2011-03-30 change. | ||
| 8 | We prefer signed types, and int is wide enough here. | ||
| 9 | (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less | ||
| 10 | than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow | ||
| 11 | larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string | ||
| 12 | length, not size_t. Use ptrdiff_t for index, not int. | ||
| 13 | (keyremap_step, read_key_sequence): Redo bufsize check to avoid | ||
| 14 | possibility of integer overflow. | ||
| 15 | |||
| 3 | Overflow, signedness and related fixes for images. | 16 | Overflow, signedness and related fixes for images. |
| 4 | 17 | ||
| 5 | * dispextern.h (struct it.stack[0].u.image.image_id) | 18 | * dispextern.h (struct it.stack[0].u.image.image_id) |