diff options
| author | Paul Eggert | 2011-04-29 00:54:43 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-04-29 00:54:43 -0700 |
| commit | 8ac068ac0c00afa85bc4df54032b7a855c639312 (patch) | |
| tree | 551b5146f8f0c9e5c2f7129eaac0fb9f97d8a866 /src/ChangeLog | |
| parent | c7b270ab8559d9c9ca86ed5887b86b537796042d (diff) | |
| download | emacs-8ac068ac0c00afa85bc4df54032b7a855c639312.tar.gz emacs-8ac068ac0c00afa85bc4df54032b7a855c639312.zip | |
Prefer intptr_t/uintptr_t for integers the same widths as pointers.
This removes an assumption that EMACS_INT and long are the same
width as pointers. The assumption is true for Emacs porting targets
now, but we want to make other targets possible.
* lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
(EMACS_INTPTR, EMACS_UINTPTR): New macros.
In the rest of the code, change types of integers that hold casted
pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
(XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
(XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
No need to cast type when ORing.
(XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
* alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
* doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
assume EMACS_INT is the same width as char *.
* gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
(xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
Remove no-longer-needed casts.
(xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
(xg_tool_bar_help_callback, xg_make_tool_item):
Use EMACS_INTPTR to hold an integer
that will be cast to void *; this can avoid a GCC warning
if EMACS_INT is not the same width as void *.
* menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
* xdisp.c (display_echo_area_1, resize_mini_window_1):
(current_message_1, set_message_1):
Use a local to convert to proper width without a cast.
* xmenu.c (dialog_selection_callback): Likewise.
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 45d7e7a9044..05f332b8142 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,35 @@ | |||
| 1 | 2011-04-29 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | Prefer intptr_t/uintptr_t for integers the same widths as pointers. | ||
| 4 | This removes an assumption that EMACS_INT and long are the same | ||
| 5 | width as pointers. The assumption is true for Emacs porting targets | ||
| 6 | now, but we want to make other targets possible. | ||
| 7 | * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX. | ||
| 8 | (EMACS_INTPTR, EMACS_UINTPTR): New macros. | ||
| 9 | In the rest of the code, change types of integers that hold casted | ||
| 10 | pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically | ||
| 11 | replacing EMACS_INT, long, EMACS_UINT, and unsigned long. | ||
| 12 | (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed. | ||
| 13 | (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here. | ||
| 14 | No need to cast type when ORing. | ||
| 15 | (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR. | ||
| 16 | * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast. | ||
| 17 | * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to | ||
| 18 | assume EMACS_INT is the same width as char *. | ||
| 19 | * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb): | ||
| 20 | (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item): | ||
| 21 | Remove no-longer-needed casts. | ||
| 22 | (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback): | ||
| 23 | (xg_tool_bar_help_callback, xg_make_tool_item): | ||
| 24 | Use EMACS_INTPTR to hold an integer | ||
| 25 | that will be cast to void *; this can avoid a GCC warning | ||
| 26 | if EMACS_INT is not the same width as void *. | ||
| 27 | * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast. | ||
| 28 | * xdisp.c (display_echo_area_1, resize_mini_window_1): | ||
| 29 | (current_message_1, set_message_1): | ||
| 30 | Use a local to convert to proper width without a cast. | ||
| 31 | * xmenu.c (dialog_selection_callback): Likewise. | ||
| 32 | |||
| 1 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> | 33 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 34 | ||
| 3 | * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long. | 35 | * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long. |