Fix array bounds violation when pty allocation fails.

* configure.ac (PTY_TTY_NAME_SPRINTF): Use PTY_NAME_SIZE,
not sizeof pty_name, since pty_name is now a pointer to the array.
* src/process.c (PTY_NAME_SIZE): New constant.
(pty_name): Remove static variable; it's now auto.
(allocate_pty): Define even if !HAVE_PTYS; that's simpler.
Take pty_name as an arg rather than using a static variable.
All callers changed.
(create_process): Recover pty_flag from process, not from volatile local.
(create_pty): Stay inside array even when pty allocation fails.
(Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.

1 files changed, 10 insertions, 0 deletions

diff --git a/src/ChangeLog b/src/ChangeLog
index c88951f9422..4c6bfaa2b1a 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,15 @@
 2013-07-20  Paul Eggert  <eggert@cs.ucla.edu>
 
+        Fix array bounds violation when pty allocation fails.
+        * process.c (PTY_NAME_SIZE): New constant.
+        (pty_name): Remove static variable; it's now auto.
+        (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
+        Take pty_name as an arg rather than using a static variable.
+        All callers changed.
+        (create_process): Recover pty_flag from process, not from volatile local.
+        (create_pty): Stay inside array even when pty allocation fails.
+        (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
+
         * lread.c (Fload): Avoid initialization only when lint checking.
         Mention that it's needed only for older GCCs.