diff options
| author | Jim Meyering | 2011-05-28 14:19:08 +0200 |
|---|---|---|
| committer | Jim Meyering | 2011-05-28 14:19:08 +0200 |
| commit | 3eaff8342b4e193d142684f4ab03f391e3466c86 (patch) | |
| tree | d0e227b9c5e0985cd7959e9ac35d571f3abbb41c /src/ChangeLog | |
| parent | d451b0879113e2dca94a5ffaf1e4bb9b31a260b6 (diff) | |
| download | emacs-3eaff8342b4e193d142684f4ab03f391e3466c86.tar.gz emacs-3eaff8342b4e193d142684f4ab03f391e3466c86.zip | |
avoid a sign-extension bug in crypto_hash_function
* fns.c (to_uchar): Define.
(crypto_hash_function): Use it to convert some newly-signed
variables to unsigned, to avoid sign-extension bugs. For example,
without this change, (md5 "truc") would evaluate to
45723a2aff78ff4fff7fff1114760e62 rather than the expected
45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
http://thread.gmane.org/gmane.emacs.devel/139824
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 55ee4815149..cb2472233c1 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,14 @@ | |||
| 1 | 2011-05-28 Jim Meyering <meyering@redhat.com> | ||
| 2 | |||
| 3 | avoid a sign-extension bug in crypto_hash_function | ||
| 4 | * fns.c (to_uchar): Define. | ||
| 5 | (crypto_hash_function): Use it to convert some newly-signed | ||
| 6 | variables to unsigned, to avoid sign-extension bugs. For example, | ||
| 7 | without this change, (md5 "truc") would evaluate to | ||
| 8 | 45723a2aff78ff4fff7fff1114760e62 rather than the expected | ||
| 9 | 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in | ||
| 10 | http://thread.gmane.org/gmane.emacs.devel/139824 | ||
| 11 | |||
| 1 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> | 12 | 2011-05-27 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 13 | ||
| 3 | Integer overflow fixes. | 14 | Integer overflow fixes. |