diff options
| author | Paul Eggert | 2011-04-27 22:15:35 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-04-27 22:15:35 -0700 |
| commit | 2f30ecd05f7e5b9f78f256f75677530c501e5a6d (patch) | |
| tree | a7466caa2d9a8a4b6ffb76e785edac70950caa5e /src/ChangeLog | |
| parent | 2a866e7b9881176980c0a4acb998e1625aabf87f (diff) | |
| download | emacs-2f30ecd05f7e5b9f78f256f75677530c501e5a6d.tar.gz emacs-2f30ecd05f7e5b9f78f256f75677530c501e5a6d.zip | |
* lread.c (hash_string): Use size_t, not int, for hash computation.
Normally we prefer signed values; but hashing is special, because
it's better to use unsigned division on hash table sizes so that
the remainder is nonnegative. Also, size_t is the natural width
for hashing into memory. The previous code used 'int', which doesn't
retain enough info to hash well into very large tables.
(oblookup, oblookup_last_bucket_number, Funintern): Likewise.
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 52b7f323cd3..2bda5ffa46f 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,13 @@ | |||
| 1 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-04-28 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * lread.c (hash_string): Use size_t, not int, for hash computation. | ||
| 4 | Normally we prefer signed values; but hashing is special, because | ||
| 5 | it's better to use unsigned division on hash table sizes so that | ||
| 6 | the remainder is nonnegative. Also, size_t is the natural width | ||
| 7 | for hashing into memory. The previous code used 'int', which doesn't | ||
| 8 | retain enough info to hash well into very large tables. | ||
| 9 | (oblookup, oblookup_last_bucket_number, Funintern): Likewise. | ||
| 10 | |||
| 3 | * dbusbind.c: Don't possibly lose pointer info when converting. | 11 | * dbusbind.c: Don't possibly lose pointer info when converting. |
| 4 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): | 12 | (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): |
| 5 | Use XPNTR rather than XHASH, so that the high-order bits of | 13 | Use XPNTR rather than XHASH, so that the high-order bits of |