diff options
| author | Paul Eggert | 2011-05-12 13:23:33 -0700 |
|---|---|---|
| committer | Paul Eggert | 2011-05-12 13:23:33 -0700 |
| commit | 08dc5ae68e9c699410256ca9052bd09f336ac87f (patch) | |
| tree | 6572186aea70cb9f3f736743271c4d0b500650b6 /src/ChangeLog | |
| parent | 86db42d22397effbb6e9edc5ae11d806847f0d3e (diff) | |
| download | emacs-08dc5ae68e9c699410256ca9052bd09f336ac87f.tar.gz emacs-08dc5ae68e9c699410256ca9052bd09f336ac87f.zip | |
Be more systematic about user-interface timestamps.
Before, the code sometimes used 'Time', sometimes 'unsigned long',
and sometimes 'EMACS_UINT', to represent these timestamps. This
change causes it to use 'Time' uniformly, as that's what X uses.
This makes the code easier to follow, and makes it easier to catch
integer overflow bugs such as Bug#8664.
* frame.c (Fmouse_position, Fmouse_pixel_position):
Use Time, not unsigned long, for user-interface timestamps.
* keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
(button_down_time, make_lispy_position, make_lispy_movement): Likewise.
* keyboard.h (last_event_timestamp): Likewise.
* menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
* menu.h (xmenu_show): Likewise.
* term.c (term_mouse_position): Likewise.
* termhooks.h (struct input_event.timestamp): Likewise.
(struct terminal.mouse_position_hook): Likewise.
* xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
* xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
* systime.h (Time): New decl. Pull it in from <X11/X.h> if
HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
what it was before.
* menu.h, termhooks.h: Include "systime.h", for Time.
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index b2b19b6c940..a772106c521 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,28 @@ | |||
| 1 | 2011-05-12 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-05-12 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | Be more systematic about user-interface timestamps. | ||
| 4 | Before, the code sometimes used 'Time', sometimes 'unsigned long', | ||
| 5 | and sometimes 'EMACS_UINT', to represent these timestamps. This | ||
| 6 | change causes it to use 'Time' uniformly, as that's what X uses. | ||
| 7 | This makes the code easier to follow, and makes it easier to catch | ||
| 8 | integer overflow bugs such as Bug#8664. | ||
| 9 | * frame.c (Fmouse_position, Fmouse_pixel_position): | ||
| 10 | Use Time, not unsigned long, for user-interface timestamps. | ||
| 11 | * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise. | ||
| 12 | (button_down_time, make_lispy_position, make_lispy_movement): Likewise. | ||
| 13 | * keyboard.h (last_event_timestamp): Likewise. | ||
| 14 | * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise. | ||
| 15 | * menu.h (xmenu_show): Likewise. | ||
| 16 | * term.c (term_mouse_position): Likewise. | ||
| 17 | * termhooks.h (struct input_event.timestamp): Likewise. | ||
| 18 | (struct terminal.mouse_position_hook): Likewise. | ||
| 19 | * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise. | ||
| 20 | * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise. | ||
| 21 | * systime.h (Time): New decl. Pull it in from <X11/X.h> if | ||
| 22 | HAVE_X_WINDOWS, otherwise define it as unsigned long, which is | ||
| 23 | what it was before. | ||
| 24 | * menu.h, termhooks.h: Include "systime.h", for Time. | ||
| 25 | |||
| 3 | * keyboard.c (make_lispy_event): Fix problem in integer overflow. | 26 | * keyboard.c (make_lispy_event): Fix problem in integer overflow. |
| 4 | Don't assume that the difference between two unsigned long values | 27 | Don't assume that the difference between two unsigned long values |
| 5 | can fit into an integer. At this point, we know button_down_time | 28 | can fit into an integer. At this point, we know button_down_time |