Merge branch 'trunk' into xwidget

Conflicts:
	src/window.c

4 files changed, 26 insertions, 10 deletions

diff --git a/lwlib/ChangeLog b/lwlib/ChangeLog
index 54f7c6088cf..a9e424ac4b3 100644
--- a/lwlib/ChangeLog
+++ b/lwlib/ChangeLog
@@ -1,3 +1,11 @@
+2013-06-30  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Fix minor problems found by static checking.
+        * lwlib-Xaw.h (xaw_update_one_value, xaw_popup_menu):
+        * lwlib-Xlw.h (xlw_update_one_value, xlw_pop_instance):
+        * lwlib.h (lw_allow_resizing, lw_set_main_areas) [!USE_MOTIF]:
+        Now const.
+
 2012-10-06  Ulrich Müller  <ulm@gentoo.org>
 
         * Makefile.in (AR, ARFLAGS): Get values from configure.
@@ -248,7 +256,7 @@
         (xaw_update_one_widget): Reformat and remove dead code.
         (xaw_scrollbar_scroll, xaw_scrollbar_jump, xaw_create_scrollbar)
         (xaw_update_scrollbar): Remove (not used).
-        (make_dialog): Change from K&R to prototype. Remove dead code.
+        (make_dialog): Change from K&R to prototype.  Remove dead code.
         (xaw_creation_table): Remove scrollbar entry.
 
 2010-07-08  Dan Nicolaescu  <dann@ics.uci.edu>
@@ -357,7 +365,7 @@
         (display_menu_item): Replace ws->window with ws->pixmap, remove
         call to XftDrawRect.
         (display_menu): Remove this and that argument.
-        Remove just_compute_this_one_p. Fill pixmap at start and copy it to
+        Remove just_compute_this_one_p.  Fill pixmap at start and copy it to
         window at end.
         (expose_cb): New function.
         (make_windows_if_needed): Replace XCreateWindow with XtCreatePopup.
@@ -422,7 +430,7 @@
         (make_windows_if_needed): Set max_rest_width and xft_draw
         in windows[i].
         (openXftFont): New.
-        (XlwMenuInitialize): Call openXftFont if HAVE_XFT. If mw->menu.font
+        (XlwMenuInitialize): Call openXftFont if HAVE_XFT.  If mw->menu.font
         is not set, load font fixed and save it in xlwmenu_default_font.
         (XlwMenuInitialize): Set max_rest_width and xft_draw in windows[0].
         (XlwMenuClassInitialize): Initialize xlwmenu_default_font.
@@ -430,7 +438,7 @@
         windows[0].xft_draw if xft_font is set.
         (XlwMenuDestroy): Destroy all xft_draw and close xft_font.
         (facename_changed): New.
-        (XlwMenuSetValues): Call facename_changed. If face name did change,
+        (XlwMenuSetValues): Call facename_changed.  If face name did change,
         close old fonts and destroy xft_draw:s.  Then create new ones.
 
         * xlwmenu.h (XtNfaceName, XtCFaceName, XtNdefaultFace,
diff --git a/lwlib/lwlib-Xaw.h b/lwlib/lwlib-Xaw.h
index cf231270121..363334b575e 100644
--- a/lwlib/lwlib-Xaw.h
+++ b/lwlib/lwlib-Xaw.h
@@ -15,16 +15,17 @@ void
 xaw_update_one_widget (widget_instance *, Widget, widget_value *, Boolean);
 
 void
-xaw_update_one_value (widget_instance *, Widget, widget_value *);
+xaw_update_one_value (widget_instance *, Widget, widget_value *)
+  ATTRIBUTE_CONST;
 
 void
 xaw_destroy_instance (widget_instance *);
 
 void
-xaw_popup_menu (Widget, XEvent *);
+xaw_popup_menu (Widget, XEvent *)
+  ATTRIBUTE_CONST;
 
 void
 xaw_pop_instance (widget_instance *, Boolean);
 
 #endif /* LWLIB_XAW_H */
-
diff --git a/lwlib/lwlib-Xlw.h b/lwlib/lwlib-Xlw.h
index 3b2c301c3d3..2d38eb7be66 100644
--- a/lwlib/lwlib-Xlw.h
+++ b/lwlib/lwlib-Xlw.h
@@ -15,16 +15,17 @@ xlw_update_one_widget (widget_instance* instance, Widget widget,
 
 void
 xlw_update_one_value (widget_instance* instance, Widget widget,
-                      widget_value* val);
+                      widget_value* val)
+  ATTRIBUTE_CONST;
 
 void
 xlw_destroy_instance (widget_instance* instance);
 
 void
-xlw_pop_instance (widget_instance* instance, Boolean up);
+xlw_pop_instance (widget_instance* instance, Boolean up)
+  ATTRIBUTE_CONST;
 
 void
 xlw_popup_menu (Widget widget, XEvent * event);
 
 #endif /* LWLIB_XLW_H */
-
diff --git a/lwlib/lwlib.h b/lwlib/lwlib.h
index 2fccc7a4f42..849930c3d25 100644
--- a/lwlib/lwlib.h
+++ b/lwlib/lwlib.h
@@ -171,9 +171,15 @@ void lw_refigure_widget (Widget w, Boolean doit);
 Boolean lw_window_is_in_menubar (Window win, Widget menubar_widget);
 
 /* Manage resizing: TRUE permits resizing widget w; FALSE disallows it. */
+#ifndef USE_MOTIF
+ATTRIBUTE_CONST
+#endif
 void lw_allow_resizing (Widget w, Boolean flag);
 
 /* Set up the main window. */
+#ifndef USE_MOTIF
+ATTRIBUTE_CONST
+#endif
 void lw_set_main_areas (Widget parent,
                         Widget menubar,
                         Widget work_area);