aboutsummaryrefslogtreecommitdiffstats
path: root/lisp
diff options
context:
space:
mode:
authorLars Magne Ingebrigtsen2014-12-08 22:51:54 +0100
committerLars Magne Ingebrigtsen2014-12-08 22:51:54 +0100
commite9aaf969661d134fa7e1548817fc9a05fa6b1bfb (patch)
treecfb992af0e59242250b2d328224006249216f86f /lisp
parentbe6767d59b9f984ee28d444aada0ecdd0245ec6e (diff)
downloademacs-e9aaf969661d134fa7e1548817fc9a05fa6b1bfb.tar.gz
emacs-e9aaf969661d134fa7e1548817fc9a05fa6b1bfb.zip
Make NSM warn on `high' for older protocols, and document
* doc/emacs/misc.texi (Network Security): Mention the new protocol-level `high' NSM checks. (nsm-check-protocol): Also warn if using SSL3 or older.
Diffstat (limited to 'lisp')
-rw-r--r--lisp/ChangeLog1
-rw-r--r--lisp/net/nsm.el13
2 files changed, 13 insertions, 1 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index c109bc7cab6..2669e07cd15 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -3,6 +3,7 @@
3 * net/nsm.el (nsm-check-protocol): Test for RC4 on `high'. 3 * net/nsm.el (nsm-check-protocol): Test for RC4 on `high'.
4 (nsm-format-certificate): Include more data about the connection. 4 (nsm-format-certificate): Include more data about the connection.
5 (nsm-query): Fill the text to that it looks nicer. 5 (nsm-query): Fill the text to that it looks nicer.
6 (nsm-check-protocol): Also warn if using SSL3 or older.
6 7
72014-12-08 Stefan Monnier <monnier@iro.umontreal.ca> 82014-12-08 Stefan Monnier <monnier@iro.umontreal.ca>
8 9
diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el
index d1de1288ca6..2306894cde3 100644
--- a/lisp/net/nsm.el
+++ b/lisp/net/nsm.el
@@ -181,7 +181,8 @@ unencrypted."
181 (encryption (format "%s-%s-%s" 181 (encryption (format "%s-%s-%s"
182 (plist-get status :key-exchange) 182 (plist-get status :key-exchange)
183 (plist-get status :cipher) 183 (plist-get status :cipher)
184 (plist-get status :mac)))) 184 (plist-get status :mac)))
185 (protocol (plist-get status :protocol)))
185 (cond 186 (cond
186 ((and prime-bits 187 ((and prime-bits
187 (< prime-bits 1024) 188 (< prime-bits 1024)
@@ -203,6 +204,16 @@ unencrypted."
203 host port encryption))) 204 host port encryption)))
204 (delete-process process) 205 (delete-process process)
205 nil) 206 nil)
207 ((and protocol
208 (string-match "SSL" protocol)
209 (not (memq :ssl (plist-get settings :conditions)))
210 (not
211 (nsm-query
212 host port status :ssl
213 "The connection to %s:%s uses the %s protocol, which is believed to be unsafe."
214 host port protocol)))
215 (delete-process process)
216 nil)
206 (t 217 (t
207 process)))) 218 process))))
208 219