diff options
| author | Juri Linkov | 2010-04-16 04:24:00 +0300 |
|---|---|---|
| committer | Juri Linkov | 2010-04-16 04:24:00 +0300 |
| commit | ad40eec53f36191178d6a512feeea1714d728224 (patch) | |
| tree | 94b003dcb40bedd3f2f45752f85aada4e9693bec /lisp | |
| parent | b117f7cc49000f4c2b046c9dfcae172ddc22dd0c (diff) | |
| download | emacs-ad40eec53f36191178d6a512feeea1714d728224.tar.gz emacs-ad40eec53f36191178d6a512feeea1714d728224.zip | |
Check both `isearch-scroll' and `scroll-command' properties.
* isearch.el (isearch-lookup-scroll-key): Check both
`isearch-scroll' and `scroll-command' properties.
(scroll-up, scroll-down): Remove `isearch-scroll' property.
* mwheel.el (mwheel-scroll): Remove `isearch-scroll' property.
* simple.el (scroll-up-command, scroll-down-command)
(scroll-up-line, scroll-down-line): Remove `isearch-scroll' property.
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/ChangeLog | 11 | ||||
| -rw-r--r-- | lisp/isearch.el | 15 | ||||
| -rw-r--r-- | lisp/mwheel.el | 1 | ||||
| -rw-r--r-- | lisp/simple.el | 4 |
4 files changed, 19 insertions, 12 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 6aeb1b1f1c2..a8d424459ab 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,14 @@ | |||
| 1 | 2010-04-16 Juri Linkov <juri@jurta.org> | ||
| 2 | |||
| 3 | * isearch.el (isearch-lookup-scroll-key): Check both | ||
| 4 | `isearch-scroll' and `scroll-command' properties. | ||
| 5 | (scroll-up, scroll-down): Remove `isearch-scroll' property. | ||
| 6 | |||
| 7 | * mwheel.el (mwheel-scroll): Remove `isearch-scroll' property. | ||
| 8 | |||
| 9 | * simple.el (scroll-up-command, scroll-down-command) | ||
| 10 | (scroll-up-line, scroll-down-line): Remove `isearch-scroll' property. | ||
| 11 | |||
| 1 | 2010-04-15 Juri Linkov <juri@jurta.org> | 12 | 2010-04-15 Juri Linkov <juri@jurta.org> |
| 2 | 13 | ||
| 3 | * simple.el (scroll-up-command, scroll-down-command) | 14 | * simple.el (scroll-up-command, scroll-down-command) |
diff --git a/lisp/isearch.el b/lisp/isearch.el index 3684c8e320a..64cb66bdab5 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el | |||
| @@ -1708,9 +1708,10 @@ Scroll-bar or mode-line events are processed appropriately." | |||
| 1708 | ;; attempts this, we scroll the text back again. | 1708 | ;; attempts this, we scroll the text back again. |
| 1709 | ;; | 1709 | ;; |
| 1710 | ;; We implement this feature with a property called `isearch-scroll'. | 1710 | ;; We implement this feature with a property called `isearch-scroll'. |
| 1711 | ;; If a command's symbol has the value t for this property it is a | 1711 | ;; If a command's symbol has the value t for this property or for the |
| 1712 | ;; scrolling command. The feature needs to be enabled by setting the | 1712 | ;; `scroll-command' property, it is a scrolling command. The feature |
| 1713 | ;; customizable variable `isearch-allow-scroll' to a non-nil value. | 1713 | ;; needs to be enabled by setting the customizable variable |
| 1714 | ;; `isearch-allow-scroll' to a non-nil value. | ||
| 1714 | ;; | 1715 | ;; |
| 1715 | ;; The universal argument commands (e.g. C-u) in simple.el are marked | 1716 | ;; The universal argument commands (e.g. C-u) in simple.el are marked |
| 1716 | ;; as scrolling commands, and isearch.el has been amended to allow | 1717 | ;; as scrolling commands, and isearch.el has been amended to allow |
| @@ -1727,12 +1728,11 @@ Scroll-bar or mode-line events are processed appropriately." | |||
| 1727 | (if (fboundp 'w32-handle-scroll-bar-event) | 1728 | (if (fboundp 'w32-handle-scroll-bar-event) |
| 1728 | (put 'w32-handle-scroll-bar-event 'isearch-scroll t)) | 1729 | (put 'w32-handle-scroll-bar-event 'isearch-scroll t)) |
| 1729 | 1730 | ||
| 1730 | ;; Commands which scroll the window: | 1731 | ;; Commands which scroll the window (some scroll commands |
| 1732 | ;; already have the `scroll-command' property on them): | ||
| 1731 | (put 'recenter 'isearch-scroll t) | 1733 | (put 'recenter 'isearch-scroll t) |
| 1732 | (put 'recenter-top-bottom 'isearch-scroll t) | 1734 | (put 'recenter-top-bottom 'isearch-scroll t) |
| 1733 | (put 'reposition-window 'isearch-scroll t) | 1735 | (put 'reposition-window 'isearch-scroll t) |
| 1734 | (put 'scroll-up 'isearch-scroll t) | ||
| 1735 | (put 'scroll-down 'isearch-scroll t) | ||
| 1736 | 1736 | ||
| 1737 | ;; Commands which act on the other window | 1737 | ;; Commands which act on the other window |
| 1738 | (put 'list-buffers 'isearch-scroll t) | 1738 | (put 'list-buffers 'isearch-scroll t) |
| @@ -1821,7 +1821,8 @@ Otherwise return nil." | |||
| 1821 | (let* ((overriding-terminal-local-map nil) | 1821 | (let* ((overriding-terminal-local-map nil) |
| 1822 | (binding (key-binding key-seq))) | 1822 | (binding (key-binding key-seq))) |
| 1823 | (and binding (symbolp binding) (commandp binding) | 1823 | (and binding (symbolp binding) (commandp binding) |
| 1824 | (eq (get binding 'isearch-scroll) t) | 1824 | (or (eq (get binding 'isearch-scroll) t) |
| 1825 | (eq (get binding 'scroll-command) t)) | ||
| 1825 | binding))) | 1826 | binding))) |
| 1826 | 1827 | ||
| 1827 | (defalias 'isearch-other-control-char 'isearch-other-meta-char) | 1828 | (defalias 'isearch-other-control-char 'isearch-other-meta-char) |
diff --git a/lisp/mwheel.el b/lisp/mwheel.el index 224920e515f..743204cbe45 100644 --- a/lisp/mwheel.el +++ b/lisp/mwheel.el | |||
| @@ -247,7 +247,6 @@ This should only be bound to mouse buttons 4 and 5." | |||
| 247 | 'mwheel-inhibit-click-timeout)))) | 247 | 'mwheel-inhibit-click-timeout)))) |
| 248 | 248 | ||
| 249 | (put 'mwheel-scroll 'scroll-command t) | 249 | (put 'mwheel-scroll 'scroll-command t) |
| 250 | (put 'mwheel-scroll 'isearch-scroll t) | ||
| 251 | 250 | ||
| 252 | (defvar mwheel-installed-bindings nil) | 251 | (defvar mwheel-installed-bindings nil) |
| 253 | 252 | ||
diff --git a/lisp/simple.el b/lisp/simple.el index bb8f1b65651..29f8a596f40 100644 --- a/lisp/simple.el +++ b/lisp/simple.el | |||
| @@ -4793,7 +4793,6 @@ If ARG is the atom `-', scroll downward by nearly full screen." | |||
| 4793 | (goto-char (point-max)))))))) | 4793 | (goto-char (point-max)))))))) |
| 4794 | 4794 | ||
| 4795 | (put 'scroll-up-command 'scroll-command t) | 4795 | (put 'scroll-up-command 'scroll-command t) |
| 4796 | (put 'scroll-up-command 'isearch-scroll t) | ||
| 4797 | 4796 | ||
| 4798 | (defun scroll-down-command (&optional arg) | 4797 | (defun scroll-down-command (&optional arg) |
| 4799 | "Scroll text of selected window down ARG lines; or near full screen if no ARG. | 4798 | "Scroll text of selected window down ARG lines; or near full screen if no ARG. |
| @@ -4826,7 +4825,6 @@ If ARG is the atom `-', scroll upward by nearly full screen." | |||
| 4826 | (goto-char (point-min)))))))) | 4825 | (goto-char (point-min)))))))) |
| 4827 | 4826 | ||
| 4828 | (put 'scroll-down-command 'scroll-command t) | 4827 | (put 'scroll-down-command 'scroll-command t) |
| 4829 | (put 'scroll-down-command 'isearch-scroll t) | ||
| 4830 | 4828 | ||
| 4831 | ;;; Scrolling commands which scroll a line instead of full screen. | 4829 | ;;; Scrolling commands which scroll a line instead of full screen. |
| 4832 | 4830 | ||
| @@ -4838,7 +4836,6 @@ This is different from `scroll-up-command' that scrolls a full screen." | |||
| 4838 | (scroll-up (or arg 1))) | 4836 | (scroll-up (or arg 1))) |
| 4839 | 4837 | ||
| 4840 | (put 'scroll-up-line 'scroll-command t) | 4838 | (put 'scroll-up-line 'scroll-command t) |
| 4841 | (put 'scroll-up-line 'isearch-scroll t) | ||
| 4842 | 4839 | ||
| 4843 | (defun scroll-down-line (&optional arg) | 4840 | (defun scroll-down-line (&optional arg) |
| 4844 | "Scroll text of selected window down ARG lines; or one line if no ARG. | 4841 | "Scroll text of selected window down ARG lines; or one line if no ARG. |
| @@ -4848,7 +4845,6 @@ This is different from `scroll-down-command' that scrolls a full screen." | |||
| 4848 | (scroll-down (or arg 1))) | 4845 | (scroll-down (or arg 1))) |
| 4849 | 4846 | ||
| 4850 | (put 'scroll-down-line 'scroll-command t) | 4847 | (put 'scroll-down-line 'scroll-command t) |
| 4851 | (put 'scroll-down-line 'isearch-scroll t) | ||
| 4852 | 4848 | ||
| 4853 | 4849 | ||
| 4854 | (defun scroll-other-window-down (lines) | 4850 | (defun scroll-other-window-down (lines) |