(all-completions): Declare the 4th arg obsolete.

3 files changed, 48 insertions, 4 deletions

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0ff59e4ef35..4e210449f1f 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2009-10-26  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+        * subr.el (all-completions): Declare the 4th arg obsolete.
+
 2009-10-25  Stefan Monnier  <monnier@iro.umontreal.ca>
 
         * pcomplete.el (pcomplete-unquote-argument-function): New var.
@@ -10,6 +14,36 @@
         * bookmark.el (bookmark-bmenu-list): Don't use switch-to-buffer if
         we're inside a dedicated or minibuffer window.
 
+2009-10-25  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+        * cedet/semantic/fw.el (semantic-alias-obsolete)
+        (semantic-varalias-obsolete): Make the `when' arg mandatory.
+        (define-mode-overload-implementation):
+        * cedet/semantic/decorate/mode.el (semantic-decorate-pending-decoration-hooks):
+        * cedet/semantic/wisent.el (wisent-lex-make-token-table):
+        * cedet/semantic/util.el (semantic-file-token-stream)
+        (semantic-something-to-stream):
+        * cedet/semantic/tag.el (semantic-tag-make-assoc-list)
+        (semantic-expand-nonterminal):
+        * cedet/semantic/tag-file.el (semantic-find-nonterminal)
+        (semantic-find-dependency, semantic-find-nonterminal)
+        (semantic-find-dependency):
+        * cedet/semantic/lex.el (semantic-flex-start, semantic-flex-end)
+        (semantic-flex-text, semantic-flex-make-keyword-table)
+        (semantic-flex-keyword-p, semantic-flex-keyword-put)
+        (semantic-flex-keyword-get, semantic-flex-map-keywords)
+        (semantic-flex-keywords, semantic-flex-buffer, semantic-flex-list):
+        * cedet/semantic/java.el (semantic-java-prototype-nonterminal):
+        * cedet/semantic/idle.el (semantic-before-idle-scheduler-reparse-hooks)
+        (semantic-after-idle-scheduler-reparse-hooks):
+        * cedet/semantic/edit.el (semantic-edits-incremental-reparse-failed-hooks):
+        * cedet/semantic/db-mode.el (semanticdb-mode-hooks):
+        * cedet/semantic.el (semantic-toplevel-bovine-table)
+        (semantic-toplevel-bovine-cache)
+        (semantic-before-toplevel-bovination-hook, semantic-init-hooks)
+        (semantic-init-mode-hooks, semantic-init-db-hooks)
+        (semantic-bovination-working-type): Provide the `when' arg.
+
 2009-10-24  Karl Fogel  <kfogel@red-bean.com>
 
         * bookmark.el: Update documentation, especially documentation
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 014faeac79c..783e219199b 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -40,9 +40,17 @@
 ;;   corresponding to the displayed completions because we only
 ;;   provide the start info but not the end info in
 ;;   completion-base-position.
+;; - quoting is problematic.  E.g. the double-dollar quoting used in
+;;   substitie-in-file-name (and hence read-file-name-internal) bumps
+;;   into various bugs:
 ;; - choose-completion doesn't know how to quote the text it inserts.
 ;;   E.g. it fails to double the dollars in file-name completion, or
 ;;   to backslash-escape spaces and other chars in comint completion.
+;;   - when completing ~/tmp/fo$$o, the highligting in *Completions*
+;;     is off by one position.
+;;   - all code like PCM which relies on all-completions to match
+;;     its argument gets confused because all-completions returns unquoted
+;;     texts (as desired for *Completions* output).
 ;; - C-x C-f ~/*/sr ? should not list "~/./src".
 ;; - minibuffer-force-complete completes ~/src/emacs/t<!>/lisp/minibuffer.el
 ;;   to ~/src/emacs/trunk/ and throws away lisp/minibuffer.el.
@@ -72,8 +80,6 @@
 ;; - add support for ** to pcm.
 ;; - Add vc-file-name-completion-table to read-file-name-internal.
 ;; - A feature like completing-help.el.
-;; - make lisp/complete.el obsolete.
-;; - Make the `hide-spaces' arg of all-completions obsolete?
 
 ;;; Code:
 
diff --git a/lisp/subr.el b/lisp/subr.el
index 9d49075a469..30107edd4a4 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -1038,6 +1038,8 @@ is converted into a string by expressing it in decimal."
                "explicitly check for a frame-parameter instead." "22.2")
 (make-obsolete 'interactive-p 'called-interactively-p "23.2")
 (set-advertised-calling-convention 'called-interactively-p '(kind))
+(set-advertised-calling-convention
+ 'all-completions '(string collection &optional predicate))
 
 ;;;; Obsolescence declarations for variables, and aliases.
 
@@ -1885,11 +1887,13 @@ any other non-digit terminates the character code and is then used as input."))
              ;; Turn a meta-character into a character with the 0200 bit set.
              (setq code (logior (logand translated (lognot ?\M-\^@)) 128)
                    done t))
-            ((and (<= ?0 translated) (< translated (+ ?0 (min 10 read-quoted-char-radix))))
+            ((and (<= ?0 translated)
+                  (< translated (+ ?0 (min 10 read-quoted-char-radix))))
              (setq code (+ (* code read-quoted-char-radix) (- translated ?0)))
              (and prompt (setq prompt (message "%s %c" prompt translated))))
             ((and (<= ?a (downcase translated))
-                  (< (downcase translated) (+ ?a -10 (min 36 read-quoted-char-radix))))
+                  (< (downcase translated)
+                     (+ ?a -10 (min 36 read-quoted-char-radix))))
              (setq code (+ (* code read-quoted-char-radix)
                            (+ 10 (- (downcase translated) ?a))))
              (and prompt (setq prompt (message "%s %c" prompt translated))))