diff options
| author | Vitalie Spinu | 2019-05-07 13:15:43 +0200 |
|---|---|---|
| committer | Vitalie Spinu | 2019-05-07 13:45:00 +0200 |
| commit | 37436fe6d32539b03d1c4dbd535d5409bef5ac09 (patch) | |
| tree | 7401f08a80b2856cdf3f0a989107c3839680ec45 /lisp | |
| parent | fb65a36f4587726b3de0df02daf02c28e9129f62 (diff) | |
| download | emacs-37436fe6d32539b03d1c4dbd535d5409bef5ac09.tar.gz emacs-37436fe6d32539b03d1c4dbd535d5409bef5ac09.zip | |
Fix cloning of eieio-named objects (Bug#22840)
* lisp/emacs-lisp/eieio-base.el (clone): Correctly set the name of the
cloned objects from eieio-named instances.
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/emacs-lisp/eieio-base.el | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/lisp/emacs-lisp/eieio-base.el b/lisp/emacs-lisp/eieio-base.el index 7a9f905c6fe..3aeda92db12 100644 --- a/lisp/emacs-lisp/eieio-base.el +++ b/lisp/emacs-lisp/eieio-base.el | |||
| @@ -510,16 +510,18 @@ instance." | |||
| 510 | All slots are unbound, except those initialized with PARAMS." | 510 | All slots are unbound, except those initialized with PARAMS." |
| 511 | (let* ((newname (and (stringp (car params)) (pop params))) | 511 | (let* ((newname (and (stringp (car params)) (pop params))) |
| 512 | (nobj (apply #'cl-call-next-method obj params)) | 512 | (nobj (apply #'cl-call-next-method obj params)) |
| 513 | (nm (slot-value obj 'object-name))) | 513 | (nm (slot-value nobj 'object-name))) |
| 514 | (eieio-oset obj 'object-name | 514 | (eieio-oset nobj 'object-name |
| 515 | (or newname | 515 | (or newname |
| 516 | (save-match-data | 516 | (if (equal nm (slot-value obj 'object-name)) |
| 517 | (if (and nm (string-match "-\\([0-9]+\\)" nm)) | 517 | (save-match-data |
| 518 | (let ((num (1+ (string-to-number | 518 | (if (and nm (string-match "-\\([0-9]+\\)" nm)) |
| 519 | (match-string 1 nm))))) | 519 | (let ((num (1+ (string-to-number |
| 520 | (concat (substring nm 0 (match-beginning 0)) | 520 | (match-string 1 nm))))) |
| 521 | "-" (int-to-string num))) | 521 | (concat (substring nm 0 (match-beginning 0)) |
| 522 | (concat nm "-1"))))) | 522 | "-" (int-to-string num))) |
| 523 | (concat nm "-1"))) | ||
| 524 | nm))) | ||
| 523 | nobj)) | 525 | nobj)) |
| 524 | 526 | ||
| 525 | (cl-defmethod make-instance ((class (subclass eieio-named)) &rest args) | 527 | (cl-defmethod make-instance ((class (subclass eieio-named)) &rest args) |