Fix splash screen display at startup

* src/frame.c (DEFAULT_ROWS): Enlarge to 36, so that the initial
window displayed by "emacs -q" has enough space to show the whole
text even if it includes 2 lines talking about recovering crashes
sessions.  (Bug#23074)

* lisp/startup.el (use-fancy-splash-screens-p): Fix off-by-one
error when computing the window-height from frame-height.

* etc/NEWS: Mention the change.

1 files changed, 6 insertions, 4 deletions

diff --git a/lisp/startup.el b/lisp/startup.el
index 15a79f6f5bf..536289c3891 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1890,10 +1890,12 @@ we put it on this frame."
       (when frame
         (let* ((img (create-image (fancy-splash-image-file)))
                (image-height (and img (cdr (image-size img nil frame))))
-               ;; We test frame-height so that, if the frame is split
-               ;; by displaying a warning, that doesn't cause the normal
-               ;; splash screen to be used.
-               (frame-height (1- (frame-height frame))))
+               ;; We test frame-height and not window-height so that,
+               ;; if the frame is split by displaying a warning, that
+               ;; doesn't cause the normal splash screen to be used.
+               ;; We subtract 2 from frame-height to account for the
+               ;; echo area and the mode line.
+               (frame-height (- (frame-height frame) 2)))
           (> frame-height (+ image-height 19)))))))