aboutsummaryrefslogtreecommitdiffstats
path: root/lisp
diff options
context:
space:
mode:
authorGlenn Morris2012-03-31 12:58:05 -0700
committerGlenn Morris2012-03-31 12:58:05 -0700
commit0b0210946b093bcabae9b6bbd06b28b494d1188d (patch)
tree3252291c0b4f2af3789ebcffd57e8f67cab1dc95 /lisp
parent979022ef177beb0022838f6b49da6632cd0d3414 (diff)
downloademacs-0b0210946b093bcabae9b6bbd06b28b494d1188d.tar.gz
emacs-0b0210946b093bcabae9b6bbd06b28b494d1188d.zip
Edebug doc fixes
* doc/lispref/edebug.texi (Instrumenting Macro Calls): Mention defining macros at instrumentation time. (Edebug Options): Mention edebug-unwrap-results. * lisp/emacs-lisp/edebug.el (edebug-unwrap-results): Doc fix. Comments. * admin/FOR-RELEASE: Markup.
Diffstat (limited to 'lisp')
-rw-r--r--lisp/ChangeLog4
-rw-r--r--lisp/emacs-lisp/edebug.el13
2 files changed, 15 insertions, 2 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 2def7e4c934..970c74bf50f 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
12012-03-31 Glenn Morris <rgm@gnu.org>
2
3 * emacs-lisp/edebug.el (edebug-unwrap-results): Doc fix.
4
12012-03-30 Thierry Volpiatto <thierry.volpiatto@gmail.com> 52012-03-30 Thierry Volpiatto <thierry.volpiatto@gmail.com>
2 6
3 * dired-aux.el (dired-copy-file-recursive, dired-create-files): 7 * dired-aux.el (dired-copy-file-recursive, dired-create-files):
diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index c241ac710cf..67ffd6d5d31 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -1,6 +1,6 @@
1;;; edebug.el --- a source-level debugger for Emacs Lisp 1;;; edebug.el --- a source-level debugger for Emacs Lisp
2 2
3;; Copyright (C) 1988-1995, 1997, 1999-2012 Free Software Foundation, Inc. 3;; Copyright (C) 1988-1995, 1997, 1999-2012 Free Software Foundation, Inc.
4 4
5;; Author: Daniel LaLiberte <liberte@holonexus.org> 5;; Author: Daniel LaLiberte <liberte@holonexus.org>
6;; Maintainer: FSF 6;; Maintainer: FSF
@@ -191,6 +191,7 @@ Use this with caution since it is not debugged."
191 191
192(defcustom edebug-unwrap-results nil 192(defcustom edebug-unwrap-results nil
193 "Non-nil if Edebug should unwrap results of expressions. 193 "Non-nil if Edebug should unwrap results of expressions.
194That is, Edebug will try to remove its own instrumentation from the result.
194This is useful when debugging macros where the results of expressions 195This is useful when debugging macros where the results of expressions
195are instrumented expressions. But don't do this when results might be 196are instrumented expressions. But don't do this when results might be
196circular or an infinite loop will result." 197circular or an infinite loop will result."
@@ -2028,7 +2029,10 @@ expressions; a `progn' form will be returned enclosing these forms."
2028(def-edebug-spec apply (function-form &rest form)) 2029(def-edebug-spec apply (function-form &rest form))
2029(def-edebug-spec funcall (function-form &rest form)) 2030(def-edebug-spec funcall (function-form &rest form))
2030 2031
2031;; FIXME? The manual has a gate here. 2032;; FIXME? The manual uses this form (maybe that's just for illustration?):
2033;; (def-edebug-spec let
2034;; ((&rest &or symbolp (gate symbolp &optional form))
2035;; body))
2032(def-edebug-spec let 2036(def-edebug-spec let
2033 ((&rest &or (symbolp &optional form) symbolp) 2037 ((&rest &or (symbolp &optional form) symbolp)
2034 body)) 2038 body))
@@ -4157,6 +4161,8 @@ You must include newlines in FMT to break lines, but one newline is appended."
4157;;; Frequency count and coverage 4161;;; Frequency count and coverage
4158 4162
4159;; FIXME should this use overlays instead? 4163;; FIXME should this use overlays instead?
4164;; Definitely, IMO. The current business with undo in
4165;; edebug-temp-display-freq-count is horrid.
4160(defun edebug-display-freq-count () 4166(defun edebug-display-freq-count ()
4161 "Display the frequency count data for each line of the current definition. 4167 "Display the frequency count data for each line of the current definition.
4162The frequency counts are inserted as comment lines after each line, 4168The frequency counts are inserted as comment lines after each line,
@@ -4226,6 +4232,8 @@ reinstrument it."
4226 (insert "\n") 4232 (insert "\n")
4227 (setq i first-index))))) 4233 (setq i first-index)))))
4228 4234
4235;; FIXME this does not work very well. Eg if you press an arrow key,
4236;; or make a mouse-click, it fails with "Non-character input-event".
4229(defun edebug-temp-display-freq-count () 4237(defun edebug-temp-display-freq-count ()
4230 "Temporarily display the frequency count data for the current definition. 4238 "Temporarily display the frequency count data for the current definition.
4231It is removed when you hit any char." 4239It is removed when you hit any char."
@@ -4235,6 +4243,7 @@ It is removed when you hit any char."
4235 (undo-boundary) 4243 (undo-boundary)
4236 (edebug-display-freq-count) 4244 (edebug-display-freq-count)
4237 (setq unread-command-char (read-char)) 4245 (setq unread-command-char (read-char))
4246 ;; Yuck! This doesn't seem to work at all for me.
4238 (undo))) 4247 (undo)))
4239 4248
4240 4249