aboutsummaryrefslogtreecommitdiffstats
path: root/lisp
diff options
context:
space:
mode:
authorTino Calancha2018-06-03 23:28:24 +0900
committerTino Calancha2018-06-03 23:28:24 +0900
commit031004e81b1507c4594ae253faaafcda31f253c8 (patch)
tree7f3c92e2169d93ee3f74facf5a4a24f8db6e1307 /lisp
parent50c0624b2aecb9668505eb2cea3f30aecbf6d1ec (diff)
downloademacs-031004e81b1507c4594ae253faaafcda31f253c8.tar.gz
emacs-031004e81b1507c4594ae253faaafcda31f253c8.zip
Backport: Fix corner case in query-replace-regexp undo
This commit fixes Bug#31492. * lisp/replace.el (replace-match-maybe-edit): Preserve match data. * test/lisp/replace-tests.el (query-replace-undo-bug31492): Add test. (cherry picked from commit bab73230d1be1fe394b7269c1365ef6fb1a5d9b3)
Diffstat (limited to 'lisp')
-rw-r--r--lisp/replace.el4
1 files changed, 4 insertions, 0 deletions
diff --git a/lisp/replace.el b/lisp/replace.el
index d1eabb035d3..88da7e26cb0 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -2147,6 +2147,10 @@ passed in. If LITERAL is set, no checking is done, anyway."
2147 noedit nil))) 2147 noedit nil)))
2148 (set-match-data match-data) 2148 (set-match-data match-data)
2149 (replace-match newtext fixedcase literal) 2149 (replace-match newtext fixedcase literal)
2150 ;; `query-replace' undo feature needs the beginning of the match position,
2151 ;; but `replace-match' may change it, for instance, with a regexp like "^".
2152 ;; Ensure that this function preserves the match data (Bug#31492).
2153 (set-match-data match-data)
2150 ;; `replace-match' leaves point at the end of the replacement text, 2154 ;; `replace-match' leaves point at the end of the replacement text,
2151 ;; so move point to the beginning when replacing backward. 2155 ;; so move point to the beginning when replacing backward.
2152 (when backward (goto-char (nth 0 match-data))) 2156 (when backward (goto-char (nth 0 match-data)))