Add `predicate' arg to `read-buffer' and use it for erc-iswitchb

Fixes: debbugs:20116

* src/minibuf.c (Fread_buffer): Add `predicate' argument.
* src/callint.c (Fcall_interactively): Adjust calls accordingly.

* lisp/erc/erc.el (erc-switch-to-buffer): Rename from erc-iswitchb and rewrite
using read-buffer.
(erc--buffer-p): New function, extracted from erc-buffer-filter.
(erc-buffer-filter): Use it.
(erc-with-all-buffers-of-server): Silence compile warning if the return
value is unused.
(erc-is-valid-nick-p, erc-common-server-suffixes, erc-get-arglist)
(erc-command-name, erc-popup-input-buffer): Use \` and \' to match
beg/end of string.

* lisp/obsolete/iswitchb.el (iswitchb-read-buffer): Add `predicate' arg.
* lisp/isearchb.el (isearchb-iswitchb): Adjust accordingly.
* lisp/ido.el (ido-read-buffer): Add `predicate' argument.
* lisp/misearch.el (unload-function-defs-list): Declare before use.

1 files changed, 1 insertions, 1 deletions

diff --git a/lisp/replace.el b/lisp/replace.el
index e0636e0728c..70b86dd2016 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -1369,7 +1369,7 @@ See also `multi-occur-in-matching-buffers'."
            (ido-ignore-item-temp-list bufs))
       (while (not (string-equal
                    (setq buf (read-buffer
-                              (if (eq read-buffer-function 'ido-read-buffer)
+                              (if (eq read-buffer-function #'ido-read-buffer)
                                   "Next buffer to search (C-j to end): "
                                 "Next buffer to search (RET to end): ")
                               nil t))