Use `replace-region-contents` to replace insert+delete

* lisp/minibuffer.el (completion--replace):
* lisp/emacs-lisp/cl-lib.el (cl--set-buffer-substring):
* lisp/subr.el (replace-string-in-region):
Use `replace-region-contents` instead of insert+delete.

* lisp/help-fns.el (help-fns--signature):
Use `replace-region-contents` instead of `cl--set-buffer-substring`.

* lisp/language/japan-util.el (japanese-replace-region):
Rewrite using `replace-region-contents` and mark obsolete.
(japanese-katakana-region, japanese-hankaku-region):
Use `replace-region-contents` instead.

* lisp/progmodes/flymake-proc.el (flymake-proc--replace-region):
Rewrite using `replace-region-contents` and mark obsolete.
(flymake-proc--check-patch-master-file-buffer):
Use `replace-region-contents` instead.

1 files changed, 25 insertions, 18 deletions

diff --git a/lisp/language/japan-util.el b/lisp/language/japan-util.el
index 718c469d562..6fbb52b627e 100644
--- a/lisp/language/japan-util.el
+++ b/lisp/language/japan-util.el
@@ -217,9 +217,9 @@ The argument object is not altered--the value is a copy."
 
 (defun japanese-replace-region (from to string)
   "Replace the region specified by FROM and TO to STRING."
-  (goto-char from)
-  (insert string)
-  (delete-char (- to from)))
+  (declare (obsolete replace-region-contents "31.1"))
+  (goto-char to)
+  (replace-region-contents from to string 0))
 
 ;;;###autoload
 (defun japanese-katakana-region (from to &optional hankaku)
@@ -238,13 +238,15 @@ of which charset is `japanese-jisx0201-kana'."
                      (get-char-code-property kana 'kana-composition)))
                slot) ;; next
           (if (and composition (setq slot (assq (following-char) composition)))
-              (japanese-replace-region (match-beginning 0) (1+ (point))
-                                       (cdr slot))
+              (progn
+                (goto-char (1+ (point)))
+                (replace-region-contents (match-beginning 0) (point)
+                                         (cdr slot) 0))
             (let ((kata (get-char-code-property
                          kana (if hankaku 'jisx0201 'katakana))))
               (if kata
-                  (japanese-replace-region (match-beginning 0) (point)
-                                           kata)))))))))
+                  (replace-region-contents (match-beginning 0) (point)
+                                           kata 0)))))))))
 
 
 ;;;###autoload
@@ -260,13 +262,16 @@ of which charset is `japanese-jisx0201-kana'."
                (composition (get-char-code-property kata 'kana-composition))
                slot) ;; next
           (if (and composition (setq slot (assq (following-char) composition)))
-              (japanese-replace-region (match-beginning 0) (1+ (point))
-                                       (get-char-code-property
-                                        (cdr slot) 'hiragana))
+              (progn
+                (goto-char (1+ (point)))
+                (replace-region-contents (match-beginning 0) (point)
+                                         (get-char-code-property
+                                          (cdr slot) 'hiragana)
+                                         0))
             (let ((hira (get-char-code-property kata 'hiragana)))
               (if hira
-                  (japanese-replace-region (match-beginning 0) (point)
-                                           hira)))))))))
+                  (replace-region-contents (match-beginning 0) (point)
+                                           hira 0)))))))))
 
 ;;;###autoload
 (defun japanese-hankaku-region (from to &optional ascii-only)
@@ -285,8 +290,8 @@ Optional argument ASCII-ONLY non-nil means to convert only to ASCII char."
                                  (get-char-code-property zenkaku 'jisx0201))
                             (get-char-code-property zenkaku 'ascii))))
           (if hankaku
-              (japanese-replace-region (match-beginning 0) (match-end 0)
-                                       hankaku)))))))
+              (replace-region-contents (match-beginning 0) (match-end 0)
+                                       hankaku 0)))))))
 
 ;;;###autoload
 (defun japanese-zenkaku-region (from to &optional katakana-only)
@@ -307,12 +312,14 @@ Optional argument KATAKANA-ONLY non-nil means to convert only KATAKANA char."
                (composition (get-char-code-property hankaku 'kana-composition))
                slot) ;; next
           (if (and composition (setq slot (assq (following-char) composition)))
-              (japanese-replace-region (match-beginning 0) (1+ (point))
-                                       (cdr slot))
+              (progn
+                (goto-char (1+ (point)))
+                (replace-region-contents (match-beginning 0) (point)
+                                         (cdr slot) 0))
             (let ((zenkaku (japanese-zenkaku hankaku)))
               (if zenkaku
-                  (japanese-replace-region (match-beginning 0) (match-end 0)
-                                           zenkaku)))))))))
+                  (replace-region-contents (match-beginning 0) (match-end 0)
+                                           zenkaku 0)))))))))
 
 ;;;###autoload
 (defun read-hiragana-string (prompt &optional initial-input)