diff options
| author | Paul Eggert | 2020-05-16 17:04:15 -0700 |
|---|---|---|
| committer | Paul Eggert | 2020-05-16 17:05:37 -0700 |
| commit | c7bc28bf038e08fcc03e5dc96cd762af06b34e09 (patch) | |
| tree | 378ddd85e5549bddeb5642314c8ac1627743e324 /lisp/frameset.el | |
| parent | a6ebca21b349ccfffdc0d4b84578d4c7a0f3ee22 (diff) | |
| download | emacs-c7bc28bf038e08fcc03e5dc96cd762af06b34e09.tar.gz emacs-c7bc28bf038e08fcc03e5dc96cd762af06b34e09.zip | |
Don’t attempt to modify constant conses
From a patch privately suggested by Mattias Engdegård on 2020-05-11
in a followup to Bug#40671.
* admin/charsets/cp51932.awk:
* admin/charsets/eucjp-ms.awk:
Generate code that does not modify constant conses.
* doc/misc/emacs-mime.texi (Encoding Customization):
* lisp/emacs-lisp/byte-opt.el (byte-compile-side-effect-free-ops):
* lisp/frameset.el (frameset-persistent-filter-alist):
* lisp/gnus/gnus-sum.el (gnus-article-mode-line-format-alist):
Use append instead of nconc.
* lisp/language/japanese.el (japanese-ucs-cp932-to-jis-map)
(jisx0213-to-unicode):
Use mapcar instead of mapc.
* lisp/language/lao-util.el (lao-transcription-consonant-alist)
(lao-transcription-vowel-alist):
* lisp/language/tibetan.el (tibetan-subjoined-transcription-alist):
Use copy-sequence.
* test/src/fns-tests.el (fns-tests-nreverse):
(fns-tests-sort, fns-tests-collate-sort)
(fns-tests-string-version-lessp, fns-tests-mapcan):
Use copy-sequence, vector, and list.
Diffstat (limited to 'lisp/frameset.el')
| -rw-r--r-- | lisp/frameset.el | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lisp/frameset.el b/lisp/frameset.el index 10c6914f52d..0462d776c0e 100644 --- a/lisp/frameset.el +++ b/lisp/frameset.el | |||
| @@ -396,17 +396,17 @@ Properties can be set with | |||
| 396 | ;; or, if you're only changing a few items, | 396 | ;; or, if you're only changing a few items, |
| 397 | ;; | 397 | ;; |
| 398 | ;; (defvar my-filter-alist | 398 | ;; (defvar my-filter-alist |
| 399 | ;; (nconc '((my-param1 . :never) | 399 | ;; (append '((my-param1 . :never) |
| 400 | ;; (my-param2 . my-filtering-function)) | 400 | ;; (my-param2 . my-filtering-function)) |
| 401 | ;; frameset-filter-alist) | 401 | ;; frameset-filter-alist) |
| 402 | ;; "My brief customized parameter filter alist.") | 402 | ;; "My brief customized parameter filter alist.") |
| 403 | ;; | 403 | ;; |
| 404 | ;; and pass it to the FILTER arg of the save/restore functions, | 404 | ;; and pass it to the FILTER arg of the save/restore functions, |
| 405 | ;; ALWAYS taking care of not modifying the original lists; if you're | 405 | ;; ALWAYS taking care of not modifying the original lists; if you're |
| 406 | ;; going to do any modifying of my-filter-alist, please use | 406 | ;; going to do any modifying of my-filter-alist, please use |
| 407 | ;; | 407 | ;; |
| 408 | ;; (nconc '((my-param1 . :never) ...) | 408 | ;; (append '((my-param1 . :never) ...) |
| 409 | ;; (copy-sequence frameset-filter-alist)) | 409 | ;; (copy-sequence frameset-filter-alist)) |
| 410 | ;; | 410 | ;; |
| 411 | ;; One thing you shouldn't forget is that they are alists, so searching | 411 | ;; One thing you shouldn't forget is that they are alists, so searching |
| 412 | ;; in them is sequential. If you just want to change the default of | 412 | ;; in them is sequential. If you just want to change the default of |
| @@ -445,7 +445,7 @@ DO NOT MODIFY. See `frameset-filter-alist' for a full description.") | |||
| 445 | 445 | ||
| 446 | ;;;###autoload | 446 | ;;;###autoload |
| 447 | (defvar frameset-persistent-filter-alist | 447 | (defvar frameset-persistent-filter-alist |
| 448 | (nconc | 448 | (append |
| 449 | '((background-color . frameset-filter-sanitize-color) | 449 | '((background-color . frameset-filter-sanitize-color) |
| 450 | (buffer-list . :never) | 450 | (buffer-list . :never) |
| 451 | (buffer-predicate . :never) | 451 | (buffer-predicate . :never) |