Clarify structure of file-attribute's device number

* doc/lispref/buffers.texi (Buffer File Name): Fix description of
buffer-file-number.

* doc/lispref/files.texi (File Attributes): Clarify type of device
number.  Describe file-attribute-file-number.  (Bug#58446)

* etc/NEWS: Mention file-attribute-file-number.

* lisp/files.el (buffer-file-number, file-attribute-device-number)
(file-attribute-collect): Fix docstring.
(file-attribute-file-number): New defsubst.
(find-buffer-visiting, find-file-noselect)
(set-visited-file-name, basic-save-buffer):
* lisp/startup.el (normal-top-level-add-subdirs-to-load-path):
* lisp/eshell/em-unix.el (eshell-shuffle-files): Use it.

* src/dired.c (Ffile_attributes): Fix docstring.

1 files changed, 2 insertions, 4 deletions

diff --git a/lisp/eshell/em-unix.el b/lisp/eshell/em-unix.el
index 40b83010f94..378b0ceeeae 100644
--- a/lisp/eshell/em-unix.el
+++ b/lisp/eshell/em-unix.el
@@ -372,12 +372,10 @@ Remove the DIRECTORY(ies), if they are empty.")
              (setq attr (eshell-file-attributes (car files)))
              (file-attribute-inode-number attr-target)
              (file-attribute-inode-number attr)
-             (equal (file-attribute-inode-number attr-target)
-                    (file-attribute-inode-number attr))
              (file-attribute-device-number attr-target)
              (file-attribute-device-number attr)
-             (equal (file-attribute-device-number attr-target)
-                    (file-attribute-device-number attr)))
+             (equal (file-attribute-file-number attr-target)
+                    (file-attribute-file-number attr)))
         (eshell-error (format-message "%s: `%s' and `%s' are the same file\n"
                                       command (car files) target)))
        (t