Make eshell-for obsolete (replaced by dolist)

* eshell/esh-util.el (eshell-for): Make it obsolete.
* eshell/em-alias.el (eshell/alias, eshell-alias-completions):
* eshell/em-dirs.el (eshell-save-some-last-dir):
* eshell/em-hist.el (eshell-save-some-history, eshell-hist-parse-modifier):
* eshell/em-ls.el (eshell-ls-dir, eshell-ls-files, eshell-ls-entries):
* eshell/em-unix.el (eshell/cat, eshell/du, eshell/su):
* eshell/esh-cmd.el (eshell-invoke-directly, eshell-do-eval, eshell/which):
* eshell/esh-ext.el (eshell-find-interpreter):
* eshell/esh-mode.el (eshell-mode):
* eshell/esh-module.el (eshell-unload-extension-modules):
* eshell/esh-proc.el (eshell-process-interact):
* eshell/esh-test.el (eshell-test):
* eshell/esh-util.el (eshell-flatten-list, eshell-winnow-list):
* eshell/esh-var.el (eshell/env, eshell-environment-variables)
(eshell-variables-list):
* eshell/eshell.el (eshell-unload-all-modules):
Replace eshell-for with dolist.

1 files changed, 3 insertions, 3 deletions

diff --git a/lisp/eshell/esh-cmd.el b/lisp/eshell/esh-cmd.el
index 0567beb9a53..0a00300d19c 100644
--- a/lisp/eshell/esh-cmd.el
+++ b/lisp/eshell/esh-cmd.el
@@ -987,7 +987,7 @@ at the moment are:
          (not (member name eshell-complex-commands))
          (catch 'simple
            (progn
-            (eshell-for pred eshell-complex-commands
+            (dolist (pred eshell-complex-commands)
               (if (and (functionp pred)
                        (funcall pred name))
                   (throw 'simple nil)))
@@ -1165,7 +1165,7 @@ be finished later after the completion of an asynchronous subprocess."
         (if (and (eq (car form) 'let)
                  (not (eq (car (cadr args)) 'eshell-do-eval)))
             (eshell-manipulate "evaluating let args"
-              (eshell-for letarg (car args)
+              (dolist (letarg (car args))
                 (if (and (listp letarg)
                          (not (eq (cadr letarg) 'quote)))
                     (setcdr letarg
@@ -1241,7 +1241,7 @@ be finished later after the completion of an asynchronous subprocess."
 
 (defun eshell/which (command &rest names)
   "Identify the COMMAND, and where it is located."
-  (eshell-for name (cons command names)
+  (dolist (name (cons command names))
     (let (program alias direct)
       (if (eq (aref name 0) eshell-explicit-command-char)
           (setq name (substring name 1)