diff options
| author | F. Jason Park | 2024-08-19 22:40:25 -0700 |
|---|---|---|
| committer | F. Jason Park | 2024-09-29 16:13:01 -0700 |
| commit | 8f326e0ba23f88ee5ef25fb89f6c7cedbdbda89e (patch) | |
| tree | 0778e67c3a5427c5e8b08fd39114d932c0ee9403 /lisp/erc | |
| parent | dd4c67907eb3084c6f55828c51bca1675a98376d (diff) | |
| download | emacs-8f326e0ba23f88ee5ef25fb89f6c7cedbdbda89e.tar.gz emacs-8f326e0ba23f88ee5ef25fb89f6c7cedbdbda89e.zip | |
; Rename internal variable in erc-fill
* lisp/erc/erc-fill.el (erc--fill-wrap-scrolltobottom-exempt-p):
Rename to `erc-fill--wrap-scrolltobottom-exempt-p' so prefix matches
library and feature.
(erc-fill--wrap-ensure-dependencies): Update variable name.
* lisp/erc/erc-truncate.el (erc-max-buffer-size): Don't mention
`erc-insert-post-hook' in doc string because truncation now happens
elsewhere.
(erc-truncate-buffer-to-size): Update obsolete comment that describes
pre-5.5/Emacs 29 behavior.
* test/lisp/erc/erc-fill-tests.el (erc-fill-tests--wrap-populate):
Update variable name.
* test/lisp/erc/resources/erc-d/erc-d-tests.el
(erc-d-u--canned-load-dialog--basic)
(erc-d-u--canned-load-dialog--intermingled)
(erc-d-u--rewrite-for-slow-mo): Timeouts.
* test/lisp/erc/resources/erc-d/resources/basic.eld: Timeouts.
* test/lisp/erc/resources/erc-scenarios-common.el
(erc-scenarios-common--make-bindings): Use updated variable name.
(Bug#72736)
Diffstat (limited to 'lisp/erc')
| -rw-r--r-- | lisp/erc/erc-fill.el | 4 | ||||
| -rw-r--r-- | lisp/erc/erc-truncate.el | 7 |
2 files changed, 4 insertions, 7 deletions
diff --git a/lisp/erc/erc-fill.el b/lisp/erc/erc-fill.el index c863d99a339..986314822ba 100644 --- a/lisp/erc/erc-fill.el +++ b/lisp/erc/erc-fill.el | |||
| @@ -421,7 +421,7 @@ is 0, reset to value of `erc-fill-wrap-visual-keys'." | |||
| 421 | (defvar erc-scrolltobottom-mode) | 421 | (defvar erc-scrolltobottom-mode) |
| 422 | (defvar erc-legacy-invisible-bounds-p) | 422 | (defvar erc-legacy-invisible-bounds-p) |
| 423 | 423 | ||
| 424 | (defvar erc--fill-wrap-scrolltobottom-exempt-p nil) | 424 | (defvar erc-fill--wrap-scrolltobottom-exempt-p nil) |
| 425 | 425 | ||
| 426 | (defun erc-fill--wrap-ensure-dependencies () | 426 | (defun erc-fill--wrap-ensure-dependencies () |
| 427 | (with-suppressed-warnings ((obsolete erc-legacy-invisible-bounds-p)) | 427 | (with-suppressed-warnings ((obsolete erc-legacy-invisible-bounds-p)) |
| @@ -435,7 +435,7 @@ is 0, reset to value of `erc-fill-wrap-visual-keys'." | |||
| 435 | (unless erc-fill-mode | 435 | (unless erc-fill-mode |
| 436 | (push 'fill missing-deps) | 436 | (push 'fill missing-deps) |
| 437 | (erc-fill-mode +1)) | 437 | (erc-fill-mode +1)) |
| 438 | (unless (or erc-scrolltobottom-mode erc--fill-wrap-scrolltobottom-exempt-p | 438 | (unless (or erc-scrolltobottom-mode erc-fill--wrap-scrolltobottom-exempt-p |
| 439 | (memq 'scrolltobottom erc-modules)) | 439 | (memq 'scrolltobottom erc-modules)) |
| 440 | (push 'scrolltobottom missing-deps) | 440 | (push 'scrolltobottom missing-deps) |
| 441 | (erc-scrolltobottom-mode +1)) | 441 | (erc-scrolltobottom-mode +1)) |
diff --git a/lisp/erc/erc-truncate.el b/lisp/erc/erc-truncate.el index 4b602074ebb..711a2988302 100644 --- a/lisp/erc/erc-truncate.el +++ b/lisp/erc/erc-truncate.el | |||
| @@ -38,7 +38,7 @@ | |||
| 38 | (defcustom erc-max-buffer-size 30000 | 38 | (defcustom erc-max-buffer-size 30000 |
| 39 | "Maximum size in chars of each ERC buffer. | 39 | "Maximum size in chars of each ERC buffer. |
| 40 | Used only when auto-truncation is enabled. | 40 | Used only when auto-truncation is enabled. |
| 41 | \(see `erc-truncate-buffer' and `erc-insert-post-hook')." | 41 | \(Also see `erc-truncate-buffer'.)" |
| 42 | :type 'integer) | 42 | :type 'integer) |
| 43 | 43 | ||
| 44 | ;;;###autoload(autoload 'erc-truncate-mode "erc-truncate" nil t) | 44 | ;;;###autoload(autoload 'erc-truncate-mode "erc-truncate" nil t) |
| @@ -92,10 +92,7 @@ present in `erc-modules'." | |||
| 92 | (error "erc-truncate-buffer-to-size: %S is not a buffer" buffer))) | 92 | (error "erc-truncate-buffer-to-size: %S is not a buffer" buffer))) |
| 93 | (when (> (buffer-size buffer) (+ size 512)) | 93 | (when (> (buffer-size buffer) (+ size 512)) |
| 94 | (with-current-buffer buffer | 94 | (with-current-buffer buffer |
| 95 | ;; Note that when erc-insert-post-hook runs, the buffer is | 95 | ;; Though unneeded, widen anyway to preserve pre-5.5 behavior. |
| 96 | ;; narrowed to the new message. So do this delicate widening. | ||
| 97 | ;; I am not sure, I think this was not recommended behavior in | ||
| 98 | ;; Emacs 20. | ||
| 99 | (save-restriction | 96 | (save-restriction |
| 100 | (widen) | 97 | (widen) |
| 101 | (let ((end (- erc-insert-marker size))) | 98 | (let ((end (- erc-insert-marker size))) |