Remove useless unwind-protect forms, or make them useful as intended

* lisp/imenu.el (imenu--generic-function):
* lisp/mail/yenc.el (yenc-decode-region):
* lisp/textmodes/table.el (table-recognize-region):
* test/lisp/dired-tests.el (dired-test-directory-files):
* test/lisp/hl-line-tests.el (hl-line-tests-sticky):
Fix unwind-protect bracketing mistakes that caused the unwind code to
be misplaced.
* lisp/strokes.el (strokes-read-stroke): Fix a bracketing mistake that
misplaced the unwind code, and another one that misplaced the
else-clause of an `if` form.
* test/lisp/gnus/mml-sec-tests.el (mml-secure-test-fixture): Fix a
bracketing mistake that misplaced the unwind code, and remove
superfluous condition-case.

* lisp/mwheel.el (mouse-wheel-global-text-scale):
* lisp/speedbar.el (speedbar-stealthy-updates)
(speedbar-fetch-dynamic-etags):
* lisp/emacs-lisp/edebug.el (edebug--recursive-edit):
* lisp/emacs-lisp/package.el (package--read-pkg-desc):
* lisp/cedet/semantic.el (semantic-refresh-tags-safe):
* lisp/emulation/viper-cmd.el (viper-escape-to-state):
* lisp/emulation/viper-cmd.el (viper-file-add-suffix):
* lisp/gnus/mail-source.el (mail-source-movemail):
* lisp/mail/feedmail.el (feedmail-send-it-immediately)
(feedmail-deduce-address-list):
* lisp/mail/mailclient.el (mailclient-send-it):
* lisp/mail/smtpmail.el (smtpmail-deduce-address-list):
* lisp/mh-e/mh-print.el (mh-ps-print-range):
* lisp/textmodes/reftex-index.el (reftex-index-this-phrase):
* test/lisp/emacs-lisp/ert-tests.el (ert-test-run-tests-batch):
(ert-test-run-tests-batch-expensive):
Remove unwind-protect forms that are apparently useless, some since a
prior edit that removed their purpose, some since their first
appearance.

* test/lisp/subr-tests.el (subr-test--frames-2):
Insert dummy unwind form in backtrace test code.

1 files changed, 16 insertions, 20 deletions

diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el
index 2a37c383f81..c0aa9dd7b46 100644
--- a/lisp/emulation/viper-cmd.el
+++ b/lisp/emulation/viper-cmd.el
@@ -722,16 +722,12 @@ Vi's prefix argument will be used.  Otherwise, the prefix argument passed to
         (let (viper-vi-kbd-minor-mode
               viper-insert-kbd-minor-mode
               viper-emacs-kbd-minor-mode)
-          (unwind-protect
-              (progn
-                (setq com
-                      (key-binding (setq key (read-key-sequence nil))))
-                ;; In case of binding indirection--chase definitions.
-                ;; Have to do it here because we execute this command under
-                ;; different keymaps, so command-execute may not do the
-                ;; right thing there
-                (while (vectorp com) (setq com (key-binding com))))
-            nil)
+          (setq com (key-binding (setq key (read-key-sequence nil))))
+          ;; In case of binding indirection--chase definitions.
+          ;; Have to do it here because we execute this command under
+          ;; different keymaps, so command-execute may not do the
+          ;; right thing there
+          (while (vectorp com) (setq com (key-binding com)))
           ;; Execute command com in the original Viper state, not in state
           ;; `state'.  Otherwise, if we switch buffers while executing the
           ;; escaped to command, Viper's mode vars will remain those of
@@ -1950,16 +1946,16 @@ To turn this feature off, set this variable to nil."
           (if found
               ()
             (viper-tmp-insert-at-eob " [Please complete file name]")
-            (unwind-protect
-                (while (not (memq cmd
-                                  '(exit-minibuffer viper-exit-minibuffer)))
-                  (setq cmd
-                        (key-binding (setq key (read-key-sequence nil))))
-                  (cond ((eq cmd 'self-insert-command)
-                         (insert key))
-                        ((memq cmd '(exit-minibuffer viper-exit-minibuffer))
-                         nil)
-                        (t (command-execute cmd))))))))))
+
+            (while (not (memq cmd
+                              '(exit-minibuffer viper-exit-minibuffer)))
+              (setq cmd
+                    (key-binding (setq key (read-key-sequence nil))))
+              (cond ((eq cmd 'self-insert-command)
+                     (insert key))
+                    ((memq cmd '(exit-minibuffer viper-exit-minibuffer))
+                     nil)
+                    (t (command-execute cmd)))))))))
 
 
 (defun viper-minibuffer-trim-tail ()