diff options
| author | Paul Eggert | 2017-06-22 11:21:20 -0700 |
|---|---|---|
| committer | Paul Eggert | 2017-06-22 11:22:53 -0700 |
| commit | f6ef15cf84c1288e972ef0e6165b97e34d6033b6 (patch) | |
| tree | 7f3fcd101a6c1a02965ebe6fd8dbf070f8340f53 /lib-src | |
| parent | 18896f79136bb7d6d4c0c6b1d066b4e82644db6a (diff) | |
| download | emacs-f6ef15cf84c1288e972ef0e6165b97e34d6033b6.tar.gz emacs-f6ef15cf84c1288e972ef0e6165b97e34d6033b6.zip | |
Use unlocked stdio more systematically
This can improve performance significantly on stdio-bottlenecked code.
E.g., make-docfile is 3x faster on my Fedora 25 x86-64 desktop.
* admin/merge-gnulib (GNULIB_MODULES): Add unlocked-io.
* lib-src/ebrowse.c, lib-src/emacsclient.c, lib-src/etags.c:
* lib-src/hexl.c, lib-src/make-docfile.c, lib-src/movemail.c:
* lib-src/profile.c, lib-src/update-game-score.c:
Include unlocked-io.h instead of stdio.h, since these programs are
single-threaded.
* lib/gnulib.mk.in, m4/gnulib-comp.m4: Regenerate.
* lib/unlocked-io.h, m4/unlocked-io.m4: New files, copied from Gnulib.
* src/charset.c, src/cm.c, src/emacs.c, src/image.c, src/keyboard.c:
* src/lread.c, src/term.c:
Include sysstdio.h, possibly instead of stdio.h, to define
the unlocked functions if the system does not provide them.
* src/charset.c, src/lread.c (getc_unlocked):
Remove, since sysstdio.h now defines it if needed.
* src/cm.c (cmputc, cmcheckmagic):
* src/dispnew.c (update_frame, update_frame_with_menu)
(update_frame_1, Fsend_string_to_terminal, Fding, bitch_at_user):
* src/emacs.c (main, Fdump_emacs):
* src/fileio.c (Fdo_auto_save, Fset_binary_mode):
* src/image.c (slurp_file, png_read_from_file, png_load_body)
(our_stdio_fill_input_buffer):
* src/keyboard.c (record_char, kbd_buffer_get_event, handle_interrupt):
* src/lread.c (readbyte_from_file):
* src/minibuf.c (read_minibuf_noninteractive):
* src/print.c (printchar_to_stream, strout)
(Fredirect_debugging_output):
* src/sysdep.c (reset_sys_modes, procfs_ttyname)
(procfs_get_total_memory):
* src/term.c (tty_ring_bell, tty_send_additional_strings)
(tty_set_terminal_modes, tty_reset_terminal_modes)
(tty_update_end, tty_clear_end_of_line, tty_write_glyphs)
(tty_write_glyphs_with_face, tty_insert_glyphs)
(tty_menu_activate):
* src/xfaces.c (Fx_load_color_file):
Use unlocked stdio when it should be safe.
* src/sysstdio.h (clearerr_unlocked, feof_unlocked, ferror_unlocked)
(fflush_unlocked, fgets_unlocked, fputc_unlocked, fputs_unlocked)
(fread_unlocked, fwrite_unlocked, getc_unlocked, getchar_unlocked)
(putc_unlocked, putchar_unloced): Provide substitutes if not declared.
Diffstat (limited to 'lib-src')
| -rw-r--r-- | lib-src/ebrowse.c | 8 | ||||
| -rw-r--r-- | lib-src/emacsclient.c | 3 | ||||
| -rw-r--r-- | lib-src/etags.c | 1 | ||||
| -rw-r--r-- | lib-src/hexl.c | 2 | ||||
| -rw-r--r-- | lib-src/make-docfile.c | 10 | ||||
| -rw-r--r-- | lib-src/movemail.c | 4 | ||||
| -rw-r--r-- | lib-src/profile.c | 2 | ||||
| -rw-r--r-- | lib-src/update-game-score.c | 3 |
8 files changed, 19 insertions, 14 deletions
diff --git a/lib-src/ebrowse.c b/lib-src/ebrowse.c index 51d181997b1..e77b7c94cca 100644 --- a/lib-src/ebrowse.c +++ b/lib-src/ebrowse.c | |||
| @@ -20,21 +20,21 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 20 | 20 | ||
| 21 | #include <config.h> | 21 | #include <config.h> |
| 22 | #include <stddef.h> | 22 | #include <stddef.h> |
| 23 | #include <stdio.h> | ||
| 24 | #include <stdlib.h> | 23 | #include <stdlib.h> |
| 25 | #include <string.h> | 24 | #include <string.h> |
| 26 | #include <ctype.h> | 25 | #include <ctype.h> |
| 27 | #include <assert.h> | 26 | #include <assert.h> |
| 28 | #include <getopt.h> | 27 | #include <getopt.h> |
| 29 | 28 | ||
| 29 | #include <flexmember.h> | ||
| 30 | #include <min-max.h> | ||
| 31 | #include <unlocked-io.h> | ||
| 32 | |||
| 30 | /* The SunOS compiler doesn't have SEEK_END. */ | 33 | /* The SunOS compiler doesn't have SEEK_END. */ |
| 31 | #ifndef SEEK_END | 34 | #ifndef SEEK_END |
| 32 | #define SEEK_END 2 | 35 | #define SEEK_END 2 |
| 33 | #endif | 36 | #endif |
| 34 | 37 | ||
| 35 | #include <flexmember.h> | ||
| 36 | #include <min-max.h> | ||
| 37 | |||
| 38 | /* Files are read in chunks of this number of bytes. */ | 38 | /* Files are read in chunks of this number of bytes. */ |
| 39 | 39 | ||
| 40 | enum { READ_CHUNK_SIZE = 100 * 1024 }; | 40 | enum { READ_CHUNK_SIZE = 100 * 1024 }; |
diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 8828b7652de..f1d4e8976da 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c | |||
| @@ -73,7 +73,6 @@ char *w32_getenv (const char *); | |||
| 73 | 73 | ||
| 74 | #include <stdarg.h> | 74 | #include <stdarg.h> |
| 75 | #include <ctype.h> | 75 | #include <ctype.h> |
| 76 | #include <stdio.h> | ||
| 77 | #include <stdlib.h> | 76 | #include <stdlib.h> |
| 78 | #include <string.h> | 77 | #include <string.h> |
| 79 | #include <getopt.h> | 78 | #include <getopt.h> |
| @@ -84,6 +83,8 @@ char *w32_getenv (const char *); | |||
| 84 | #include <signal.h> | 83 | #include <signal.h> |
| 85 | #include <errno.h> | 84 | #include <errno.h> |
| 86 | 85 | ||
| 86 | #include <unlocked-io.h> | ||
| 87 | |||
| 87 | #ifndef VERSION | 88 | #ifndef VERSION |
| 88 | #define VERSION "unspecified" | 89 | #define VERSION "unspecified" |
| 89 | #endif | 90 | #endif |
diff --git a/lib-src/etags.c b/lib-src/etags.c index 6f280d8ab40..e5ff7bd10fc 100644 --- a/lib-src/etags.c +++ b/lib-src/etags.c | |||
| @@ -123,6 +123,7 @@ char pot_etags_version[] = "@(#) pot revision number is 17.38.1.4"; | |||
| 123 | #include <errno.h> | 123 | #include <errno.h> |
| 124 | #include <fcntl.h> | 124 | #include <fcntl.h> |
| 125 | #include <binary-io.h> | 125 | #include <binary-io.h> |
| 126 | #include <unlocked-io.h> | ||
| 126 | #include <c-ctype.h> | 127 | #include <c-ctype.h> |
| 127 | #include <c-strcase.h> | 128 | #include <c-strcase.h> |
| 128 | 129 | ||
diff --git a/lib-src/hexl.c b/lib-src/hexl.c index 319ce8bc890..d949af08902 100644 --- a/lib-src/hexl.c +++ b/lib-src/hexl.c | |||
| @@ -22,11 +22,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 22 | #include <config.h> | 22 | #include <config.h> |
| 23 | 23 | ||
| 24 | #include <inttypes.h> | 24 | #include <inttypes.h> |
| 25 | #include <stdio.h> | ||
| 26 | #include <stdlib.h> | 25 | #include <stdlib.h> |
| 27 | #include <string.h> | 26 | #include <string.h> |
| 28 | 27 | ||
| 29 | #include <binary-io.h> | 28 | #include <binary-io.h> |
| 29 | #include <unlocked-io.h> | ||
| 30 | 30 | ||
| 31 | static char *progname; | 31 | static char *progname; |
| 32 | 32 | ||
diff --git a/lib-src/make-docfile.c b/lib-src/make-docfile.c index 9470bd635f5..6b2cc110403 100644 --- a/lib-src/make-docfile.c +++ b/lib-src/make-docfile.c | |||
| @@ -39,10 +39,14 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 39 | #include <stdarg.h> | 39 | #include <stdarg.h> |
| 40 | #include <stddef.h> | 40 | #include <stddef.h> |
| 41 | #include <stdint.h> | 41 | #include <stdint.h> |
| 42 | #include <stdio.h> | ||
| 43 | #include <stdlib.h> | 42 | #include <stdlib.h> |
| 44 | #include <string.h> | 43 | #include <string.h> |
| 45 | 44 | ||
| 45 | #include <binary-io.h> | ||
| 46 | #include <intprops.h> | ||
| 47 | #include <min-max.h> | ||
| 48 | #include <unlocked-io.h> | ||
| 49 | |||
| 46 | #ifdef WINDOWSNT | 50 | #ifdef WINDOWSNT |
| 47 | /* Defined to be sys_fopen in ms-w32.h, but only #ifdef emacs, so this | 51 | /* Defined to be sys_fopen in ms-w32.h, but only #ifdef emacs, so this |
| 48 | is really just insurance. */ | 52 | is really just insurance. */ |
| @@ -50,10 +54,6 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 50 | #include <direct.h> | 54 | #include <direct.h> |
| 51 | #endif /* WINDOWSNT */ | 55 | #endif /* WINDOWSNT */ |
| 52 | 56 | ||
| 53 | #include <binary-io.h> | ||
| 54 | #include <intprops.h> | ||
| 55 | #include <min-max.h> | ||
| 56 | |||
| 57 | #ifdef DOS_NT | 57 | #ifdef DOS_NT |
| 58 | /* Defined to be sys_chdir in ms-w32.h, but only #ifdef emacs, so this | 58 | /* Defined to be sys_chdir in ms-w32.h, but only #ifdef emacs, so this |
| 59 | is really just insurance. | 59 | is really just insurance. |
diff --git a/lib-src/movemail.c b/lib-src/movemail.c index cd12c48ed36..e5ca0b16611 100644 --- a/lib-src/movemail.c +++ b/lib-src/movemail.c | |||
| @@ -59,7 +59,6 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 59 | #include <sys/types.h> | 59 | #include <sys/types.h> |
| 60 | #include <sys/stat.h> | 60 | #include <sys/stat.h> |
| 61 | #include <sys/file.h> | 61 | #include <sys/file.h> |
| 62 | #include <stdio.h> | ||
| 63 | #include <stdlib.h> | 62 | #include <stdlib.h> |
| 64 | #include <errno.h> | 63 | #include <errno.h> |
| 65 | #include <time.h> | 64 | #include <time.h> |
| @@ -69,6 +68,9 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 69 | #include <fcntl.h> | 68 | #include <fcntl.h> |
| 70 | #include <signal.h> | 69 | #include <signal.h> |
| 71 | #include <string.h> | 70 | #include <string.h> |
| 71 | |||
| 72 | #include <unlocked-io.h> | ||
| 73 | |||
| 72 | #include "syswait.h" | 74 | #include "syswait.h" |
| 73 | #ifdef MAIL_USE_POP | 75 | #ifdef MAIL_USE_POP |
| 74 | #include "pop.h" | 76 | #include "pop.h" |
diff --git a/lib-src/profile.c b/lib-src/profile.c index 253f00e2d80..f4ab45c1718 100644 --- a/lib-src/profile.c +++ b/lib-src/profile.c | |||
| @@ -34,11 +34,11 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 34 | #include <config.h> | 34 | #include <config.h> |
| 35 | 35 | ||
| 36 | #include <inttypes.h> | 36 | #include <inttypes.h> |
| 37 | #include <stdio.h> | ||
| 38 | #include <stdlib.h> | 37 | #include <stdlib.h> |
| 39 | 38 | ||
| 40 | #include <intprops.h> | 39 | #include <intprops.h> |
| 41 | #include <systime.h> | 40 | #include <systime.h> |
| 41 | #include <unlocked-io.h> | ||
| 42 | 42 | ||
| 43 | static struct timespec TV1; | 43 | static struct timespec TV1; |
| 44 | static int watch_not_started = 1; /* flag */ | 44 | static int watch_not_started = 1; /* flag */ |
diff --git a/lib-src/update-game-score.c b/lib-src/update-game-score.c index 5edc8e79569..942aeeb399d 100644 --- a/lib-src/update-game-score.c +++ b/lib-src/update-game-score.c | |||
| @@ -39,7 +39,6 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 39 | #include <limits.h> | 39 | #include <limits.h> |
| 40 | #include <string.h> | 40 | #include <string.h> |
| 41 | #include <stdlib.h> | 41 | #include <stdlib.h> |
| 42 | #include <stdio.h> | ||
| 43 | #include <time.h> | 42 | #include <time.h> |
| 44 | #include <pwd.h> | 43 | #include <pwd.h> |
| 45 | #include <ctype.h> | 44 | #include <ctype.h> |
| @@ -47,6 +46,8 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */ | |||
| 47 | #include <sys/stat.h> | 46 | #include <sys/stat.h> |
| 48 | #include <getopt.h> | 47 | #include <getopt.h> |
| 49 | 48 | ||
| 49 | #include <unlocked-io.h> | ||
| 50 | |||
| 50 | #ifdef WINDOWSNT | 51 | #ifdef WINDOWSNT |
| 51 | #include "ntlib.h" | 52 | #include "ntlib.h" |
| 52 | #endif | 53 | #endif |