diff options
| author | Paul Eggert | 2011-02-25 15:35:16 -0800 |
|---|---|---|
| committer | Paul Eggert | 2011-02-25 15:35:16 -0800 |
| commit | b0bbc07d9a136869d1d9acfdd8e14674515eb196 (patch) | |
| tree | 0cced855adde9a06c88e52392d5fe8829a5d3814 /lib-src | |
| parent | 3f5e6230d78d28cd4acba7a7eaa2292477f4e0ff (diff) | |
| download | emacs-b0bbc07d9a136869d1d9acfdd8e14674515eb196.tar.gz emacs-b0bbc07d9a136869d1d9acfdd8e14674515eb196.zip | |
* emacsclient.c: Redo local variables to avoid shadowing problems.
(message, socket_status, start_daemon_and_retry_set_socket):
Rename locals.
(main): Move decl of "i".
Diffstat (limited to 'lib-src')
| -rw-r--r-- | lib-src/ChangeLog | 5 | ||||
| -rw-r--r-- | lib-src/emacsclient.c | 17 |
2 files changed, 14 insertions, 8 deletions
diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog index cbaa5559f96..5b8033d2aec 100644 --- a/lib-src/ChangeLog +++ b/lib-src/ChangeLog | |||
| @@ -1,5 +1,10 @@ | |||
| 1 | 2011-02-25 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-02-25 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * emacsclient.c: Redo local variables to avoid shadowing problems. | ||
| 4 | (message, socket_status, start_daemon_and_retry_set_socket): | ||
| 5 | Rename locals. | ||
| 6 | (main): Move decl of "i". | ||
| 7 | |||
| 3 | * etags.c (ISUPPER): Move to inside the only #ifdef where it's used. | 8 | * etags.c (ISUPPER): Move to inside the only #ifdef where it's used. |
| 4 | This avoids an unused-macro warning with some GCC settings. | 9 | This avoids an unused-macro warning with some GCC settings. |
| 5 | 10 | ||
diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 8d5f0482637..070d6370714 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c | |||
| @@ -474,13 +474,13 @@ ttyname (int fd) | |||
| 474 | /* Display a normal or error message. | 474 | /* Display a normal or error message. |
| 475 | On Windows, use a message box if compiled as a Windows app. */ | 475 | On Windows, use a message box if compiled as a Windows app. */ |
| 476 | static void | 476 | static void |
| 477 | message (int is_error, const char *message, ...) | 477 | message (int is_error, const char *format, ...) |
| 478 | { | 478 | { |
| 479 | char msg[2048]; | 479 | char msg[2048]; |
| 480 | va_list args; | 480 | va_list args; |
| 481 | 481 | ||
| 482 | va_start (args, message); | 482 | va_start (args, format); |
| 483 | vsprintf (msg, message, args); | 483 | vsprintf (msg, format, args); |
| 484 | va_end (args); | 484 | va_end (args); |
| 485 | 485 | ||
| 486 | #ifdef WINDOWSNT | 486 | #ifdef WINDOWSNT |
| @@ -1080,11 +1080,11 @@ find_tty (char **tty_type, char **tty_name, int noabort) | |||
| 1080 | 0 - success: none of the above */ | 1080 | 0 - success: none of the above */ |
| 1081 | 1081 | ||
| 1082 | static int | 1082 | static int |
| 1083 | socket_status (char *socket_name) | 1083 | socket_status (char *name) |
| 1084 | { | 1084 | { |
| 1085 | struct stat statbfr; | 1085 | struct stat statbfr; |
| 1086 | 1086 | ||
| 1087 | if (stat (socket_name, &statbfr) == -1) | 1087 | if (stat (name, &statbfr) == -1) |
| 1088 | return 2; | 1088 | return 2; |
| 1089 | 1089 | ||
| 1090 | if (statbfr.st_uid != geteuid ()) | 1090 | if (statbfr.st_uid != geteuid ()) |
| @@ -1483,8 +1483,8 @@ start_daemon_and_retry_set_socket (void) | |||
| 1483 | else | 1483 | else |
| 1484 | { | 1484 | { |
| 1485 | char emacs[] = "emacs"; | 1485 | char emacs[] = "emacs"; |
| 1486 | char daemon[] = "--daemon"; | 1486 | char daemon_option[] = "--daemon"; |
| 1487 | char *d_argv[] = {emacs, daemon, 0 }; | 1487 | char *d_argv[] = {emacs, daemon_option, 0 }; |
| 1488 | if (socket_name != NULL) | 1488 | if (socket_name != NULL) |
| 1489 | { | 1489 | { |
| 1490 | /* Pass --daemon=socket_name as argument. */ | 1490 | /* Pass --daemon=socket_name as argument. */ |
| @@ -1504,7 +1504,7 @@ start_daemon_and_retry_set_socket (void) | |||
| 1504 | int | 1504 | int |
| 1505 | main (int argc, char **argv) | 1505 | main (int argc, char **argv) |
| 1506 | { | 1506 | { |
| 1507 | int i, rl, needlf = 0; | 1507 | int rl, needlf = 0; |
| 1508 | char *cwd, *str; | 1508 | char *cwd, *str; |
| 1509 | char string[BUFSIZ+1]; | 1509 | char string[BUFSIZ+1]; |
| 1510 | int null_socket_name, null_server_file, start_daemon_if_needed; | 1510 | int null_socket_name, null_server_file, start_daemon_if_needed; |
| @@ -1635,6 +1635,7 @@ main (int argc, char **argv) | |||
| 1635 | 1635 | ||
| 1636 | if ((argc - optind > 0)) | 1636 | if ((argc - optind > 0)) |
| 1637 | { | 1637 | { |
| 1638 | int i; | ||
| 1638 | for (i = optind; i < argc; i++) | 1639 | for (i = optind; i < argc; i++) |
| 1639 | { | 1640 | { |
| 1640 | 1641 | ||