diff options
| author | Paul Eggert | 2011-02-21 10:22:20 -0800 |
|---|---|---|
| committer | Paul Eggert | 2011-02-21 10:22:20 -0800 |
| commit | 27d41fb4a9af23628a0d78cf843df12f3797896d (patch) | |
| tree | 6b73ebbaed5a498b10c49b052bd46e4fd092c1ed /lib-src | |
| parent | b23b5a5b7dca39b708015979ed8c25901390ac14 (diff) | |
| download | emacs-27d41fb4a9af23628a0d78cf843df12f3797896d.tar.gz emacs-27d41fb4a9af23628a0d78cf843df12f3797896d.zip | |
* movemail.c (main, pop_retr): Rename locals to avoid shadowing.
Diffstat (limited to 'lib-src')
| -rw-r--r-- | lib-src/ChangeLog | 2 | ||||
| -rw-r--r-- | lib-src/movemail.c | 22 |
2 files changed, 13 insertions, 11 deletions
diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog index 698e7b60a7a..f2e55c3e0c0 100644 --- a/lib-src/ChangeLog +++ b/lib-src/ChangeLog | |||
| @@ -1,5 +1,7 @@ | |||
| 1 | 2011-02-21 Paul Eggert <eggert@cs.ucla.edu> | 1 | 2011-02-21 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 2 | ||
| 3 | * movemail.c (main, pop_retr): Rename locals to avoid shadowing. | ||
| 4 | |||
| 3 | Declare file-scope functions and variables static if not exported. | 5 | Declare file-scope functions and variables static if not exported. |
| 4 | This is more consistent, and is nicer with gcc -Wstrict-prototypes. | 6 | This is more consistent, and is nicer with gcc -Wstrict-prototypes. |
| 5 | * ebrowse.c, emacsclient.c, fakemail.c, make-docfile.c, movemail.c: | 7 | * ebrowse.c, emacsclient.c, fakemail.c, make-docfile.c, movemail.c: |
diff --git a/lib-src/movemail.c b/lib-src/movemail.c index a63e858613c..65675f24b9f 100644 --- a/lib-src/movemail.c +++ b/lib-src/movemail.c | |||
| @@ -169,7 +169,7 @@ main (int argc, char **argv) | |||
| 169 | char *inname, *outname; | 169 | char *inname, *outname; |
| 170 | int indesc, outdesc; | 170 | int indesc, outdesc; |
| 171 | ssize_t nread; | 171 | ssize_t nread; |
| 172 | int status; | 172 | int wait_status; |
| 173 | int c, preserve_mail = 0; | 173 | int c, preserve_mail = 0; |
| 174 | 174 | ||
| 175 | #ifndef MAIL_USE_SYSTEM_LOCK | 175 | #ifndef MAIL_USE_SYSTEM_LOCK |
| @@ -527,11 +527,11 @@ main (int argc, char **argv) | |||
| 527 | exit (EXIT_SUCCESS); | 527 | exit (EXIT_SUCCESS); |
| 528 | } | 528 | } |
| 529 | 529 | ||
| 530 | wait (&status); | 530 | wait (&wait_status); |
| 531 | if (!WIFEXITED (status)) | 531 | if (!WIFEXITED (wait_status)) |
| 532 | exit (EXIT_FAILURE); | 532 | exit (EXIT_FAILURE); |
| 533 | else if (WRETCODE (status) != 0) | 533 | else if (WRETCODE (wait_status) != 0) |
| 534 | exit (WRETCODE (status)); | 534 | exit (WRETCODE (wait_status)); |
| 535 | 535 | ||
| 536 | #if !defined (MAIL_USE_MMDF) && !defined (MAIL_USE_SYSTEM_LOCK) | 536 | #if !defined (MAIL_USE_MMDF) && !defined (MAIL_USE_SYSTEM_LOCK) |
| 537 | #ifdef MAIL_USE_MAILLOCK | 537 | #ifdef MAIL_USE_MAILLOCK |
| @@ -828,10 +828,10 @@ pop_retr (popserver server, int msgno, FILE *arg) | |||
| 828 | 828 | ||
| 829 | if (pop_retrieve_first (server, msgno, &line)) | 829 | if (pop_retrieve_first (server, msgno, &line)) |
| 830 | { | 830 | { |
| 831 | char *error = concat ("Error from POP server: ", pop_error, ""); | 831 | char *msg = concat ("Error from POP server: ", pop_error, ""); |
| 832 | strncpy (Errmsg, error, sizeof (Errmsg)); | 832 | strncpy (Errmsg, msg, sizeof (Errmsg)); |
| 833 | Errmsg[sizeof (Errmsg)-1] = '\0'; | 833 | Errmsg[sizeof (Errmsg)-1] = '\0'; |
| 834 | free(error); | 834 | free (msg); |
| 835 | return (NOTOK); | 835 | return (NOTOK); |
| 836 | } | 836 | } |
| 837 | 837 | ||
| @@ -850,10 +850,10 @@ pop_retr (popserver server, int msgno, FILE *arg) | |||
| 850 | 850 | ||
| 851 | if (ret) | 851 | if (ret) |
| 852 | { | 852 | { |
| 853 | char *error = concat ("Error from POP server: ", pop_error, ""); | 853 | char *msg = concat ("Error from POP server: ", pop_error, ""); |
| 854 | strncpy (Errmsg, error, sizeof (Errmsg)); | 854 | strncpy (Errmsg, msg, sizeof (Errmsg)); |
| 855 | Errmsg[sizeof (Errmsg)-1] = '\0'; | 855 | Errmsg[sizeof (Errmsg)-1] = '\0'; |
| 856 | free(error); | 856 | free (msg); |
| 857 | return (NOTOK); | 857 | return (NOTOK); |
| 858 | } | 858 | } |
| 859 | 859 | ||