diff options
| author | Paul Eggert | 2016-09-30 12:14:04 -0700 |
|---|---|---|
| committer | Paul Eggert | 2016-09-30 12:38:52 -0700 |
| commit | f4eb8900295d75c4afec256f75aea22494376fde (patch) | |
| tree | 70203645e9b0b603ef8dbca6c50c01795a081512 /lib-src/pop.c | |
| parent | d1890a3a4a18f79cabf4caf8d194cdc29ea4bf05 (diff) | |
| download | emacs-f4eb8900295d75c4afec256f75aea22494376fde.tar.gz emacs-f4eb8900295d75c4afec256f75aea22494376fde.zip | |
Limit <config.h>’s includes
This follows up on recent problems with the fact that config.h
includes stdlib.h etc.; some files need to include stdlib.h later.
config.h generally should limit itself to includes that are
universally safe; outside of MS-Windows, only stdbool.h makes
the cut among the files currently included. So, move the
other includes to just the files that need them (Bug#24506).
* configure.ac (config_opsysfile): Remove, as this generic hook
is no longer needed.
* lib-src/etags.c, src/unexmacosx.c, src/w32.c, src/w32notify.c:
* src/w32proc.c (_GNU_SOURCE):
Remove, as it’s OK for config.h to do this now.
* src/conf_post.h: Include <ms-w32.h>, instead of the generic
config_opsysfile, for simplicity as this old way of configuring is
now done only for the MS-Windows port. Do not include <ms-w32.h>
if DEFER_MS_W32_H, for the benefit of the few files that want its
effects later. Do not include <alloca.h>, <string.h>, or
<stdlib.h>. Other files modified to include these headers as
needed, or to not include headers that are no longer needed.
* src/lisp.h: Include <alloca.h> and <string.h> here, since
some of the inline functions need them.
* src/regex.c: Include <alloca.h> if not emacs. (If emacs,
we can rely on SAFE_ALLOCA.) There is no longer any need to
worry about HAVE_ALLOCA_H.
* src/unexmacosx.c: Rely on config.h not including stdlib.h.
* src/w32.c, src/w32notify.c, src/w32proc.c (DEFER_MS_W32_H):
Define before including <config.h> first, and include <ms-w32.h>
after the troublesome headers.
Diffstat (limited to 'lib-src/pop.c')
| -rw-r--r-- | lib-src/pop.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib-src/pop.c b/lib-src/pop.c index 99ec1cf824a..99424c584c2 100644 --- a/lib-src/pop.c +++ b/lib-src/pop.c | |||
| @@ -63,10 +63,12 @@ void sys_freeaddrinfo (struct addrinfo * ai); | |||
| 63 | extern struct servent *hes_getservbyname (/* char *, char * */); | 63 | extern struct servent *hes_getservbyname (/* char *, char * */); |
| 64 | #endif | 64 | #endif |
| 65 | 65 | ||
| 66 | #include <alloca.h> | ||
| 66 | #include <pwd.h> | 67 | #include <pwd.h> |
| 67 | #include <netdb.h> | 68 | #include <netdb.h> |
| 68 | #include <errno.h> | 69 | #include <errno.h> |
| 69 | #include <stdio.h> | 70 | #include <stdio.h> |
| 71 | #include <stdlib.h> | ||
| 70 | #include <string.h> | 72 | #include <string.h> |
| 71 | #include <unistd.h> | 73 | #include <unistd.h> |
| 72 | 74 | ||