merge from upstream

1 files changed, 389 insertions, 104 deletions

diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog
index 3f4e4b1b9ff..ec123e85036 100644
--- a/lib-src/ChangeLog
+++ b/lib-src/ChangeLog
@@ -1,13 +1,298 @@
+2011-06-10  Paul Eggert  <eggert@cs.ucla.edu>
+
+        * movemail.c: Fix race condition and related bugs (Bug#8836).
+        (main) [!MAIL_USE_SYSTEM_LOCK]: Prefer mkstemp to mktemp, as this
+        fixes some race conditions.  Report mkstemp/mktemp errno rather
+        than a possibly-garbage errno.  Reinitialize the template each
+        time through the loop, as earlier mkstemp/mktemp calls could have
+        trashed it.  Pass 0600 (not 0666) to mktemp, for consistency
+        with mkstemp; the permissions don't matter anyway.
+
+2011-06-01  Dan Nicolaescu  <dann@ics.uci.edu>
+
+        * emacsclient.c (socket_status): Use constant pointer.
+
+2011-05-28  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Use 'inline', not 'INLINE'.
+        * etags.c (hash): Now inline unconditionally.
+        * make-docfile.c (put_char): inline, not INLINE.
+
+2011-05-25  Glenn Morris  <rgm@gnu.org>
+
+        * Makefile.in (.c.o): Remove (every .o file has an explicit rule).
+        (insrcdir): New.
+        (stamp-rcs2log, stamp-rcs-checkin, stamp-grep-changelog, stamp-vcdiff):
+        Use $insrcdir to suppress unaesthetic ignored errors.
+        (clean): Simplify list of things to delete.
+        (all, clean): Use $EXE_FILES.
+
+        * Makefile.in (movemail${EXEEXT}): Build in one step, not via .o file.
+
+        * Makefile.in (REGEXPOBJ, REGEXPDEPS): Remove.  Replace by expansion.
+        (etags${EXEEXT}): Just depend on regex.o, not regex.h as well.
+
+2011-05-24  Glenn Morris  <rgm@gnu.org>
+
+        * Makefile.in (update-game-score${EXEEXT}): Use a single rule.
+
+2011-05-19  Glenn Morris  <rgm@gnu.org>
+
+        * makefile.w32-in (echolisp): Remove rule that is no longer needed.
+        (clean): No more echolisp.tmp.
+
+2011-05-18  Glenn Morris  <rgm@gnu.org>
+
+        * fakemail.c: Remove file.
+        * makefile.w32-in ($(BLD)/fakemail.exe, fakemail)
+        ($(BLD)/fakemail.$(O)): Remove.
+        * Makefile.in (UTILITIES): Remove fakemail${EXEEXT}.
+        (fakemail${EXEEXT}): Remove rule.
+
+2011-04-24  Teodor Zlatanov  <tzz@lifelogs.com>
+
+        * makefile.w32-in (obj): Add gnutls.o.
+
+2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Static checks with GCC 4.6.0 and non-default toolkits.
+
+        * movemail.c (mail_spool_name): Protoize.
+        (main): Remove unused var.  Mark var as initialized.
+        Move locals to avoid shadowing, and use time_t for times.
+
+        * fakemail.c (xmalloc, xreallc): Use standard C prototypes
+        with void *.  This avoids warnings about pointer casts.
+
+        * emacsclient.c (main): Don't use uninitialized var.
+        (IS_ANY_SEP): Remove; unused.
+        (get_current_dir_name): Add an extern decl.
+
+2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Fix more problems found by GCC 4.6.0's static checks.
+
+        * emacsclient.c (message): Mark it as a printf-like function.
+
+        * make-docfile.c (IF_LINT): New macro, copied from emacsclient.c.
+        (write_c_args): Use it to suppress GCC warning.
+
+2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Fix a problem found by GCC 4.6.0's static checks.
+        * etags.c (just_read_file): Remove dummy variable and simplify.
+
+2011-03-27  Glenn Morris  <rgm@gnu.org>
+
+        * emacsclient.c: Replace SIGTYPE with void.
+
+2011-03-23  Juanma Barranquero  <lekktu@gmail.com>
+
+        * ntlib.c: Include <ctype.h>.
+
+2011-03-23  Glenn Morris  <rgm@gnu.org>
+
+        * Makefile.in ($(DESTDIR)${archlibdir}):
+        Use `install-sh -d' rather than mkinstalldirs.
+
+2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>
+
+        * ebrowse.c: Use size_t, not int, for sizes.
+        This avoids a warning with gcc -Wstrict-overflow, and works
+        better for very large objects.
+        (inbuffer_size): Now size_t.  All uses changed.
+        (xmalloc, xrealloc, operator_name, process_file): Use size_t for
+        sizes.  Don't bother testing whether a size_t value can be negative.
+
+        * etags.c (Ada_funcs): Redo slightly to avoid overflow warning.
+
+        etags: In Prolog functions, don't assume int fits in size_t.
+        This avoids a warning with gcc -Wstrict-overflow.
+        * etags.c (Prolog_functions, prolog_pr, prolog_atom): Use size_t,
+        not int, to store sizes.
+        (prolog_atom): Return 0, not -1, on error.  All callers changed.
+
+        update-game-score: fix bug with -r
+        * update-game-score.c (main): Don't set 'scores' to garbage when
+        -r is specified and scorecount != MAX_SCORES (Bug#8310).  This bug
+        was introduced in the 2002-04-10 change, and was found with gcc
+        -Wstrict-overflow (GCC 4.5.2, x86-64).
+
+        fakemail: Remove dependency on ignore-value.
+        This undoes some of the recent fakemail-related changes.
+        It is made possible due to recent changes to gnulib's stdio module.
+        * Makefile.in (fakemail${EXEEXT}): Do not depend on ignore-value.h.
+        * fakemail.c: Do not include ignore-value.h.
+        (put_line): Do not use ignore_value.
+
+2011-03-07  Chong Yidong  <cyd@stupidchicken.com>
+
+        * Version 23.3 released.
+
+2011-03-03  Drake Wilson  <drake@begriffli.ch>  (tiny change)
+
+        * emacsclient.c (longopts): Add quiet.
+        (decode_options): Handle q/quiet.
+        (print_help_and_exit): Add q/quiet.
+        (main): Suppress some messages if quiet option is used.
+
+2011-02-26  Eli Zaretskii  <eliz@gnu.org>
+
+        * Makefile.in (fakemail${EXEEXT}): Depend on lib/ignore-value.h.
+
+        * emacsclient.c (xstrdup) [WINDOWSNT]: Function added back.
+        (w32_getenv): Use xstrdup to return all values in malloc'ed
+        storage.
+
+2011-02-26  Paul Eggert  <eggert@cs.ucla.edu>
+
+        * ebrowse.c (parse_qualified_param_ident_or_type): Make it clear
+        to reader (and to the compiler) that the loop always executes at
+        least once.  This prevents a warning with recent GCC.
+        (BROWSE_STRUCT): Remove unused macro.
+
+        * fakemail.c: Include <ignore-value.h>.
+        (put_line): Explicitly ignore fwrite return value, for benefit of
+        recent glibc + gcc.
+        (close_the_streams): Diagnose output errors instead of merely
+        exiting with nonzero status.
+        (my_fclose, main): Diagnose input errors, and exit with nonzero status.
+        Formerly, input errors were silently ignored.
+
+        * ebrowse.c (putstr): Rename from PUTSTR and turn into a function.
+        All callers changed.  This is cleaner, and avoids GCC warnings about
+        passing NULL to fputs.
+        (insert_keyword): Rename parameter to avoid shadowing diagnostic.
+
+2011-02-25  Paul Eggert  <eggert@cs.ucla.edu>
+
+        * emacsclient.c (main): Avoid dangling 'if'.
+        (xstrdup): Remove; no longer needed.
+        (get_current_dir_name, w32_getenv, get_server_config, find_tty):
+        (set_local_socket, main):
+        Use const char *, not char *, for pointers that are not assigned
+        through.
+        (IF_LINT): New macro.
+        (set_local_socket, main): Use it to suppress warnings with
+        GCC -Wuninitialized.
+
+        * emacsclient.c: Redo local variables to avoid shadowing problems.
+        (message, socket_status, start_daemon_and_retry_set_socket):
+        Rename locals.
+        (main): Move decl of "i".
+
+        * etags.c (ISUPPER): Move to inside the only #ifdef where it's used.
+        This avoids an unused-macro warning with some GCC settings.
+
+        * make-docfile.c (write_globals): Change char * to char const *
+        to avoid a GCC "assignment discards qualifiers" diagnostic
+        in some configurations.
+        (scan_c_file): Refactor local variable decls to make their scope
+        more accurate and to avoid a GCC -Wuninitialized diagnostic.
+
+2011-02-22  Eli Zaretskii  <eliz@gnu.org>
+
+        * etags.c (canonicalize_filename, ISUPPER): Fix last change.
+
+        * makefile.w32-in ($(BLD)/ebrowse.$(O), $(BLD)/pop.$(O)): Depend
+        on ../lib/min-max.h.
+
+2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>
+
+        etags: Downcase drive letters, for consistency with Emacs proper.
+        * etags.c (upcase): Remove; no longer used.
+        (canonicalize_filename): Downcase drive letters.
+
+        Assume S_ISLNK etc. work, since gnulib supports this.
+        * etags.c (S_ISREG): Remove.
+
+2011-02-22  Paul Eggert  <eggert@cs.ucla.edu>
+
+        Assume S_ISLNK etc. work, since gnulib supports this.
+        * etags.c (S_ISREG): Remove.
+
+2011-02-22  Juanma Barranquero  <lekktu@gmail.com>
+
+        * makefile.w32-in (obj): Remove filemode.o.
+
+2011-02-21  Paul Eggert  <eggert@cs.ucla.edu>
+
+        New file "lib/min-max.h".
+        * ebrowse.c (min, max): Define them by including <min-max.h>
+        instead of defining it ourselves.
+        * pop.c (min): Likewise.
+        * Makefile.in (ebrowse${EXEEXT}, pop.o): Depend on min-max.h.
+
+        * movemail.c (popmail): Report fchown failure instead of ignoring it.
+        But if the file already has the right ownership, don't worry about it.
+
+        * make-docfile.c (input_buffer): Rename variables to avoid shadowing.
+        * test-distrib.c (buf): Make this local, to avoid shadowing.
+
+        * movemail.c (main, pop_retr): Rename locals to avoid shadowing.
+        (progname, sfi, sfo, ibuffer, obuffer): Remove unused vars.
+        (DONE): Remove unused macro.
+        (DIRECTORY_SEP, IS_DIRECTORY_SEP, IS_FROM_LINE):
+        Define these macros only in the contexts that need them.
+        * pop.c (index): Remove unused macro.
+        (KPOP_PORT): Define only if KERBEROS is defined.
+
+        Declare file-scope functions and variables static if not exported.
+        This is more consistent, and is nicer with gcc -Wstrict-prototypes.
+        * ebrowse.c, emacsclient.c, fakemail.c, make-docfile.c, movemail.c:
+        * profile.c, test-distrib.c, update-game-score.c:
+        Declare non-'main' functions and variables to be static.
+        * ebrowse.c: Omit redundant function prototypes.
+
+2011-02-21  Eli Zaretskii  <eliz@gnu.org>
+
+        * makefile.w32-in ($(BLD)/ctags.$(O), $(BLD)/emacsclient.$(O))
+        ($(BLD)/etags.$(O), $(BLD)/movemail.$(O), $(BLD)/ntlib.$(O)):
+        Depend on $(EMACS_ROOT)/nt/inc/sys/stat.h.
+
+2011-02-21  Ben Key  <bkey76@gmail.com>
+
+        * make-docfile.c (scan_c_file): Adapt DEFVAR_PER_BUFFER case to
+        the new BVAR macro.
+
+2011-02-20  Juanma Barranquero  <lekktu@gmail.com>
+
+        * makefile.w32-in (obj): Remove md5.o.
+
+2011-02-18  Karl Chen  <Karl.Chen@quarl.org>
+
+        * emacsclient.c (main): Loop while `recv' return EINTR.
+
+2011-02-09  Paul Eggert  <eggert@cs.ucla.edu>
+
+        * make-docfile.c (EMACS_INTEGER): Rename from EMACS_INT.
+        This avoids collision with config.h's EMACS_INT on some
+        configurations.  All uses changed.
+
+2011-02-08  Tom Tromey  <tromey@redhat.com>
+
+        * make-docfile.c: Unconditionally include stdlib.h.
+        (generate_globals): New global.
+        (xrealloc): New function.
+        (main): Handle '-g'.  Call start_globals, write_globals.
+        (scan_file): Conditionally call put_filename.
+        (start_globals): New function.
+        (struct global): New.
+        (num_globals, globals): New globals.
+        (add_global, compare_globals, write_globals): New functions.
+        (scan_c_file): Update for "-g".
+        (scan_lisp_file): Fail if "-g".
+
 2011-02-05  Paul Eggert  <eggert@cs.ucla.edu>
 
-        * emacsclient.c: conform to C89 pointer rules
+        * emacsclient.c: Conform to C89 pointer rules.
         (file_name_absolute_p): Accept const char *, not const unsigned
         char *, to satisfy C89 rules.
 
 2011-02-02  Eli Zaretskii  <eliz@gnu.org>
 
-        * makefile.w32-in (ETAGS_CFLAGS, CTAGS_CFLAGS): Add
-        ``-DEMACS_NAME="\"GNU Emacs\""''.
+        * makefile.w32-in (ETAGS_CFLAGS, CTAGS_CFLAGS):
+        Add ``-DEMACS_NAME="\"GNU Emacs\""''.
         (obj): Remove strftime.o.
 
 2011-01-31  Eli Zaretskii  <eliz@gnu.org>
@@ -158,7 +443,7 @@
         * test-distrib.c (cool_read):
         * movemail.c (main, concat):
         * make-docfile.c (scan_file, write_c_args):
-        * emacsclient.c (get_server_config): Fix -Wconversion warning.
+        * emacsclient.c (get_server_config): Fix -Wconversion warning.
         (egetenv): Move conditional definition earlier.
         (progname): Use const.
         * sorted-doc.c (xstrdup): Use const.
@@ -212,8 +497,8 @@
 
         * movemail.c (fatal, error, concat): Use const char *.
 
-        * make-docfile.c (error, fatal, scan_c_file, scan_lisp_file): Use
-        const char *.
+        * make-docfile.c (error, fatal, scan_c_file, scan_lisp_file):
+        Use const char *.
 
         * etags.c (compressor, language, Ada_suffix, Ada_help, Asm_suffixes)
         (Asm_help, default_C_suffixes, default_C_help, Cplusplus_suffixes)
@@ -518,7 +803,7 @@
         autoconf, not cpp.
         (ALL_CFLAGS): Use them as make variables.
 
-2010-04-07  Christoph  <cschol2112@googlemail.com>  (tiny change)
+2010-04-07  Christoph Scholtes  <cschol2112@googlemail.com>
 
         * makefile.w32-in (OTHER_PLATFORM_SUPPORT): Use parenthesis
         for macros for nmake compatibility.
@@ -531,8 +816,8 @@
 
 2010-04-02  Dan Rosenberg  <dan.j.rosenberg@gmail.com>  (tiny change)
 
-        * movemail.c (main): Check return values of setuid.  Avoid
-        possibility of symlink attack when movemail is setgid mail
+        * movemail.c (main): Check return values of setuid.
+        Avoid possibility of symlink attack when movemail is setgid mail
         (CVE-2010-0825).
 
 2010-04-02  Dan Nicolaescu  <dann@ics.uci.edu>
@@ -2238,7 +2523,7 @@
         (wchar.h): Include, maybe.
         (attribute_hidden): Define if not defined.
         (__getopt_initialized): Use attribute_hidden.
-        (__libc_argc, __libc_argv): Renamed from original_argc, etc.
+        (__libc_argc, __libc_argv): Rename from original_argc, etc.
         (__getopt_nonoption_flags, nonoption_flags_max_len)
         (nonoption_flags_len): Conditional on USE_NONOPTION_FLAGS.
         (SWAP_FLAGS): New definitions.
@@ -2341,7 +2626,7 @@
 2002-08-29  Francesco Potortì  <pot@gnu.org>
 
         * etags.c (C_entries): Correct a problem with const C++ funcs.
-        (ignoreindent): Renamed from noindentypedefs.
+        (ignoreindent): Rename from noindentypedefs.
         (cjava, cplpl): They are now macros instead of local vars.
 
 2002-08-28  Francesco Potortì  <pot@gnu.org>
@@ -2357,7 +2642,7 @@
         (strcaseeq): Make it into a macro.
 
         * etags.c (make_tag): Never generate null length tag names.
-        (linebuffer_init): Renamed from initbuffer.  All callers changed.
+        (linebuffer_init): Rename from initbuffer.  All callers changed.
         (pattern): Structure renamed to `regexp', member regex renamed to
         pattern.
         (node_st): Member pat renamed to regex.
@@ -2514,8 +2799,8 @@
 
 2002-05-30  Richard M. Stallman  <rms@gnu.org>
 
-        * Makefile.in (LIBS_MAIL): Renamed from LIB_MAIL.
-        (LIBS_MOVE): Renamed from MOVE_LIBS.
+        * Makefile.in (LIBS_MAIL): Rename from LIB_MAIL.
+        (LIBS_MOVE): Rename from MOVE_LIBS.
 
 2002-05-26  Paul Eggert  <eggert@twinsun.com>
 
@@ -2796,21 +3081,21 @@
         (get_tag): Return a pointer to the tag that is found.
 
         * etags.c (LOOKING_AT): Use !intoken instead of iswhite.
-        (F_takeprec): Renamed from takeprec.  All callers changed.
-        (F_getit): Renamed from getit.  All callers changed.
-        (nocase_tail): Renamed from tail.  All callers changed.
-        (Ada_getit): Renamed from adagetit.  All callers changed.
+        (F_takeprec): Rename from takeprec.  All callers changed.
+        (F_getit): Rename from getit.  All callers changed.
+        (nocase_tail): Rename from tail.  All callers changed.
+        (Ada_getit): Rename from adagetit.  All callers changed.
         (L_getit): Simplify by using get_tag.
         (Perl_functions, Postscript_functions, erlang_attribute): Use the
         modified LOOKING_AT.
-        (notinname): Removed '[' and added ')' to the recognised chars.
+        (notinname): Remove '[' and added ')' to the recognised chars.
         (LOOKING_AT, get_tag, PHP_functions): Use notinname.
         (Ada_getit, Ada_funcs, Python_functions, Scheme_functions):
         Clarified, using strneq or notinname.
         (L_isdef, L_isquote): Removed.
         (Lisp_functions, L_getit): Clarified.
 
-        * etags.c (P_): Renamed to __P for consistency with config.h.
+        * etags.c (P_): Rename to __P for consistency with config.h.
         [HAVE_CONFIG_H]: Let config.h deal with __P.
         [__STDC__] [!HAVE_CONFIG_H]: Define PTR as in config.h.
         [!__STDC__] [!HAVE_CONFIG_H]: Do not undefine static, because
@@ -2869,7 +3154,7 @@
         (Perl_functions, Python_functions, PHP_functions)
         (Scheme_functions, Texinfo_nodes): Use it.
         (Perl_functions): Use strneq.
-        (prolog_pred): Renamed to prolog_pr.
+        (prolog_pred): Rename to prolog_pr.
         (prolog_pr): Recognise Prolog rules in addition to predicates.
         [ETAGS_REGEXPS] [!HAVE_CONFIG_H] [__CYGWIN__]: Prevent
         unmodified compile, as Cygwin's regex.h is incompatible with us.
@@ -2968,7 +3253,7 @@
 
 2001-10-13  Gerd Moellmann  <gerd@gnu.org>
 
-        * make-docfile.c (read_c_string_or_comment): Renamed from
+        * make-docfile.c (read_c_string_or_comment): Rename from
         read_c_string.  Add parameter COMMENT.  Read C-style comments.
         (scan_c_file): Handle doc strings in C comments.
 
@@ -3227,12 +3512,12 @@
 
 2001-01-25  Francesco Potortì  <pot@gnu.org>
 
-        * etags.c (struct tok): Renamed from struct token.
-        (token): Renamed from tok.
+        * etags.c (struct tok): Rename from struct token.
+        (token): Rename from tok.
         (structtype): Make it a local variable.
         [DEBUG]: Use assert.
         (xrnew): Change the synopsis.
-        (typedefs_or_cplusplus): Renamed from typedefs_and_cplusplus.
+        (typedefs_or_cplusplus): Rename from typedefs_and_cplusplus.
         (grow_linebuffer): Don't call xrnew when not needed.
         (token): Buffer renamed to line.
         (C_entries): Three calls to inibuffer moved here from main.
@@ -3261,16 +3546,16 @@
 
 2001-01-14  Francesco Potortì  <pot@gnu.org>
 
-        * etags.c (get_language_from_langname): Renamed from
+        * etags.c (get_language_from_langname): Rename from
         get_language_from_name.
-        (get_language_from_filename): Renamed from get_language_from_suffix.
+        (get_language_from_filename): Rename from get_language_from_suffix.
         Now first looks for the complete file name.
         (language): New member char **filenames.
         (Makefile_filenames): List of possible filenames for makefiles.
         (lang_names): Add a NULL member for every entry, added an entry
         for makefiles.
         (Makefile_targets): New function.
-        (Texinfo_nodes): Renamed from Texinfo_fuctions and made
+        (Texinfo_nodes): Rename from Texinfo_fuctions and made
         it conformant to the style of the rest of the code.
 
 2001-01-13  Gerd Moellmann  <gerd@gnu.org>
@@ -3409,7 +3694,7 @@
 
 2000-07-14  Gerd Moellmann  <gerd@gnu.org>
 
-        * ebrowse.c (xrealloc, xmalloc): Renamed from yrealloc and ymalloc.
+        * ebrowse.c (xrealloc, xmalloc): Rename from yrealloc and ymalloc.
 
         * etags.c (xmalloc, xrealloc): Make externally visible, for use
         by alloca.o.
@@ -3446,8 +3731,8 @@
 
 2000-06-06  Gerd Moellmann  <gerd@gnu.org>
 
-        * ebrowse.c (ymalloc): Renamed from xmalloc.
-        (yrealloc): Renamed from xrealloc.
+        * ebrowse.c (ymalloc): Rename from xmalloc.
+        (yrealloc): Rename from xrealloc.
 
 2000-05-21  Dave Love  <fx@gnu.org>
 
@@ -3670,7 +3955,7 @@
         corrects a bug.  All callers changed.
         (canonicalize_filename): New function.
         (process_file, etags_getcwd, absolute_dirname): Use it.
-        (relative_filename, absolute_filename): Removed var shadowing.
+        (relative_filename, absolute_filename): Remove var shadowing.
         (C_entries, Pascal_functions): Add fake initializations to keep
         compilers quiet.
         (TeX_functions, Prolog_functions, Erlang_functions): Cleanup.
@@ -3960,8 +4245,8 @@
 
 1998-05-01  Andrew Innes  <andrewi@harlequin.co.uk>
 
-        * movemail.c [WINDOWSNT]: Undefine DISABLE_DIRECT_ACCESS.  Force
-        all file i/o to be in binary mode.  Include ntlib.h.
+        * movemail.c [WINDOWSNT]: Undefine DISABLE_DIRECT_ACCESS.
+        Force all file i/o to be in binary mode.  Include ntlib.h.
 
 1998-04-27  Andreas Schwab  <schwab@delysid.gnu.org>
 
@@ -3993,8 +4278,8 @@
         return types.  Add forward declarations.
         * emacsclient.c: Include <stdlib.h> and <unistd.h> if available.
         Don't declare geteuid.
-        (print_help_and_exit): Change return type to void.  Forward
-        declare it.
+        (print_help_and_exit): Change return type to void.
+        Forward declare it.
         * b2m.c: Include <stdlib.h> if available.
         (main): Explicitly declare return type.
 
@@ -4006,7 +4291,7 @@
 
 1998-03-26  Richard Stallman  <rms@psilocin.gnu.org>
 
-        * pop.c (pop_getline): Renamed from getline.
+        * pop.c (pop_getline): Rename from getline.
 
 1998-03-05  Richard Stallman  <rms@psilocin.gnu.org>
 
@@ -4031,8 +4316,8 @@
         with a '>' any lines starting with "From " read from the POP server,
         but leave the code in place, wrapped in #ifdef
         MOVEMAIL_QUOTE_POP_FROM_LINES, in case we have to restore it later
-        because it turns out that something is depending on it.  Change
-        suggested by Paul Eggert <eggert@twinsun.com>.
+        because it turns out that something is depending on it.
+        Change suggested by Paul Eggert <eggert@twinsun.com>.
         Convert the character \037 (^_) at the beginning of a line into
         the character '^' followed by the character '_', because otherwise
         Emacs can't parse the resulting file as a valid BABYL file.
@@ -4049,8 +4334,8 @@
         quotes with a '>' any lines starting with "From " read from the
         POP server, but leave the code in place, wrapped in #ifdef
         MOVEMAIL_QUOTE_POP_FROM_LINES, in case we have to restore it later
-        because it turns out that something is depending on it.  Change
-        suggested by Paul Eggert <eggert@twinsun.com>.
+        because it turns out that something is depending on it.
+        Change suggested by Paul Eggert <eggert@twinsun.com>.
 
         Convert the character \037 (^_) at the beginning of a line into
         the character '^' followed by the character '_', because otherwise
@@ -4066,8 +4351,8 @@
 
 1997-10-31  Jonathan I. Kamens  <jik@kamens.brookline.ma.us>
 
-        * pop.c (fullwrite): Get rid of an extra call to write.  Problem
-        pointed out by Chiaki Ishikawa.
+        * pop.c (fullwrite): Get rid of an extra call to write.
+        Problem pointed out by Chiaki Ishikawa.
 
 1997-10-16  Dave Love  <d.love@dl.ac.uk>
 
@@ -4207,8 +4492,8 @@
         (C_entries): Initialise tok.named.
         (sym_type, C_stab_entry, consider_token): st_C_ignore is used to
         get rid of "import", "package" and "friend".
-        (fvdef): Renamed from funcdef.  Also some constants renamed.  All
-        users changed.
+        (fvdef): Rename from funcdef.  Also some constants renamed.
+        All users changed.
         (C_entries): Make separate tags for variables separated by comma.
         (globals, members): New flags.
         (main, C_entries): Use them.
@@ -4222,7 +4507,7 @@
         (consider_token, C_entries): Set the len member of token_name.
         (prolog_pred): Cleanup according to GNU coding standards.
         (Cobol_suffixes, lang_names, Cobol_paragraphs): Cobol support.
-        (prolog_white, erlang_white): Renamed to eat_white, callers changed.
+        (prolog_white, erlang_white): Rename to eat_white, callers changed.
 
 1997-05-15  Francesco Potortì  <F.Potorti@cnuce.cnr.it>
 
@@ -4425,7 +4710,7 @@
 
         * etags.c (relative_filename): Bug corrected.
         (etags_getcwd): Avoid warning of unused variable.
-        (C_entries, consider_token): Added support for enum labels.
+        (C_entries, consider_token): Add support for enum labels.
 
 1996-11-03  Paul Eggert  <eggert@twinsun.com>
 
@@ -4668,14 +4953,14 @@
 
 1996-04-29  Richard Stallman  <rms@delasyd.gnu.ai.mit.edu>
 
-        * pop.c (SEND, RECV): Renamed from send, recv.
+        * pop.c (SEND, RECV): Rename from send, recv.
         (pop_open, pop_trash): Make the trash_started code unconditional.
         (socket_connection): Delete casts to void.
 
 1996-04-28  Richard Stallman  <rms@delasyd.gnu.ai.mit.edu>
 
-        * movemail.c (DIRECTORY_SEP, IS_DIRECTORY_SEP): Definitions
-        copied from lisp.h.
+        * movemail.c (DIRECTORY_SEP, IS_DIRECTORY_SEP):
+        Definitions copied from lisp.h.
 
 1996-04-22  Andrew Innes  <andrewi@harlequin.co.uk>
 
@@ -4785,7 +5070,7 @@
         (lang_names): Erlang entry added.
         (prolog_getit): Accepts headers spanning several lines.
         Always name tags.
-        (Prolog_functions): Removed incorrect compensation for
+        (Prolog_functions): Remove incorrect compensation for
         newline characters.
         (readline_internal): Zero-terminate last line.
 
@@ -4850,7 +5135,7 @@
 
 1995-12-01  Richard Stallman  <rms@whiz-bang.gnu.ai.mit.edu>
 
-        * Makefile.in (THIS_IS_MAKEFILE): Renamed from THIS_IS_YMAKEFILE.
+        * Makefile.in (THIS_IS_MAKEFILE): Rename from THIS_IS_YMAKEFILE.
 
 1995-12-07  Francesco Potortì  <pot@cnuce.cnr.it>
 
@@ -4867,11 +5152,11 @@
 1995-12-06  Francesco Potortì  <pot@cnuce.cnr.it>
 
         * etags.c (Cplusplus_suffixes): Add .M suffix for Objective C++.
-        (gperf): Added keywords for Objective C and GNU macros.
-        (sym_type): Added values to account for Objective C and GNU macros.
+        (gperf): Add keywords for Objective C and GNU macros.
+        (sym_type): Add values to account for Objective C and GNU macros.
         (begtk): The '@' character can start a token.
         (objdef, methodlen, objtag): New variables for Objective C.
-        (consider_token, C_entries): Added code for Objective C.
+        (consider_token, C_entries): Add code for Objective C.
         (plain_C_suffixes): Add .m and .lm for Objective C.
         (Yacc_suffixes): Add .ym for Objective yacc.
         (GROW_LINEBUFFER): New macro.
@@ -4912,8 +5197,8 @@
 
 1995-11-06  Francesco Potortì  (pot@cnuce.cnr.it)
 
-        * etags.c (get_lang_from_name, get_lang_from_interpreter,
-        get_lang_from_suffix): New functions.
+        * etags.c (get_lang_from_name, get_lang_from_interpreter)
+        (get_lang_from_suffix): New functions.
         (get_language): Function deleted.
         (lang_entry): Two members added to struct.
         (lang_names): Reflect the new layout of lang_entry.
@@ -4928,12 +5213,12 @@
         * etags.c (lowcase): Use the standard tolower function.
         (substitute): Remove some wrong and some useless code related with
         escape '\' character in regexp replacement string.
-        (TEX_defenv): Added part, appendix, entry, index.  Removed typeout.
+        (TEX_defenv): Add part, appendix, entry, index.  Remove typeout.
         (lang_suffixes): New suffixes: .hpp for C++; .f90 for Fortran;
         .bib, .ltx, .TeX for TeX (.bbl, .dtx removed); .ml for Lisp;
         .prolog for prolog (.pl removed).
         (massage_name, etags_getcwd): Use lowcase instead of tolower.
-        (C_entries, find_entries): Added comments about memory leakage.
+        (C_entries, find_entries): Add comments about memory leakage.
         (add_node): Dead code removed.
 
 1995-10-29  Richard Stallman  <rms@mole.gnu.ai.mit.edu>
@@ -5175,7 +5460,7 @@
 
 1995-04-08  Richard Stallman  <rms@mole.gnu.ai.mit.edu>
 
-        * Makefile.in.in (BASE_CFLAGS): Renamed from ALLOCA_CFLAGS.
+        * Makefile.in.in (BASE_CFLAGS): Rename from ALLOCA_CFLAGS.
         (alloca.o, regex.o): Use BASE_CFLAGS.
 
 1995-04-06  Richard Stallman  <rms@mole.gnu.ai.mit.edu>
@@ -5185,7 +5470,7 @@
 1995-04-04  Karl Heuer  <kwzh@gnu.ai.mit.edu>
 
         * Makefile.in.in (aixcc, aixcc.c): Targets deleted.
-        (SOURCES, distclean): Removed obsolete references to aixcc.
+        (SOURCES, distclean): Remove obsolete references to aixcc.
 
 1995-04-02  Richard Stallman  <rms@mole.gnu.ai.mit.edu>
 
@@ -5228,7 +5513,7 @@
         savetok.valid.  Mark token as valid when it is initialised.
         (make_tag): Make token only if token is valid and reset validity.
         (CNL_SAVE_DEFINEDEF): Test for savetok.valid instead of token_saved.
-        (TOKEN): Added a new member: valid.
+        (TOKEN): Add a new member: valid.
 
 1995-02-15  Francesco Potortì  (pot@cnuce.cnr.it)
 
@@ -5250,12 +5535,12 @@
 
 1995-02-07  Richard Stallman  <rms@pogo.gnu.ai.mit.edu>
 
-        * Makefile.in.in (maintainer-clean): Renamed from realclean.
+        * Makefile.in.in (maintainer-clean): Rename from realclean.
 
 1995-02-01  Francesco Potortì  (pot@cnuce.cnr.it)
 
         * etags.c (pfnote): Initialise been_warned in the node.
-        (C_entries): Removed a speed hack for the sake of clarity.
+        (C_entries): Remove a speed hack for the sake of clarity.
 
 1995-01-18  Francesco Potortì  (pot@cnuce.cnr.it)
 
@@ -5374,7 +5659,7 @@
         (print_help): Help strings updated.  Calls print_language_names.
         (argument_type, ARGUMENT): Typedefs for dealing with language and
         regex options intermixed with filenames.
-        (main): Changed the way of dealing with arguments on the command
+        (main): Change the way of dealing with arguments on the command
         line to deal with language and regex options intermixed with
         filenames.
         (get_language, default_C_entries, Cplusplus_entries,
@@ -5463,8 +5748,8 @@
 
         * pop.c: Don't include <string.h> and <strings.h>.
 
-        * pop.c: Include <des.h> before <krb.h>, rather than after.  They
-        should be interchangeable, and indeed the inclusion is done in
+        * pop.c: Include <des.h> before <krb.h>, rather than after.
+        They should be interchangeable, and indeed the inclusion is done in
         both orders in various files in the Kerberos 4 library sources,
         but djm@va.pubnix.com (David J. MacKenzie) reports that BSDI
         requires that <des.h> be included first, and I don't see any harm
@@ -5494,8 +5779,8 @@
 
 1994-10-17  Andreas Schwab  <schwab@issan.informatik.uni-dortmund.de>
 
-        * emacsserver.c [SYSV_IPC] (main): Catch SIGHUP as well.  Don't
-        call kill with pid 0.  Handle EINTR when receiving messages.
+        * emacsserver.c [SYSV_IPC] (main): Catch SIGHUP as well.
+        Don't call kill with pid 0.  Handle EINTR when receiving messages.
 
 1994-10-17  Karl Heuer  <kwzh@gnu.ai.mit.edu>
 
@@ -5526,7 +5811,7 @@
         * Makefile.in.in (clean): rm DOC* and *.tab.[ch].
         (distclean): Not here.
 
-        * Makefile.in.in (libexecdir): Renamed from libdir.
+        * Makefile.in.in (libexecdir): Rename from libdir.
 
 1994-10-11  Francesco Potortì  (pot@cnuce.cnr.it)
 
@@ -5756,7 +6041,7 @@
         print advice to run it, if it has anything significant to do.
         And only if MOVEMAIL_NEEDS_BLESSING.
         (blessmail): Use emacs, not temacs.
-        (configuration): Renamed from configname.
+        (configuration): Rename from configname.
 
 1994-04-30  Morten Welinder  (terra@diku.dk)
 
@@ -5840,15 +6125,15 @@
 
 1994-04-08  Francesco Potortì  (pot@fly.cnuce.cnr.it)
 
-        * etags.c (outf, outfiledir): Renamed to tagf, tagfiledir.
+        * etags.c (outf, outfiledir): Rename to tagf, tagfiledir.
         (PF_funcs, Asm_funcs, L_funcs, PAS_funcs, TEX_funcs)
-        (Scheme_funcs, prolog_funcs): Renamed to Fortran_functions,
+        (Scheme_funcs, prolog_funcs): Rename to Fortran_functions,
         Asm_labels, Lisp_functions, Pascal_functions, Scheme_functions,
         TeX_functions, Prolog_functions.
         (inf): No more a global variable.
         (C_entries): Take 2nd parameter `inf' instead of using the global one.
-        (find_entries): Added the cp1 var for optimisation.
-        (find_entries): Added more suffixes for assembler files.
+        (find_entries): Add the cp1 var for optimisation.
+        (find_entries): Add more suffixes for assembler files.
         (Asm_funcs): Now finds labels even without an ending colon.
 
 1994-03-30  Francesco Potortì  (pot@fly.cnuce.cnr.it)
@@ -5876,7 +6161,7 @@
         (process_file): Filenames in tags file are relative to the
         directory where the tags file is (useful with the -o option).
         (main): Initialise the outfiledir var.
-        (TYPEDST): Added the `tignore' value.
+        (TYPEDST): Add the `tignore' value.
         (C_entries): Corrected various small bugs.
 
 1994-03-19  Richard Stallman  (rms@mole.gnu.ai.mit.edu)
@@ -5892,7 +6177,7 @@
 
 1994-03-14  Francesco Potortì  (pot@cnuce.cnr.it)
 
-        * etags.c (TYPEDST): Added the `tignore' value.
+        * etags.c (TYPEDST): Add the `tignore' value.
         (C_entries): Corrected various bugs, now correctly parses the
         `extern "C" {' construction (patch by Tom R.Hageman).
 
@@ -5946,7 +6231,7 @@
 
 1994-02-14  Francesco Potortì  (pot@fly)
 
-        * etags.c (absolute_pathnames, cwd): Added global vars.
+        * etags.c (absolute_pathnames, cwd): Add global vars.
         (longopts, print_help, main, process_file): Put absolute filenames
         in the tag file if the -A --absolute-pathnames option is used.
         (print_help): Alphabetically order the options.
@@ -5983,7 +6268,7 @@
         Use gperf generated hash table instead of linked list.
         (C_stab_entry, hash, in_word_set, get_C_stab, C_symtype): Added.
         Mostly code generated by gperf.
-        (consider_token): Removed unused parameter `lp'.
+        (consider_token): Remove unused parameter `lp'.
         (PF_funcs, getit): Allow subroutine and similar declarations
         to span multiple lines.
         (C_entries): Check for newline if inchar to avoid bus errors.
@@ -6130,7 +6415,7 @@
 
 1993-11-02  Francesco Potortì  (pot@cnuce.cnr.it)
 
-        * etags.c (consider_token): Removed unused variable firsttok.
+        * etags.c (consider_token): Remove unused variable firsttok.
         (prolog_getit): Call pfnote with the right number of arguments.
 
 1993-10-19  Paul Eggert  (eggert@twinsun.com)
@@ -6160,13 +6445,13 @@
         from current directory.  Only chmod and chgrp files that we
         installed, which excludes ${INSTALLABLE_SCRIPTS}.  They go in
         ${bindir}.
-        (INSTALLFLAGS): Deleted definition, since it is an unused variable
+        (INSTALLFLAGS): Delete definition, since it is an unused variable
         now.
 
 1993-09-27  Brian J. Fox  (bfox@ai.mit.edu)
 
-        * Makefile.in (INSTALL, INSTALL_PROGRAM, INSTALL_DATA): Let
-        configure figure out the correct values for these variables.
+        * Makefile.in (INSTALL, INSTALL_PROGRAM, INSTALL_DATA):
+        Let configure figure out the correct values for these variables.
 
 1993-09-14  Brian J. Fox  (bfox@ai.mit.edu)
 
@@ -6251,7 +6536,7 @@
 
 1993-07-30  Francesco Potortì  (pot@cnuce.cnr.it)
 
-        * etags.c (FINCST): Added the fignore status.  Means we are
+        * etags.c (FINCST): Add the fignore status.  Means we are
         after the parameter list and before the open curly brace.
         Allows correct parsing of C++ constructors.
         (C_entries, consider_token): Make use of fignore.
@@ -6290,7 +6575,7 @@
 
 1993-07-08  Francesco Potortì  (pot@cnuce.cnr.it)
 
-        * etags.c (alloca): Removed all references to it.
+        * etags.c (alloca): Remove all references to it.
         (main): Now calls xnew instead of alloca for portability.
         (../src/config.h): Included only if HAVE_CONFIG_H.
         (const): Void definition removed--config.h takes care of it.
@@ -6302,7 +6587,7 @@
 
         * etags.c (LEVEL_OK_FOR_FUNCDEF): Removed.
         (C_entries): Optimized the test that used LEVEL_OK_FOR_FUNCDEF.
-        (C_entries): Removed a piece of useless code.
+        (C_entries): Remove a piece of useless code.
         (C_entries): Making typedef tags is delayed until a semicolon
         is met.  This handles "typedef int X, Y, Z;" correctly.
 
@@ -6564,7 +6849,7 @@
 
 1993-04-09  Jim Blandy  (jimb@totoro.cs.oberlin.edu)
 
-        * Makefile.in (DEFS): Renamed from CONFIG_CFLAGS.
+        * Makefile.in (DEFS): Rename from CONFIG_CFLAGS.
 
 1993-04-07  Jim Blandy  (jimb@churchy.gnu.ai.mit.edu)
 
@@ -6586,7 +6871,7 @@
         (get_C_stab): c_ext becomes c_ext&C_PLPL.
         (C_entries): Logical cplpl means c_ext&C_PLPL.
         (C_entries): Logical yacc_rules means we are after the first %%.
-        (C_entries): Added logic for yacc files.
+        (C_entries): Add logic for yacc files.
 
 1993-03-16  Francesco Potortì  (pot@cnuce.cnr.it)
 
@@ -6604,7 +6889,7 @@
         (TOKEN): Member linestart removed.
         (linepos, prev_linepos, lb1): Deleted.
         (main): Call initbuffer on lbs array instead of lb1.
-        (init): Removed the initialisation of the logical _gd array.
+        (init): Remove the initialisation of the logical _gd array.
         (find_entries): A .sa suffix means assembler file.
         (C_create_stab): "auto", "void", "extern", "static" are st_C_typespec.
         All C state machines rewritten.
@@ -6614,7 +6899,7 @@
 
 1993-03-01  Francesco Potortì  (pot@fly.CNUCE.CNR.IT)
 
-        * etags.c (C_entries): Added the quotednl logical variable.
+        * etags.c (C_entries): Add the quotednl logical variable.
         Used for parsing of #define's spanning multiple lines.
 
 1993-02-23  Francesco Potortì  (pot@fly.CNUCE.CNR.IT)
@@ -6624,7 +6909,7 @@
 
 1993-03-19  Eric S. Raymond  (eric@geech.gnu.ai.mit.edu)
 
-        * Makefile.in (EXECUTABLES): Added rcs-checkin.
+        * Makefile.in (EXECUTABLES): Add rcs-checkin.
 
         * Makefile.in (unlock, relock): New productions.
 
@@ -6685,7 +6970,7 @@
         * Makefile.in (CFLAGS): #define HAVE_CONFIG_H, too.
 
         * Makefile.in (libdir): Default to ${prefix}/lib.
-        (archlibdir): Adjusted to match.
+        (archlibdir): Adjust to match.
 
         * Makefile.in (distclean): Don't delete backup or autosave files.
         (extraclean): Like realclean, but does delete backup and autosave
@@ -6720,7 +7005,7 @@
 
 1992-11-05  Jim Blandy  (jimb@totoro.cs.oberlin.edu)
 
-        * Makefile.in (getdate.o): Added explicit target for this, so we
+        * Makefile.in (getdate.o): Add explicit target for this, so we
         can indicate that it depends on ../src/config.h.
 
 1992-11-04  Jim Blandy  (jimb@totoro.cs.oberlin.edu)
@@ -6788,7 +7073,7 @@
         array.  When an event fires, move the last event in the array into
         its spot.  Use num_events to determine whether or not there are
         any pending events, not wait_for.
-        (getevent): Deleted unused variable `ep'.
+        (getevent): Delete unused variable `ep'.
         (sigcatch): It's now easier to find all the active events.
         (main): Initialize num_events.
 
@@ -6801,7 +7086,7 @@
         (process_file, find_entries, pfnote, TEX_funcs, TEX_decode_env,
         TEX_getit, substr): Use the etags_*index functions, rather than
         the native *index functions.
-        (rindex, index): Renamed to etags_rindex and tags_rindex, and
+        (rindex, index): Rename to etags_rindex and tags_rindex, and
         made them unconditionally defined, rather than having them depend
         on NEED_*INDEX.
 
@@ -6888,7 +7173,7 @@
 
 1992-05-10  Roland McGrath  (roland@albert.gnu.ai.mit.edu)
 
-        * etags.c (C_entries): Fixed reading of "..." strings.
+        * etags.c (C_entries): Fix reading of "..." strings.
         (consider_token): Recognize `SYSCALL' and `PSEUDO' macros, used in
         the C library source.
 
@@ -6916,7 +7201,7 @@
 
 1992-04-17  Jim Blandy  (jimb@pogo.cs.oberlin.edu)
 
-        * timer.c (getevent): Removed declaration of memcpy; since
+        * timer.c (getevent): Remove declaration of memcpy; since
         different systems have different return types, and we're not even
         using the return type anyway, it wasn't doing us any good.
 
@@ -6951,7 +7236,7 @@
 
 1992-04-06  Jim Blandy  (jimb@pogo.cs.oberlin.edu)
 
-        * etags.c (C_entries): Removed comment saying that \" in a string
+        * etags.c (C_entries): Remove comment saying that \" in a string
         isn't recognized as magic, because it is correctly handled.
 
         * getopt.c, getopt.h: New files, from GNU C library.
@@ -6961,8 +7246,8 @@
         optind.
         (main): Argument processing loop rewritten to call getopt to get
         next option.  Options which take parameters (-o and -i) rewritten
-        to get parameter from optarg instead of argv[1].  Filename
-        preprocessing loop and update command changed similarly.
+        to get parameter from optarg instead of argv[1].
+        Filename preprocessing loop and update command changed similarly.
         * Makefile (etags, ctags): Depend on and link with getopt.h,
         getopt.o, and getopt1.o.
         (getopt.o, getopt1.o): New targets for the GNU getopt routines.
@@ -7103,8 +7388,8 @@
 1991-01-25  Jim Blandy  (jimb@churchy.ai.mit.edu)
 
         * make-docfile: Find the arguments to a C function correctly,
-        by not ignoring the character that read_c_string returns.  Don't
-        even try to find argument names for functions that take MANY
+        by not ignoring the character that read_c_string returns.
+        Don't even try to find argument names for functions that take MANY
         or UNEVALLED arguments, since they're a figment of the docstring's
         imagination.
 
@@ -7492,8 +7777,8 @@
 
 1988-05-13  Chris Hanson  (cph@kleph)
 
-        * emacsclient.c: Delete references to unused variable `out'.  This
-        caused a bus error when used under hp-ux.
+        * emacsclient.c: Delete references to unused variable `out'.
+        This caused a bus error when used under hp-ux.
 
 1988-05-06  Richard Stallman  (rms@frosted-flakes.ai.mit.edu)