diff options
| author | Paul Eggert | 2014-05-18 21:56:03 -0700 |
|---|---|---|
| committer | Paul Eggert | 2014-05-18 21:56:03 -0700 |
| commit | 60fc70a8e0bf25d7388fb4c2e31d912c203f561d (patch) | |
| tree | 19edf3db0317cd7c5ab3c7b001214b9b7e33c061 /lib-src/ChangeLog | |
| parent | 337ee6b38ea35823ab77a03b3841cf888904b336 (diff) | |
| download | emacs-60fc70a8e0bf25d7388fb4c2e31d912c203f561d.tar.gz emacs-60fc70a8e0bf25d7388fb4c2e31d912c203f561d.zip | |
Remove dependencies on getdelim and getline.
Also, remove update-game-scores's limits on game scores and
simplify its file-locking code.
* configure.ac (getdelim, getline): Remove.
* lib-src/update-game-score.c (struct score_entry): Unify the username and
data members to a single user_data member, since they don't need to be
changed independently and getdelim and getline aren't helpful.
Make the score member char *, not intmax_t, so that scores are not
limited to intmax_t. All uses changed.
(lose_syserr): A zero errno stands for invalid data in score file.
(normalize_integer): New function.
(main): Use it. Check for invalid scores. Omit redundant stat check.
(read_score): First arg is now a string, not a FILE *. All uses
changed. Do not use getdelim or getline; that's way simpler.
(read_scores): Read the whole file, and let read_score handle each
line.
(score_compare): Compare strings representing integers, not integers.
(write_scores) [DOS_NT]: Eliminate unnecessary chmod.
(lock_file): Simplify locking code, eliminating goto.
Check for unlink failure.
Diffstat (limited to 'lib-src/ChangeLog')
| -rw-r--r-- | lib-src/ChangeLog | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog index 3fac70b3f73..3ac401b16a3 100644 --- a/lib-src/ChangeLog +++ b/lib-src/ChangeLog | |||
| @@ -1,3 +1,25 @@ | |||
| 1 | 2014-05-19 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | Remove dependencies on getline and getdelim. | ||
| 4 | Also, remove update-game-scores's limits on game scores and | ||
| 5 | simplify its file-locking code. | ||
| 6 | * update-game-score.c (struct score_entry): Unify the username and | ||
| 7 | data members to a single user_data member, since they don't need to be | ||
| 8 | changed independently and getdelim and getline aren't helpful. | ||
| 9 | Make the score member char *, not intmax_t, so that scores are not | ||
| 10 | limited to intmax_t. All uses changed. | ||
| 11 | (lose_syserr): A zero errno stands for invalid data in score file. | ||
| 12 | (normalize_integer): New function. | ||
| 13 | (main): Use it. Check for invalid scores. Omit redundant stat check. | ||
| 14 | (read_score): First arg is now a string, not a FILE *. All uses | ||
| 15 | changed. Do not use getdelim or getline; that's way simpler. | ||
| 16 | (read_scores): Read the whole file, and let read_score handle each | ||
| 17 | line. | ||
| 18 | (score_compare): Compare strings representing integers, not integers. | ||
| 19 | (write_scores) [DOS_NT]: Eliminate unnecessary chmod. | ||
| 20 | (lock_file): Simplify locking code, eliminating goto. | ||
| 21 | Check for unlink failure. | ||
| 22 | |||
| 1 | 2014-05-18 Paul Eggert <eggert@cs.ucla.edu> | 23 | 2014-05-18 Paul Eggert <eggert@cs.ucla.edu> |
| 2 | 24 | ||
| 3 | Port ctags+etags build to Sun C 5.12. | 25 | Port ctags+etags build to Sun C 5.12. |