aboutsummaryrefslogtreecommitdiffstats
path: root/java
diff options
context:
space:
mode:
authorPo Lu2024-04-06 11:17:49 +0800
committerPo Lu2024-04-06 11:17:49 +0800
commit617bd85cd0bd1d0a73d405d623ee3dd41c7e8a37 (patch)
tree68999cb056acde01fb7308096056aa9332c325d8 /java
parent0286a11f3139dfd4bb9d3989ae860b8c128e12d0 (diff)
downloademacs-617bd85cd0bd1d0a73d405d623ee3dd41c7e8a37.tar.gz
emacs-617bd85cd0bd1d0a73d405d623ee3dd41c7e8a37.zip
Correct typos in and omissions from earlier Android port changes
* java/AndroidManifest.xml.in: Remove duplicate permissions. * java/org/gnu/emacs/EmacsWindowManager.java (removeWindowConsumer): Disregard isFinishing for non-initial activities.
Diffstat (limited to 'java')
-rw-r--r--java/AndroidManifest.xml.in5
-rw-r--r--java/org/gnu/emacs/EmacsWindowManager.java13
2 files changed, 9 insertions, 9 deletions
diff --git a/java/AndroidManifest.xml.in b/java/AndroidManifest.xml.in
index 563914fb02c..f1047ac41d8 100644
--- a/java/AndroidManifest.xml.in
+++ b/java/AndroidManifest.xml.in
@@ -31,7 +31,7 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. -->
31 android:versionName="@version@"> 31 android:versionName="@version@">
32 32
33 <!-- Paste in every permission in existence so Emacs can do 33 <!-- Paste in every permission in existence so Emacs can do
34 anything. --> 34 everything. -->
35 35
36 <uses-permission android:name="android.permission.READ_CONTACTS" /> 36 <uses-permission android:name="android.permission.READ_CONTACTS" />
37 <uses-permission android:name="android.permission.WRITE_CONTACTS" /> 37 <uses-permission android:name="android.permission.WRITE_CONTACTS" />
@@ -95,8 +95,6 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. -->
95 <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" /> 95 <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
96 <uses-permission android:name="android.permission.READ_MEDIA_VISUAL_USER_SELECTED" /> 96 <uses-permission android:name="android.permission.READ_MEDIA_VISUAL_USER_SELECTED" />
97 <uses-permission android:name="android.permission.READ_PHONE_NUMBERS" /> 97 <uses-permission android:name="android.permission.READ_PHONE_NUMBERS" />
98 <uses-permission android:name="android.permission.READ_SMS" />
99 <uses-permission android:name="android.permission.RECEIVE_MMS" />
100 <uses-permission android:name="android.permission.RECEIVE_WAP_PUSH" /> 98 <uses-permission android:name="android.permission.RECEIVE_WAP_PUSH" />
101 <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" /> 99 <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
102 <uses-permission android:name="android.permission.SMS_FINANCIAL_TRANSACTIONS" /> 100 <uses-permission android:name="android.permission.SMS_FINANCIAL_TRANSACTIONS" />
@@ -185,7 +183,6 @@ along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. -->
185 <uses-permission android:name="android.permission.USE_EXACT_ALARM" /> 183 <uses-permission android:name="android.permission.USE_EXACT_ALARM" />
186 <uses-permission android:name="android.permission.USE_FINGERPRINT" /> 184 <uses-permission android:name="android.permission.USE_FINGERPRINT" />
187 <uses-permission android:name="android.permission.WRITE_PROFILE" /> 185 <uses-permission android:name="android.permission.WRITE_PROFILE" />
188 <uses-permission android:name="android.permission.WRITE_SMS" />
189 <uses-permission android:name="android.permission.WRITE_SOCIAL_STREAM" /> 186 <uses-permission android:name="android.permission.WRITE_SOCIAL_STREAM" />
190 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS" /> 187 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS" />
191 <uses-permission android:name="android.permission.WRITE_USER_DICTIONARY" /> 188 <uses-permission android:name="android.permission.WRITE_USER_DICTIONARY" />
diff --git a/java/org/gnu/emacs/EmacsWindowManager.java b/java/org/gnu/emacs/EmacsWindowManager.java
index a239fdc8ac2..41ea3a15809 100644
--- a/java/org/gnu/emacs/EmacsWindowManager.java
+++ b/java/org/gnu/emacs/EmacsWindowManager.java
@@ -221,11 +221,14 @@ public final class EmacsWindowManager
221 { 221 {
222 consumer.detachWindow (); 222 consumer.detachWindow ();
223 223
224 /* Though pruneWindows will likely remove the same windows, call 224 /* Though pruneWindows will likely remove the same window(s),
225 onActivityDetached anyway if isFinishing is set, as in 225 call onActivityDetached anyway if isFinishing is set, if
226 obscure circumstances pruneWindows will not remove frames 226 CONSUMER not be a multitasking activity, as in obscure
227 bound to the system-started task. */ 227 circumstances pruneWindows will not remove frames bound to
228 if (isFinishing) 228 the system-started task. */
229 if (isFinishing
230 && (!(consumer instanceof EmacsMultitaskActivity)
231 || Build.VERSION.SDK_INT < Build.VERSION_CODES.Q))
229 window.onActivityDetached (); 232 window.onActivityDetached ();
230 } 233 }
231 234