diff options
| author | Paul Eggert | 2020-01-07 11:23:11 -0800 |
|---|---|---|
| committer | Paul Eggert | 2020-01-07 11:29:42 -0800 |
| commit | 724af7671590cd91df37f64df6be73f6dca0144d (patch) | |
| tree | 075df63dcdc3653ff710ce49a5f238c165d0f0c1 /etc | |
| parent | f950b078a6f2fd011312e9471998edf6b5fb957e (diff) | |
| download | emacs-724af7671590cd91df37f64df6be73f6dca0144d.tar.gz emacs-724af7671590cd91df37f64df6be73f6dca0144d.zip | |
Fix sxhash-equal on bytecodes, markers, etc.
Problem reported by Pip Cet (Bug#38912#14).
* doc/lispref/objects.texi (Equality Predicates):
Document better when ‘equal’ looks inside objects.
* doc/lispref/windows.texi (Window Configurations):
Don’t say that ‘equal’ looks inside window configurations.
* etc/NEWS: Mention the change.
* src/fns.c (internal_equal):
Do not look inside window configurations.
(sxhash_obj): Hash markers, byte-code function objects,
char-tables, and font objects consistently with Fequal.
* src/window.c (compare_window_configurations):
Now static. Remove last argument. Caller changed.
* test/lisp/ffap-tests.el (ffap-other-window--bug-25352):
Use compare-window-configurations, not ‘equal’.
* test/src/fns-tests.el (test-sxhash-equal): New test.
Diffstat (limited to 'etc')
| -rw-r--r-- | etc/NEWS | 6 |
1 files changed, 6 insertions, 0 deletions
| @@ -42,6 +42,12 @@ applies, and please also update docstrings as needed. | |||
| 42 | 42 | ||
| 43 | * Incompatible Lisp Changes in Emacs 28.1 | 43 | * Incompatible Lisp Changes in Emacs 28.1 |
| 44 | 44 | ||
| 45 | ** 'equal' no longer examines some contents of window configurations. | ||
| 46 | Instead, it considers window configurations to be equal only if they | ||
| 47 | are eq. To compare contents, use compare-window-configurations | ||
| 48 | instead. This change helps fix a bug in sxhash-equal, which returned | ||
| 49 | incorrect hashes for window configurations and some other objects. | ||
| 50 | |||
| 45 | 51 | ||
| 46 | * Lisp Changes in Emacs 28.1 | 52 | * Lisp Changes in Emacs 28.1 |
| 47 | 53 | ||